https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Bug ID: 2283850 Summary: Review Request: rust-rusty_paseto - rust-rusty_paseto Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@lecris.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/LecrisUT/rusty_parserk-paseto-rpmspec/raw/6af57bdf59c2f18... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_par... Description: Dependency for `atuin` Fedora Account System Username: lecris
rust2rpm.toml ```toml [[package.extra-patches]] comments = [ "Remove example and patch dependencies", ] file = "rust-rusty_paseto-0.7.0-Patch_dependencies.diff" number = 10
[scripts.prep] post = [ "# Remove examples", "rm -r examples", ] ```
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- There seems to be some problem with the following file. SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_par... Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2283849
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283849 [Bug 2283849] Review Request: rust-rusty_paserk - Platform Agnostic Serializable Keys
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2283851
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283851 [Bug 2283851] Review Request: rust-primes - Package for calculating primes using the Sieve of Eratosthenes
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #2 from Cristian Le fedora@lecris.me --- Spec URL: https://github.com/LecrisUT/rusty_parserk-paseto-rpmspec/raw/3c3f0e08e67ae68... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_par...
rust2rpm.toml ```toml [[package.extra-patches]] comments = [ "Remove example and patch dependencies", ] file = "rust-rusty_paseto-0.7.0-Patch_dependencies.diff" number = 10
[scripts.prep] post = [ "# Remove examples", "rm -r examples", ] ```
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ru | |sty_paseto
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7504977 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Flags| |fedora-review? Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Status|NEW |ASSIGNED
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Bump to rusty_paseto = "0.7.1"
-
# * Remove example and patch dependencies Patch10: rust-rusty_paseto-0.6.1-Patch_dependencies.diff
why don't you use rust2rpm -p for this?
rust2rpm rusty_paseto -p Downloading rusty_paseto-0.7.1.crate: 100%| • Generated: rust-rusty_paseto.spec • Generated: rusty_paseto-fix-metadata.diff
--- rusty_paseto-0.7.1/Cargo.toml 1970-01-01T00:00:01+00:00 +++ rusty_paseto-0.7.1/Cargo.toml 2024-06-02T04:10:47.097553+00:00 @@ -37,10 +37,6 @@ [lib] doctest = true
-[[example]] -name = "actix_identity" -required-features = ["default"] - [dependencies.aes] version = "0.7.5" features = ["ctr"] @@ -71,7 +67,7 @@ optional = true
[dependencies.erased-serde] -version = "0.4.5" +version = "0.4.4" optional = true
[dependencies.hex] @@ -83,7 +79,7 @@ optional = true
[dependencies.iso8601] -version = "0.6.1" +version = ">=0.4.2"
[dependencies.p384] version = "0.13.0" @@ -124,9 +120,6 @@ version = "1.4.3" features = ["zeroize_derive"]
-[dev-dependencies.actix-identity] -version = "0.4.0" - [dev-dependencies.actix-utils] version = "3.0.0"
@@ -137,7 +130,7 @@ version = "1.0.45"
[dev-dependencies.erased-serde] -version = "0.4.5" +version = "0.4.4"
[dev-dependencies.primes] version = "0.3.0"
- Add the details of the patch:
# Manually created patch for downstream crate metadata changes # - Remove examples # - Relax erased-serde to 0.4.4 # - Relax iso8601 to >=0.4.2 Patch: rusty_paseto-fix-metadata.diff
- Check line encodings and send a patch upstream:
rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/authentication_key_impl/v1_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/authentication_key_impl/v3_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/authentication_key_impl/v4_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/cipher_text_impl/v1_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/cipher_text_impl/v1_public.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/cipher_text_impl/v2_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/cipher_text_impl/v3_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/cipher_text_impl/v4_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/encryption_key_impl/v1_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/encryption_key_impl/v3_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/encryption_key_impl/v4_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/mod.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/raw_payload_impl/nist_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/raw_payload_impl/v2_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/raw_payload_impl/v4_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/raw_payload_impl/v_public.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/tag_impl/nist_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/common/tag_impl/v4_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/key/paseto_nonce_impl/v1_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/key/paseto_nonce_impl/v2_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/key/paseto_nonce_impl/v2_public.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/key/paseto_nonce_impl/v3_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/key/paseto_nonce_impl/v4_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v1_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v1_public.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v2_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v2_public.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v3_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v3_public.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v4_local.rs rust-rusty_paseto-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rusty_paseto-0.7.1/src/core/paseto_impl/v4_public.rs
find . -type f -name "*.rs" -exec sed -i 's/\r$//' {} +
Needinfo me then.
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #5 from Cristian Le fedora@lecris.me --- Spec URL: https://github.com/LecrisUT/rusty_parserk-paseto-rpmspec/raw/a68b2628e1f4ead... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_par...
rust2rpm.toml ```toml [[package.extra-patches]] comments = [ "Patch Cargo.toml:", "- Remove examples", "- Relax erased-serde to 0.4.4", "- Relax iso8601 to >=0.4.2", ] file = "rust-rusty_paseto-0.7.1-Patch_dependencies.diff" number = 10
[scripts.prep] post = [ "# Remove examples", "rm -r examples", ] ```
---
why don't you use rust2rpm -p for this?
I do, but I just copy the contents to extra-patches so that it is more easily reproducible, and it doesn't affect the spec file itself, so it can be placed in either patch.
Check line encodings and send a patch upstream
Thanks, PR sent: https://github.com/rrrodzilla/rusty_paseto/pull/41 Should we fix them in the spec file for 0.7.1, or keep it like this since it only affects the -devel package?
https://bugzilla.redhat.com/show_bug.cgi?id=2283850 Bug 2283850 depends on bug 2283851, which changed state.
Bug 2283851 Summary: Review Request: rust-primes - Package for calculating primes using the Sieve of Eratosthenes https://bugzilla.redhat.com/show_bug.cgi?id=2283851
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #6 from Fabio Valentini decathorpe@gmail.com ---
I do, but I just copy the contents to extra-patches so that it is more easily reproducible, and it doesn't affect the spec file itself, so it can be placed in either patch.
I would strongly recommend *not* to do this: It gives you only additional work for zero benefits.
Patches for Cargo.toml (i.e. with "rust2rpm -p") almost always need to be rebased for every version. So the only thing you get is divergence from other Rust packages and additional manual work every time (renaming files and removing the generated patch from the spec file).
You can save comments that apply to a manually created Cargo.toml patch with the "package.cargo-toml-patch-comments" setting. I would recommend to use this instead of abusing the "extra-patches" setting for this, which is *not* what it is intended to do. (I should know, I implemented this feature in rust2rpm.)
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #7 from Cristian Le fedora@lecris.me --- (In reply to Fabio Valentini from comment #6)
I do, but I just copy the contents to extra-patches so that it is more easily reproducible, and it doesn't affect the spec file itself, so it can be placed in either patch.
I would strongly recommend *not* to do this: It gives you only additional work for zero benefits.
Fair point, I will change it moving forward
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2036167 --> https://bugzilla.redhat.com/attachment.cgi?id=2036167&action=edit The .spec file difference from Copr build 7504977 to 7525219
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7525219 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #10 from Robert-André Mauchin 🐧 zebob.m@gmail.com ---
Should we fix them in the spec file for 0.7.1, or keep it like this since it only affects the -devel package?
Apply the patch now.
And please use Fabio's recommendation for patching.
Package approved otherwise.
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #11 from Cristian Le fedora@lecris.me --- Spec URL: https://github.com/LecrisUT/rusty_parserk-paseto-rpmspec/raw/d43daf5f4c9c04d... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-rusty_par...
rust2rpm.toml ```toml [package] cargo-toml-patch-comments = [ "- Remove examples", "- Relax erased-serde to 0.4.4", "- Relax iso8601 to >=0.4.2", ]
[scripts.prep] post = [ "# Remove examples", "rm -r examples", "# Fix line-ending, remove in next version", "# https://github.com/rrrodzilla/rusty_paseto/pull/41", "find . -type f -name '*.rs' -exec sed -i 's/\r$//' {} +", ] ```
rusty_paseto-fix-metadata.diff ``` --- rusty_paseto-0.7.1/Cargo.toml 1970-01-01T00:00:01+00:00 +++ rusty_paseto-0.7.1/Cargo.toml 2024-07-04T09:04:01.576566+00:00 @@ -37,10 +37,6 @@ [lib] doctest = true
-[[example]] -name = "actix_identity" -required-features = ["default"] - [dependencies.aes] version = "0.7.5" features = ["ctr"] @@ -71,7 +67,7 @@ optional = true
[dependencies.erased-serde] -version = "0.4.5" +version = "0.4.4" optional = true
[dependencies.hex] @@ -83,7 +79,7 @@ optional = true
[dependencies.iso8601] -version = "0.6.1" +version = ">=0.4.2"
[dependencies.p384] version = "0.13.0" @@ -124,9 +120,6 @@ version = "1.4.3" features = ["zeroize_derive"]
-[dev-dependencies.actix-identity] -version = "0.4.0" - [dev-dependencies.actix-utils] version = "3.0.0"
@@ -137,7 +130,7 @@ version = "1.0.45"
[dev-dependencies.erased-serde] -version = "0.4.5" +version = "0.4.4"
[dev-dependencies.primes] version = "0.3.0"
```
---
I've added the EOL patch as a %prep step
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #12 from Cristian Le fedora@lecris.me --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #13 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rusty_paseto
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-522ce3054b (rust-rusty_paseto-0.7.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-522ce3054b
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-07-05 10:17:27
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-522ce3054b (rust-rusty_paseto-0.7.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@gmail.com | |) |
--- Comment #16 from Fabio Valentini decathorpe@gmail.com --- Note: This package has a broken dependency, and should probably not have been approved in this state:
Problem 1: conflicting requests - nothing provides (crate(chacha20poly1305/default) >= 0.10.1 with crate(chacha20poly1305/default) < 0.11.0~) needed by rust-rusty_paseto+chacha20poly1305-devel-0.7.1-1.fc41.noarch from @commandline Problem 2: package rust-rusty_paseto+v2_local-devel-0.7.1-1.fc41.noarch from @commandline requires crate(rusty_paseto/chacha20poly1305) = 0.7.1, but none of the providers can be installed - conflicting requests - nothing provides (crate(chacha20poly1305/default) >= 0.10.1 with crate(chacha20poly1305/default) < 0.11.0~) needed by rust-rusty_paseto+chacha20poly1305-devel-0.7.1-1.fc41.noarch from @commandline
The chacha20poly1305 crate is not yet packaged for Fedora, so the "v2_local" feature of rusty_paseto cannot be currently installed or used.
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #17 from Cristian Le fedora@lecris.me --- Oh, these did not get picked up a build time? Probably those would be seen in the Fedora review service. Good news is that it was picked up by `installability` (would be nice to have some of those tests run here). I only need `v3` and `v4`, so how would you recommend to patch this, is `features.hide` enough, or should also delete that dependency/feature?
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #18 from Fabio Valentini decathorpe@gmail.com ---
Oh, these did not get picked up a build time?
No, v2_local seems to be an off-by-default feature.
Probably those would be seen in the Fedora review service.
They should have been. But the service seems to sometimes have trouble with installability checks ...
I only need `v3` and `v4`, so how would you recommend to patch this, is `features.hide` enough, or should also delete that dependency/feature?
I think in this case a setting like this should do it:
``` [features] hide = ["v2_local", "chacha20poly1305"] ```
https://bugzilla.redhat.com/show_bug.cgi?id=2283850
--- Comment #19 from Cristian Le fedora@lecris.me --- Updated at: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c7dcff66c7
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com