[Bug 539268] New: Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Summary: Review Request: rubygem-will_paginate - Most awesome
                    pagination solution for Rail
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-will_paginate.spec
SRPM URL:
http://mcpierce.fedorapeople.org/rpms/rubygem-will_paginate-2.3.11-1.fc12.sr...
Description: The will_paginate library provides a simple, yet powerful and
extensible API for ActiveRecord pagination and rendering of pagination links in
ActionView templates.

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Mamoru Tasaka   2009-11-21 15:03:27 EDT ---
Some quick notes:

* %define -> %global
  - Now Fedora prefers to use %global than %define:

https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over...

* License
  - is MIT

* Source
  - Please use http://gems.rubyforge.org/gems/%%7Bgemname%7D-%%7Bversion%7D.gem

* Requires/BuildRequires
  - "Requires: ruby(abi) = 1.8" is a must:
    https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines
    Also I usually suggest to add "BuildRequires: ruby(abi) = 1.8"
    for consistency.

- Please check the needed Requires manually.
    For example (only an example), lib/will_paginate.rb contains:
-------------------------------------------------------------
     1  require 'active_support'
-------------------------------------------------------------
    This means this binary rpm should have at least
    "Requires: rubygem(activesupport)".
    ! Note: use "rubygem(activesupport)" virtual Provides style for
      Requires instead of using rpm names directly, ref:
      https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

* Using macros
  - As %geminstdir is defined, please replace
%{gemdir}/gems/%{gemname}-%{version}/
    (in %files) with this.
  - %ruby_sitelib seems to be used nowhere (in this spec file).

* Duplicate files
  - Please fix below:
-------------------------------------------------------------
    57  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/CHANGELOG.rdoc
    58  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/LICENSE
    59  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/README.rdoc
-------------------------------------------------------------
    https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files
    - Note: please keep these files marked as %doc.

* Test program
  - As this rpm contains %geminstdir/test/ please add %check section and
    execute some test program (some extra BuildRequires are also needed).

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #2 from Mamoru Tasaka   2009-12-02 09:39:14 EDT ---
ping?

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Darryl L. Pierce  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?([e-mail] |
                   |m)                          |

--- Comment #3 from Darryl L. Pierce   2009-12-02 11:51:16 EDT ---
Sorry, have been getting SIGLIFE'd since your post. I'll have an update in the
next week or so.

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

--- Comment #4 from Darryl L. Pierce   2009-12-08 10:51:26 EDT ---
(In reply to comment #1)
> Some quick notes:
> %define -> %global
> Now Fedora prefers to use %global than %define:

Done.
> License
> is MIT

Done.
> Source
> Please use http://gems.rubyforge.org/gems/%%7Bgemname%7D-%%7Bversion%7D.gem

Done.
> Requires/BuildRequires
>
> "Requires: ruby(abi) = 1.8" is a must:
> https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines
> Also I usually suggest to add "BuildRequires: ruby(abi) = 1.8"
> for consistency.
>
> Please check the needed Requires manually.
> For example (only an example), lib/will_paginate.rb contains:
>  1  require 'active_support'
> This means this binary rpm should have at least
> "Requires: rubygem(activesupport)".
> ! Note: use "rubygem(activesupport)" virtual Provides style for
>   Requires instead of using rpm names directly, ref:
>   https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

Done. Added a few BuildRequires and Requires for running tests.
> Using macros
> As %geminstdir is defined, please replace
>
> %{gemdir}/gems/%{gemname}-%{version}/
>     (in %files) with this.

Done.
> %ruby_sitelib seems to be used nowhere (in this spec file).

Removed.
> Duplicate files
> Please fix below:
> 57  warning: File listed twice:
>
> /usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/CHANGELOG.rdoc
>     58  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/LICENSE
>     59  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/will_paginate-2.3.11/README.rdoc
> https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files
> - Note: please keep these files marked as %doc.

Fixed.
> Test program
> As this rpm contains %geminstdir/test/ please add %check section and
> execute some test program (some extra BuildRequires are also needed).

Done.

Updated spec: http://mcpierce.fedorapeople.org/rpms/rubygem-will_paginate.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-will_paginate-2.3.11-2.fc12.sr...

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #5 from Mamoru Tasaka   2009-12-24 09:51:42 EDT ---
Well, it seems I completely forgot this review request...

For -2:
* BuildRequires
  - Please add some missing BuildRequires
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1890393

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Michal Fojtik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail] |[e-mail]

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #8 from Mamoru Tasaka  2010-05-18 05:32:39 EDT ---
Michal, why did you change the assignee of this bug?
(also this bug is already closed).

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Michal Fojtik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Reopened
             Status|CLOSED                      |ASSIGNED
         Resolution|NOTABUG                     |
               Flag|needinfo?([e-mail] |
                   |m)                          |

--- Comment #9 from Michal Fojtik  2010-05-18 06:03:40 EDT ---
Updated spec: http://mifo.sk/RPMS/rubygem-will_paginate.spec
Updated SRPM: http://mifo.sk/RPMS/rubygem-will_paginate-2.3.12-1.fc13.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=219667

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

--- Comment #10 from Michal Fojtik  2010-05-18 06:04:58 EDT ---
(In reply to comment #8)
> Michal, why did you change the assignee of this bug?
> (also this bug is already closed).

I wanted to fix issue with BuildRequires and take cate of this package. I could
reopen this request as a new bug.

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

--- Comment #11 from Michal Fojtik  2010-05-18 06:14:00 EDT ---
I'm sorry, proper Koji URL was:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2193667

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

--- Comment #12 from Mamoru Tasaka  2010-05-18 07:00:53 EDT ---
If you want to import this package into Fedora, please
file a new review request and mark this bug as a duplicate
of the new one (the submitter cannot be the reviewer anyway).

[Bug 539268] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rail

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=539268

Michal Fojtik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |DUPLICATE

--- Comment #13 from Michal Fojtik  2010-05-18 08:06:25 EDT ---

*** This bug has been marked as a duplicate of bug 593274 ***