[Bug 194051] New: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion
                    utilities
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://math.ifi.unizh.ch/fedora/spec/abcmidi.spec
SRPM URL: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/abcMIDI-20060422-1.src.rpm
Description:
The abcMIDI package contains four programs: abc2midi to convert ABC
music notation to MIDI, midi2abc to convert MIDI files to (a first
approximation to) the corresponding ABC, abc2abc to reformat and/or
transpose ABC files, and yaps to typeset ABC files as PostScript.

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-09 06:01 EST -------
URL for the spec file is wrong, I'm getting error 404

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-09 06:07 EST -------
small notes
  - when compiling store.c there is a warning from gcc about an overflow buffer
in sprintf
  - install the binaries with "install --strip -m ..."

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-09 06:07 EST -------
(In reply to comment #1)
> URL for the spec file is wrong, I'm getting error 404

it should be http://math.ifi.unizh.ch/fedora/spec/abcMIDI.spec ;-)

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-09 15:08 EST -------
(In reply to comment #2)
> small notes
> when compiling store.c there is a warning from gcc about an overflow buffer
>
> in sprintf

I will make a patch.
> install the binaries with "install --strip -m ..."

This is not necessary, stripping is handled by rpmbuild.

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-09 16:30 EST -------
> > install the binaries with "install --strip -m ..."
>
> This is not necessary, stripping is handled by rpmbuild.

Yes, you are right. It was "a problem" on my system with disabled building of
debug packages. In such case the stripping doesn't work.

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-09 17:50 EST -------
The formal side looks well, but when trying to run
abc2midi /usr/share/doc/abcMIDI-20060422/demo.abc -c -v

the result is:
Reference X: 1
scanning tune
handling grace notes
fixing repeats
track 0, voice 0
Floating point exception

It could have probably something to do with the buffer overflow.

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-09 18:33 EST -------
(In reply to comment #6)
> The formal side looks well, but when trying to run
> abc2midi /usr/share/doc/abcMIDI-20060422/demo.abc -c -v
>
> the result is:
> Reference X: 1
> scanning tune
> handling grace notes
> fixing repeats
> track 0, voice 0
> Floating point exception
>
> It could have probably something to do with the buffer overflow.

This seems to be a division by zero, triggered by code that is run
only when the -c option is given.

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-10 04:45 EST -------
to the buffer overflow - in file store.c on line 1225 is a buffer char *msg[40],
but the string on line 1230 is 42 chars long :-)

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-10 04:52 EST -------
Created an attachment (id=130909)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130909&action=vie...)
simple patch for buffer overflow in store.c

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

------- Additional Comments From [e-mail]  2006-06-10 04:56 EST -------
the review is here

MUST
====
- no rpmlint output
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- license GPL and is included
- source matches upstream
- compiles and builds at least on i386
- no BuildRequires needed
- no localized files
- no shared libs
- no created directories and so no conflict with existing dirs
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- no need for devel subpackage
- not a GUI application

with the fix for the buffer overflow is this package APPROVED

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-06-11 12:44 EST -------
Built on FC4, FC5 and FC6. Added entry to owners.list file.
Thanks for the review!

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-06-14 08:28 EST -------
All comments are lost, so I am adding at least the final result = APPROVED

Gerard, please close the bug again.

MUST
====
- no rpmlint output
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- license OK and is included
- source matches upstream
- compiles and builds at least on i386
- no BuildRequires needed
- no localized files
- no shared libs
- no created directories and so no conflict with existing dirs
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- no need for devel subpackage
- not a GUI application

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities

https://bugzilla.redhat.com/show_bug.cgi?id=194051

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide