https://bugzilla.redhat.com/show_bug.cgi?id=1903686
Bug ID: 1903686 Summary: Review Request: xmlezout - set of packages intended to aid the creation of XML-formatted output from within Ada programs Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pzhukov@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/landgraf/alire-review/fed... SRPM URL: https://download.copr.fedorainfracloud.org/results/landgraf/alire-review/fed... Description: XML EZ_Out is a small set of packages intended to aid the creation of XML-formatted output from within Ada programs Fedora Account System Username: landgraf
https://bugzilla.redhat.com/show_bug.cgi?id=1903686
--- Comment #1 from Pavel Zhukov pzhukov@redhat.com --- failed to build in rawhide. Waiting for https://src.fedoraproject.org/rpms/fedora-gnat-project-common/pull-request/1
https://bugzilla.redhat.com/show_bug.cgi?id=1903686
Andy Mender andymenderunix@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |andymenderunix@gmail.com Assignee|nobody@fedoraproject.org |andymenderunix@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1903686
--- Comment #2 from Andy Mender andymenderunix@gmail.com ---
Release: 2.%{git_suffix}%{?dist} License: GPLv2+ Group: Development/Libraries
- The Group field is obsolete.
- Not sure about the license. The project doesn't have a license file (the patch you submitted adds it, in fact) and the text I see in some files would fit "GPL+ with exceptions" or "GPLv2 with exceptions" more, I think: https://github.com/alire-project/xmlezout/blob/master/mckae-xml-ez_out-gener...
URL: https://github.com/alire-project/xmlezout Source0: https://github.com/alire-project/%%7Bname%7D/archive/%%7Bgit_commit%7D/%%7Bn...
- You can use the URL in the Source0 field with the %{url} macro.
- The downloaded archive is actually "%{name}-%{git_commit}.tar.gz" so an alias might be needed. Or I'm doing something wrong :(.
BuildRequires: gprbuild gcc-gnat
Could you split these into separate lines?
%files %defattr(-,root,root,-)
Setting permissions in %files is no longer needed.
I'll wait with a full review until the PR you submitted is in.
https://bugzilla.redhat.com/show_bug.cgi?id=1903686
--- Comment #3 from Andy Mender andymenderunix@gmail.com ---
I'll wait with a full review until the PR you submitted is in.
Done.
However, the package fails to build on Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=58463435
https://bugzilla.redhat.com/show_bug.cgi?id=1903686
--- Comment #4 from Pavel Zhukov pzhukov@redhat.com --- (In reply to Andy Mender from comment #3)
I'll wait with a full review until the PR you submitted is in.
Done.
However, the package fails to build on Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=58463435
Macros name has been changed as the result of the review. I'll push updated version with license fixes soon.
https://bugzilla.redhat.com/show_bug.cgi?id=1903686
Andy Mender andymenderunix@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(pzhukov@redhat.co | |m)
--- Comment #5 from Andy Mender andymenderunix@gmail.com --- Hello Pavel, any updates on this? :)
https://bugzilla.redhat.com/show_bug.cgi?id=1903686
--- Comment #6 from Pavel Zhukov pzhukov@redhat.com --- (In reply to Andy Mender from comment #5)
Hello Pavel, any updates on this? :)
Hello Andy,
Sorry for the delay. It went out of my radar. Will push updated versions by the EOW. Keeping needinfo as a reminder.
package-review@lists.fedoraproject.org