[Bug 431188] New: Review Request: minbar - Athan call and prayer times notification software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=431188
Summary: Review Request: minbar - Athan call and prayer times notification software Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mohd.izhar.firdaus@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://izhar.fedorapeople.org/itl/minbar.spec SRPM URL: http://izhar.fedorapeople.org/itl/minbar-0.2.1-2.fc8.src.rpm Description:
Minbar is a GNOME GUI with tray icon, for athan call and notifications for Islam prayer times.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
mohd.izhar.firdaus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |431181
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
Bug 431188 depends on bug 431181, which changed state.
Bug 431181 Summary: Review Request: libitl - Libraries for The Islamic Tools and Libraries Project https://bugzilla.redhat.com/show_bug.cgi?id=431181
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |NEEDINFO Status|NEEDINFO |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-16 20:37 EST ------- Rebuild failed.
http://koji.fedoraproject.org/koji/taskinfo?taskID=432105
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2008-02-16 22:41 EST ------- Spec URL: http://izhar.fedorapeople.org/itl/minbar.spec SRPM URL: http://izhar.fedorapeople.org/itl/minbar-0.2.1-3.fc9.src.rpm
fixed.
- added missing BR perl(XML::Parser), desktop-file-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-17 09:08 EST ------- For 0.2.1-3:
* Scriptlets - Scriptlets for GConf are not right. (also scriptlets for %pre is needed). Please check the subsection "GConf" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets - Also the scriptlets for GTK icon cache are not right. Please check the same wiki page.
* Timestamp - To keep timestamps on installed files, I recommend to use --------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" --------------------------------------------------------------- This method usually works for recent autotool-based Makefiles.
* Desktop file - Why is the category 'Utility' listed twice?
* Documents - Usually the file "INSTALL" is for people who want to build and install softwares by themselves and is not needed for people using rpm system. - Files under %_mandir are automatically marked as %doc.
* macros - Please use macros correctly. For example /usr/bin must be %{_bindir}.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2008-02-23 23:56 EST ------- Updated
http://izhar.fedorapeople.org/itl/minbar.spec http://izhar.fedorapeople.org/itl/minbar-0.2.1-4.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-02-24 09:44 EST ------- For 0.2.1-4:
* sed usage ------------------------------------------------------- cat %{name}.desktop.in |sed "s|Utility;Utility;|Utility;|" > %{name}.desktop.tmp mv %{name}.desktop.tmp %{name}.desktop.in ------------------------------------------------------- - You can use -i (in place) option. ------------------------------------------------------- sed -i -e "s|(Utility;)\1|\1|" %{name}.desktop.in -------------------------------------------------------
* macros - As I said in the previous comments, please replace all /usr/bin with %{_bindir}. ------------------------------------------------------- if [ -x /usr/bin/gtk-update-icon-cache ]; then /usr/bin/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor fi -------------------------------------------------------
* scriptlet - As I said in the previous comments the scriptlets for GTK+ icon cache are not yet right. Please refer to the section "GTK+ icon cache" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets again.
* Documents - Files under %_mandir are automatically marked as %doc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2008-03-02 06:49 EST ------- Thanks,
I have updated the package
- fixed gtk-update-icon-cache scriplet - changed sed to use -i - removed %doc from man files
http://izhar.fedorapeople.org/itl/minbar.spec http://izhar.fedorapeople.org/itl/minbar-0.2.1-4.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2008-03-02 06:51 EST ------- oops
SRPM: http://izhar.fedorapeople.org/itl/minbar-0.2.1-5.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-02 11:27 EST ------- For 0.2.1-5:
* GConf scriptlet - I didn't notice before, but "Requires(pre): GConf" is missing.
* sed usage ------------------------------------------------------------ sed -i "s|(Utility;)\1|\1|" %{name}.desktop.in ------------------------------------------------------------ - The correct one is: ------------------------------------------------------------ sed -i "s|(Utility;)\1|\1|" %{name}.desktop.in ------------------------------------------------------------
Other things are okay. -------------------------------------------------------------------------- This package (minbar) is APPROVED by me. --------------------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
mohd.izhar.firdaus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2008-03-02 11:45 EST ------- Thanks tasaka-san
New Package CVS Request ======================= Package Name: minbar Short Description: Athan call and prayer times notification software Owners: izhar Branches: F-7 F-8 InitialCC: izhar Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-02 12:09 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: minbar - Athan call and prayer times notification software
https://bugzilla.redhat.com/show_bug.cgi?id=431188
mohd.izhar.firdaus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2008-03-02 12:16 EST ------- thanks all
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla