Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
Summary: Review Request: sugar-terminal -- Terminal activity for sugar Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: katzj@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://katzj.fedorapeople.org/review/sugar-terminal/sugar-terminal.spec SRPM URL: http://katzj.fedorapeople.org/review/sugar-terminal/sugar-terminal-13-1.fc10... Description: Terminal activity for sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
Robin Norwood rnorwood@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rnorwood@redhat.com Customer Facing| |--- AssignedTo|nobody@fedoraproject.org |rnorwood@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
--- Comment #1 from Robin Norwood rnorwood@redhat.com 2008-08-08 12:30:14 EDT --- - rpmlint is very noisy: sugar-terminal.src: W: non-standard-group Sugar/Activities
* Sugar/Activities should probably be added to the standard groups list. * Filed https://bugzilla.redhat.com/show_bug.cgi?id=458460 to get this done.
sugar-terminal.noarch: E: non-executable-script /usr/share/sugar/activities/Terminal.activity/setup.py 0644
* Probably just patch out the shebang line or make it non-executable since this shouldn't be needed at runtime.
sugar-terminal.noarch: W: file-not-in-%lang /usr/share/sugar/activities/Terminal.activity/locale/af/LC_MESSAGES/org.laptop.Terminal.mo (...lots more...)
* Ongoing discussion as to what to do about this on fedora-olpc-list. No point in blocking the review, we'll just fix it when the proper course of action is decided.
- Package naming is fine - License is fine - Source matches upstream (git checkout of a tag) - Spec file is fine - File list is fine (except for translations)
APPROVED (Once you fix the rpmlint error)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
--- Comment #2 from Jeremy Katz katzj@redhat.com 2008-08-11 14:30:10 EDT --- The setup.py thing needs to be fixed in the sugar BundleBuilder so that we avoid proliferating noise into every spec file. Started a discussion about that also. Since if we're going to be packaging a number of activities, we should be doing it in a way that doesn't involve a lot of cut and paste boiler-plate "work around the system" types of things.
Will hold off on cvs request (and filing the other review tickets I've got) until we get a little bit of somewhere on the two issues
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
--- Comment #3 from Jeremy Katz katzj@redhat.com 2008-09-02 13:05:54 EDT --- Okay, with the fixes in sugar-toolkit-0.82.5-2, things work nicely now
New Package CVS Request ======================= Package Name: sugar-terminal Short Description: Terminal activity for sugar Owners: katzj Branches: devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
--- Comment #4 from Robin Norwood robin.norwood@gmail.com 2008-09-02 13:31:55 EDT --- btw, I don't mind to be listed as co-maintainer (rnorwood) for any of these activity packages if you like.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2008-09-03 16:24:02 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
Jeremy Katz katzj@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |RAWHIDE
--- Comment #6 from Jeremy Katz katzj@redhat.com 2008-09-03 16:41:46 EDT --- And building
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pbrobinson@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #7 from Peter Robinson pbrobinson@gmail.com 2010-06-10 16:50:45 EDT --- Package Change Request ====================== Package Name: sugar-terminal New Branches: EL-6 Owners: pbrobinson sdz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2010-06-11 00:34:44 EDT --- Have you checked with tuxbrewr to see if he would like to maintain this in EPEL?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457247
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
package-review@lists.fedoraproject.org