[Bug 203205] New: Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205

           Summary: Review Request: eclipse-phpeclipse
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: bkonrath(a)redhat.com
         QAContact: fedora-package-review(a)redhat.com


Spec URL:

http://people.redhat.com/bkonrath/eclipse/eclipse-phpeclipse.spec

SRPM URL:

http://people.redhat.com/bkonrath/eclipse/eclipse-phpeclipse-1.1.8-7.src.rpm

Description:

The PHPeclipse plugin allows developers to write PHP webpages and scripts in Eclipse.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205


green(a)redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |green(a)redhat.com




------- Additional Comments From green(a)redhat.com  2006-08-27 02:20 EST -------
Is this supposed to build on FC5?

I get...

BUILD FAILED
Buildfile: /usr/share/eclipse/plugins/org.eclipse.pde.build/scripts/build.xml
does not exist

because this file lives at:
/usr/share/eclipse/plugins/org.eclipse.pde.build_3.1.2/scripts/build.xml




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205





------- Additional Comments From bkonrath(a)redhat.com  2006-08-27 15:38 EST -------
(In reply to comment #1)
>  Is this supposed to build on FC5? 
No, I don't think the source will even compile against 3.1.2. Sorry I should
have been clear about that. 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205


green(a)redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody(a)fedoraproject.org    |green(a)redhat.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205





------- Additional Comments From green(a)redhat.com  2006-09-09 00:27 EST -------
Let's look at the rpmlint output:

E: eclipse-phpeclipse description-line-too-long The PHPeclipse plugin allows
developers to write PHP webpages and scripts in Eclipse.

I've never seen this before.  Should be easy to fix.

W: eclipse-phpeclipse non-standard-group Text Editors/Integrated Development
Environments (IDE)

Please use Development/Tools.

W: eclipse-phpeclipse incoherent-version-in-changelog 1.1.8-6 1.1.8-7

This must be a typo.

W: eclipse-phpeclipse invalid-license Common Public License (CPL) 1.0

Please just use "CPL".

W: eclipse-phpeclipse no-documentation

At a minimum, please add the license text as a %doc in the %files section.

W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.classpath
W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.phphelp_1.1.8/.classpath
W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.project
W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.template
W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.core_1.1.8/.classpath
W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.debug.ui_1.1.8/.template
W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.project
W: eclipse-phpeclipse hidden-file-or-dir
/usr/share/eclipse/plugins/net.sourceforge.phpeclipse.launching_1.1.8/.template

I've never seen these before.  Can we delete them, or are they important?

W: eclipse-phpeclipse one-line-command-in-%post /usr/bin/rebuild-gcj-db
W: eclipse-phpeclipse one-line-command-in-%postun /usr/bin/rebuild-gcj-db

Use single lines like this instead:
%post -p %{_bindir}/rebuild-gcj-db


The rest are from the SRPM....

E: eclipse-phpeclipse description-line-too-long The PHPeclipse plugin allows
developers to write PHP webpages and scripts in Eclipse.
W: eclipse-phpeclipse non-standard-group Text Editors/Integrated Development
Environments (IDE)
W: eclipse-phpeclipse invalid-license Common Public License (CPL) 1.0

All as above.

W: eclipse-phpeclipse mixed-use-of-spaces-and-tabs

I just use the emacs untabify command for this.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205


fedora(a)theholbrooks.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora(a)theholbrooks.org




------- Additional Comments From fedora(a)theholbrooks.org  2006-10-24 17:28 EST -------
I'd really like to see this review finished and phpeclipse imported and built. 
Ben, do you intend on addressing these rpmlint suggestions?  If not, do you mind
if I 'adopt' eclipse-phpeclipse and finish this stalled review?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205





------- Additional Comments From bkonrath(a)redhat.com  2006-10-31 09:42 EST -------
(In reply to comment #4)
>  Ben, do you intend on addressing these rpmlint suggestions?  If not,
> do you mind
>  if I 'adopt' eclipse-phpeclipse and finish this stalled review? 
I don't have the time right now to finish this review so feel free to take it
over. It  was not easy to get this packaged up so feel free to ping me if you
have any questions about this package or if you have problems updating this
package to newer versions of phpeclipse when they are released. Thanks.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205


fedora(a)theholbrooks.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |DUPLICATE




------- Additional Comments From fedora(a)theholbrooks.org  2006-11-02 01:18 EST -------


*** This bug has been marked as a duplicate of 213594 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

[Bug 203205] Review Request: eclipse-phpeclipse

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-phpeclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203205


fedora(a)christoph-wickert.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |201449
              nThis|                            |




------- Additional Comments From fedora(a)christoph-wickert.de  2006-12-01 21:20 EST
-------
Marking as bug #201449

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.