[Bug 1431763] New: Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Bug ID: 1431763 Summary: Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-g...
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-g...
Description: GeoIP2 lookup library for Go
Fedora Account System Username: decathorpe
This package is one of the (indirect) dependencies of syncthing. I can't provide a koji scratch build yet, since it depends on golang-github-oschwald-maxminddb-golang.
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1431759
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1431759 [Bug 1431759] Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1427634
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1427634 [Bug 1427634] Review Request: syncthing - Continuous File Synchronization
https://bugzilla.redhat.com/show_bug.cgi?id=1431763 Bug 1431763 depends on bug 1431759, which changed state.
Bug 1431759 Summary: Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go https://bugzilla.redhat.com/show_bug.cgi?id=1431759
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1431763 Bug 1431763 depends on bug 1431759, which changed state.
Bug 1431759 Summary: Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go https://bugzilla.redhat.com/show_bug.cgi?id=1431759
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |---
https://bugzilla.redhat.com/show_bug.cgi?id=1431763 Bug 1431763 depends on bug 1431759, which changed state.
Bug 1431759 Summary: Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go https://bugzilla.redhat.com/show_bug.cgi?id=1431759
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- koji scratch build, as all dependencies are available on rawhide now: https://koji.fedoraproject.org/koji/taskinfo?taskID=18679011
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |athoscribeiro@gmail.com Assignee|nobody@fedoraproject.org |athoscribeiro@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #2 from Athos Ribeiro athoscribeiro@gmail.com --- Hi Fabio,
I am taking this one.
- Conditional clauses on line 144 are duplicated.
- The guidelines for post releases have changed [1], in special, the release tag for post release should not be in X.Y format (use just the X) and the date the snapshot was taken must be included there.
- The test data could be included as a separate source file, but that's not a blocker here.
[1] https://fedoraproject.org/wiki/Packaging:Versioning
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-g...
SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-g...
- Redundant conditional removed - Release: tag fixed - updated to newer snapshot
For now I would rather not include another git repository snapshot tarball for the test data. Maybe I'll add it in the future, if there is demand for enabling the tests.
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Athos Ribeiro athoscribeiro@gmail.com --- Package looks good now!
Approved
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-oschwald-ge...
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-43dcb207fa
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-55388bed37
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6261d56f95
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-55388bed37
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6261d56f95
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-43dcb207fa
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd3997794d
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4a6754314
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-dd3997794d
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4a6754314
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-05-02 19:14:58
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1431763
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- golang-github-oschwald-geoip2-golang-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com