https://bugzilla.redhat.com/show_bug.cgi?id=1376438
Bug ID: 1376438 Summary: Review Request: dvblast - Simple and powerful streaming application Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: kwizart@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://dl.kwizart.net/review/dvblast.spec SRPM URL: http://dl.kwizart.net/review/dvblast-3.0-1.fc26.src.rpm Description: Simple and powerful streaming application Fedora Account System Username: kwizart
https://bugzilla.redhat.com/show_bug.cgi?id=1376438
Nicolas Chauvet (kwizart) kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1376436
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1376436 [Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG, DVB, IETF
https://bugzilla.redhat.com/show_bug.cgi?id=1376438 Bug 1376438 depends on bug 1376436, which changed state.
Bug 1376436 Summary: Review Request: bitstream - Simpler access to binary structures such as specified by MPEG, DVB, IETF https://bugzilla.redhat.com/show_bug.cgi?id=1376436
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1376438
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |anto.trande@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1376438
--- Comment #1 from Antonio Trande anto.trande@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues
- dvblast, dvblastctl exe files are "Partial Relro" "No PIE". http://fedoraproject.org/wiki/Packaging:Guidelines#PIE Probably ld flags are not properly set.
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "WTFPL WTFPL (v2)", "GPL (v2 or later)", "Unknown or generated". 9 files have unknown license. Detailed output of licensecheck in /home/sagitter/1376438-dvblast/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dvblast- debuginfo [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: dvblast-3.0-1.fc26.x86_64.rpm dvblast-debuginfo-3.0-1.fc26.x86_64.rpm dvblast-3.0-1.fc26.src.rpm dvblast.x86_64: W: spelling-error %description -l en_US linux -> Linux dvblast.x86_64: W: spelling-error %description -l en_US dvb -> db, vb, deb dvblast.x86_64: W: spelling-error %description -l en_US demultiplexes -> multiplexes, multiplexer, multiplex dvblast.x86_64: W: no-manual-page-for-binary dvblast_mmi.sh dvblast.x86_64: W: no-manual-page-for-binary dvblastctl dvblast.src: W: spelling-error %description -l en_US linux -> Linux dvblast.src: W: spelling-error %description -l en_US dvb -> db, vb, deb dvblast.src: W: spelling-error %description -l en_US demultiplexes -> multiplexes, multiplexer, multiplex 3 packages and 0 specfiles checked; 0 errors, 8 warnings.
Rpmlint (debuginfo) ------------------- Checking: dvblast-debuginfo-3.0-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- dvblast.x86_64: W: spelling-error %description -l en_US linux -> Linux dvblast.x86_64: W: spelling-error %description -l en_US dvb -> db, vb, deb dvblast.x86_64: W: spelling-error %description -l en_US demultiplexes -> multiplexes, multiplexer, multiplex dvblast.x86_64: W: no-manual-page-for-binary dvblastctl dvblast.x86_64: W: no-manual-page-for-binary dvblast_mmi.sh 2 packages and 0 specfiles checked; 0 errors, 5 warnings.
Requires -------- dvblast (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libev.so.4()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) rtld(GNU_HASH)
dvblast-debuginfo (rpmlib, GLIBC filtered):
Provides -------- dvblast: dvblast dvblast(x86-64)
dvblast-debuginfo: dvblast-debuginfo dvblast-debuginfo(x86-64)
Source checksums ---------------- http://downloads.videolan.org/pub/videolan/dvblast/3.0/dvblast-3.0.tar.bz2 : CHECKSUM(SHA256) this package : 4fc3eb2a3d3545cb76a5c515a16671d1c34fe2f5dad57b71e89bd54c14c3045e CHECKSUM(SHA256) upstream package : 4fc3eb2a3d3545cb76a5c515a16671d1c34fe2f5dad57b71e89bd54c14c3045e
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1376438 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1376438
--- Comment #2 from Nicolas Chauvet (kwizart) kwizart@gmail.com --- Thx for the review:
Spec URL: http://dl.kwizart.net/review/dvblast.spec SRPM URL: http://dl.kwizart.net/review/dvblast-3.0-2.fc26.src.rpm Description: Simple and powerful streaming application
Updated Changelog: * Tue Oct 04 2016 Nicolas Chauvet kwizart@gmail.com - 3.0-2 - Backport fix for LDFLAGS from upstream
Koji scratch build for f26: http://koji.fedoraproject.org/koji/taskinfo?taskID=15938373
https://bugzilla.redhat.com/show_bug.cgi?id=1376438
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Antonio Trande anto.trande@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1376438
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dvblast
https://bugzilla.redhat.com/show_bug.cgi?id=1376438
Nicolas Chauvet (kwizart) kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-10-04 15:27:02
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla