[Bug 2290575] New: Review Request: rust-serde_default - Generate a Default impl using serde attributes
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
Bug ID: 2290575 Summary: Review Request: rust-serde_default - Generate a Default impl using serde attributes Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: lukasz.wojnilowicz@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://wojnilowicz.fedorapeople.org/rust-serde_default.spec SRPM URL: https://wojnilowicz.fedorapeople.org/rust-serde_default-0.1.0-1.fc39.src.rpm
Description: Generate a Default impl using serde attributes.
Fedora Account System Username: wojnilowicz
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/se | |rde_default Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7532832 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- This package has pretty outdated dependencies. Could you try to work with upstream to port this crate to syn v2 and darling v0.20?
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde_default
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-85cf041ba8 (rust-serde_default-0.1.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-85cf041ba8
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-07-07 08:35:28
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-85cf041ba8 (rust-serde_default-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
--- Comment #6 from wojnilowicz lukasz.wojnilowicz@gmail.com --- Thank you for the review!
Regarding
(In reply to Fabio Valentini from comment #2)
This package has pretty outdated dependencies. Could you try to work with upstream to port this crate to syn v2 and darling v0.20?
I could try to look into this. I'm not a rust developer though, so I guess I'll at least notify them.
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
--- Comment #7 from wojnilowicz lukasz.wojnilowicz@gmail.com --- Upstream ported the crated themselves to newer versions as can be seen at https://github.com/TedDriggs/serde_default/blob/master/Cargo.toml#L14 It seems that they haven't tagged a new version yet.
https://bugzilla.redhat.com/show_bug.cgi?id=2290575
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- (In reply to wojnilowicz from comment #7)
Upstream ported the crated themselves to newer versions as can be seen at https://github.com/TedDriggs/serde_default/blob/master/Cargo.toml#L14 It seems that they haven't tagged a new version yet.
Ah, great! So at least this problem will go away in the future as soon as there's a new release that we can package. Thanks for checking!
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com