[Bug 906765] New: Review Request: mingw-libwebp - MinGW compilation of Library and tools for the WebP format
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Bug ID: 906765 Summary: Review Request: mingw-libwebp - MinGW compilation of Library and tools for the WebP format Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: tuxator@o2.pl
Spec URL: https://dl.dropbox.com/u/2448780/mingw-libwebp.spec SRPM URL: https://dl.dropbox.com/u/2448780/mingw-libwebp-0.2.1-1.fc18.src.rpm
Description: WebP is an image format that does lossy compression of digital photographic images. WebP consists of a codec based on VP8, and a container based on RIFF. Webmasters, web developers and browser developers can use WebP to compress, archive and distribute digital images more efficiently.
Fedora Account System Username: pfor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Paweł Forysiuk tuxator@o2.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Paweł Forysiuk tuxator@o2.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalevlember@gmail.com Assignee|nobody@fedoraproject.org |kalevlember@gmail.com
--- Comment #1 from Kalev Lember kalevlember@gmail.com --- Taking for review.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
--- Comment #2 from Kalev Lember kalevlember@gmail.com --- The scratch build failed, can you fix this up so it builds in koji, please? http://koji.fedoraproject.org/koji/taskinfo?taskID=4921458
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
--- Comment #3 from Paweł Forysiuk tuxator@o2.pl --- Sorry for such delay. I had some problems with koji.
Updated specs and srpms below. Spec URL: https://dl.dropbox.com/u/2448780/mingw-libwebp.spec SRPM URL: https://dl.dropbox.com/u/2448780/mingw-libwebp-0.2.1-2.fc18.src.rpm
Scratch build here http://koji.fedoraproject.org/koji/taskinfo?taskID=5169660
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
--- Comment #4 from Kalev Lember kalevlember@gmail.com --- Fedora review of mingw-libwebp-0.2.1-2.fc18.src.rpm 2013-03-25
+ OK ! needs attention
rpmlint output:
$ rpmlint mingw-libwebp-0.2.1-1.fc19.src.rpm \ mingw32-libwebp-0.2.1-1.fc19.noarch.rpm \ mingw64-libwebp-0.2.1-1.fc19.noarch.rpm \ mingw32-libwebp-debuginfo-0.2.1-1.fc19.noarch.rpm \ mingw64-libwebp-debuginfo-0.2.1-1.fc19.noarch.rpm mingw-libwebp.src: W: spelling-error %description -l en_US WebP -> Web P, Web, Webb mingw-libwebp.src: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw-libwebp.src: W: spelling-error %description -l en_US codec -> codex, code, codes mingw-libwebp.src: W: invalid-url Source0: http://webp.googlecode.com/files/libwebp-0.2.1.tar.gz HTTP Error 404: Not Found mingw32-libwebp.noarch: W: spelling-error %description -l en_US WebP -> Web P, Web, Webb mingw32-libwebp.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw32-libwebp.noarch: W: spelling-error %description -l en_US codec -> codex, code, codes mingw64-libwebp.noarch: W: spelling-error %description -l en_US WebP -> Web P, Web, Webb mingw64-libwebp.noarch: W: spelling-error %description -l en_US lossy -> loss, glossy, flossy mingw64-libwebp.noarch: W: spelling-error %description -l en_US codec -> codex, code, codes mingw32-libwebp-debuginfo.noarch: E: debuginfo-without-sources mingw64-libwebp-debuginfo.noarch: E: debuginfo-without-sources 5 packages and 0 specfiles checked; 2 errors, 10 warnings.
+ The rpmlint errors/warnings are harmless and can be ignored + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license is the same as the one for the corresponding native Fedora package ! No license file, even though it's shipped in the tarball (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: dc9b26f16bd5221414dbab95f13d4453 libwebp-0.2.1.tar.gz dc9b26f16bd5221414dbab95f13d4453 Download/libwebp-0.2.1.tar.gz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Not applicable to MinGW packages. n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages must not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8
Add the COPYING file and it should be good to go.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
--- Comment #5 from Paweł Forysiuk tuxator@o2.pl --- Thanks for the input. Files updated according to suggestions.
Spec URL: https://dl.dropbox.com/u/2448780/mingw-libwebp.spec SRPM URL: https://dl.dropbox.com/u/2448780/mingw-libwebp-0.2.1-2.fc18.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #6 from Kalev Lember kalevlember@gmail.com --- Looks good to me.
APPROVED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Paweł Forysiuk tuxator@o2.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Paweł Forysiuk tuxator@o2.pl --- New Package SCM Request ======================= Package Name: mingw-libwebp Short Description: MinGW compilation of Library and tools for the WebP format Owners: pfor Branches: f18 f19
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906765
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |mingw-libwebp-0.2.1-2.fc18 Resolution|--- |NEXTRELEASE Last Closed| |2013-04-01 21:31:51
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla