[Bug 1785968] New: Review Request: python-versioneer - Easy VCS-based management of project version strings

https://bugzilla.redhat.com/show_bug.cgi?id=1785968

Bug ID: 1785968
           Summary: Review Request: python-versioneer - Easy VCS-based
                    management of project version strings
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/vers...
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/vers...

Description:
Versioneer is a tool to automatically update version strings (in setup.py and
the conventional 'from PROJECT import _version' pattern) by asking your
version- control system about the current tree.

Fedora Account System Username: nonamedotc

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=39893102

[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings

https://bugzilla.redhat.com/show_bug.cgi?id=1785968

Mukundan Ragavan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings

https://bugzilla.redhat.com/show_bug.cgi?id=1785968

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
"version- control system" — space after "-" should be removed.

%description is repeated, defining it once as a macro using %{expand:} would 
be nice.

%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/__pycache__/*
is repeated. It would be better to not use a glob, but something like
%{python3_sitelib}/__pycache__/%{pypi_name}.*.py*

%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info – add "/" a the end
if this is a directory.

+ package name is OK
+ license is acceptable for Fedora (public domain)
+ license is specified correctly
  → please use "Public Domain" (capitalized), as in
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List.

+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK

Package is APPROVED.

[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings

https://bugzilla.redhat.com/show_bug.cgi?id=1785968

--- Comment #2 from Mukundan Ragavan  ---
Thanks! I will update make all the changes pointed out during import.

[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings

https://bugzilla.redhat.com/show_bug.cgi?id=1785968

--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-versioneer

[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings

https://bugzilla.redhat.com/show_bug.cgi?id=1785968

Mukundan Ragavan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2019-12-31 20:06:44

--- Comment #4 from Mukundan Ragavan  ---
Built on rawhide.