[Bug 632912] New: Review Request: rubygem-robots - Simple robots.txt parser - package-review

List overview All Threads
Download

newer

[Bug 632912] New: Review Request: rubygem-robots - Simple robots.txt parser

older

[Bug 632919] New: Review Request:...

[Bug 587978] New: Review Request:...

Red Hat Bugzilla

11 Sep 2010 11 Sep '10

8:50 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-robots - Simple robots.txt parser

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Summary: Review Request: rubygem-robots - Simple robots.txt parser Product: Fedora Version: 13 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rebus@seznam.cz QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

SPEC URL: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-1.fc13.src.rpm

Description: A simple Ruby library to parse robots.txt.

Hello, Please could you review the package whatweb?

Output from rpmlint: $ rpmlint rubygem-robots-0.10.0-1.fc13.src.rpm rubygem-robots-0.10.0-1.fc13.noarch.rpm #txt is in the reference to the name of the robots.txt file rubygem-robots.src: W: spelling-error Summary(en_US) txt -> text, ext, tit rubygem-robots.src: W: spelling-error %description -l en_US txt -> text, ext, tit rubygem-robots.noarch: W: spelling-error Summary(en_US) txt -> text, ext, tit rubygem-robots.noarch: W: spelling-error %description -l en_US txt -> text, ext, tit

#% is part urlencoded name of documentation file rubygem-robots.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/robots-0.10.0/ri/Robots/ParsedRobots/allowed%3f-i.yaml %3f rubygem-robots.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/robots-0.10.0/ri/Robots/timeout%3d-c.yaml %3d rubygem-robots.noarch: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/robots-0.10.0/ri/Robots/allowed%3f-i.yaml %3f

#% test scripts are commonly set with only 644 permission rubygem-robots.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/test/test_robots.rb 0644L /usr/bin/env

Koji F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2462027

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

11 Sep 11 Sep

8:52 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |587978

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9:49 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends on| |632917

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12 Sep 12 Sep

10:34 a.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Bug 632912 depends on bug 632917, which changed state.

Bug 632917 Summary: Review Request: rubygem-shoulda - Making ruby tests easy on the fingers and eyes https://bugzilla.redhat.com/show_bug.cgi?id=632917

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:15 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-12 14:15:47 EDT --- Some notes:

* %define -> %global - Now we prefer to use %global instead of %define:

https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over...

* BuildRoot - BuildRoot tag is no longer used on Fedora and EPEL6: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* ruby(abi) Requires - Writing "R: ruby(abi) = 1.8" is a must https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* Requires - R: rubygem(shoulda) is not needed - thoughtbot-shoulda (not shoulda) dependency appeas in installed gemspec, however this is for development dependency and is not needed on runtime.

* Duplicate %files entry ---------------------------------------------------------------- 58 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/CHANGELOG 59 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/README ---------------------------------------------------------------- - Please make it sure that all files are listed only once in %files entry. ! Note The %files entry ---------------------------------------------------------------- %files /some_dir/ ---------------------------------------------------------------- contains the directory /some_dir/ itself and all files/directories/etc under /some_dir/ , while ---------------------------------------------------------------- %files %dir /some_dir/ ---------------------------------------------------------------- contains the directory /some_dir/ only.

* rpmlint issue ---------------------------------------------------------------- rubygem-robots.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/robots-0.10.0/test/test_robots.rb 0644L /usr/bin/env ---------------------------------------------------------------- - This script need not have shebang and the shebang should be removed.

* %check - As this gem contains test/ directory, please add %check section and execute some test program there ! Note To make "$ rake test" succeed, some modification against Rakefile is needed.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:17 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-12 14:17:43 EDT --- One more comment * Macros - Please use the defined %{geminstdir} macro consistently also in %files

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:24 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |632919

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:24 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|587978 |

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Sep 22 Sep

5:19 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(rebus@seznam.cz)

--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-09-22 13:19:23 EDT --- ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

25 Sep 25 Sep

4:30 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends on| |624290

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:35 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends on| |553898

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:49 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(rebus@seznam.cz) |

--- Comment #4 from Michal Ambroz rebus@seznam.cz 2010-09-25 15:49:53 EDT --- Hello Mamoru, thank you for review, here is the updated package: SPEC URL: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-2.fc13.src.rpm

I have tried to implement changes based on your comments. Unfortunately I was not able to implement all the changes you have been asking - mainly:

* BuildRoot - having this tag is not an error - I would like to keep the package maintained for EPEL5 as well and I would prefer to have 1 spec if possible.

* %check - some packages needed for test are not available in Fedora yet (shoulda, jeweler), I have included BuildRequire(check) dependencies and check section, but it is now commented out. I will uncomment as soon as the dependencies are available.

Best regards Michal Ambroz

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3 Oct 3 Oct

7:22 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

--- Comment #5 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-03 15:22:36 EDT --- Sorry for late response. Well,

* %check issue - rubygem(jeweler) is not strictly needed for $ rake test - also rubygem(shoulda) is only for gem.add_development_dependency and not needed for $ rake test - However Rakefile itself is broken for $ rake test. Please consider to apply the following patch and enable $ rake test on %check. ----------------------------------------------------------------- $ diff -u Rakefile.debug Rakefile --- Rakefile.debug 1970-01-01 09:00:00.000000000 +0900 +++ Rakefile 2010-09-13 02:32:52.000000000 +0900 @@ -21,7 +21,7 @@ require 'rake/testtask' Rake::TestTask.new(:test) do |test| test.libs << 'lib' << 'test' - test.pattern = 'test/**/*_test.rb' + test.pattern = 'test/**/test_*.rb' test.verbose = true end

@@ -38,7 +38,7 @@ end end

-task :test => :check_dependencies +#task :test => :check_dependencies

task :default => :test

-----------------------------------------------------------------

* Creating -doc subpackage - For rubygem based rpms, We usually suggest to create -doc subpackages, make -doc subpackage have "Requires: %{name} = %{version}-%{release}" and move the following files / directories to -doc subpackage. ---------------------------------------------------------------- %{gemdir}/doc/%{gemname}-%{version} %{geminstdir}/Rakefile %{geminstdir}/test ----------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12 Oct 12 Oct

2:56 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Bug 632912 depends on bug 624290, which changed state.

Bug 624290 Summary: Build package on F-14/13/12 https://bugzilla.redhat.com/show_bug.cgi?id=624290

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

14 Oct 14 Oct

6:09 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(rebus@seznam.cz)

--- Comment #6 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-14 14:09:27 EDT --- ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Oct 17 Oct

5:32 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Bug 632912 depends on bug 553898, which changed state.

Bug 553898 Summary: Review Request: rubygem-jeweler - Craft the perfect RubyGem https://bugzilla.redhat.com/show_bug.cgi?id=553898

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

29 Oct 29 Oct

5:38 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-10-29 13:38:10 EDT --- ping again?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Nov 5 Nov

5:31 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

--- Comment #8 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-11-05 13:31:44 EDT --- Again ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Nov 15 Nov

4:46 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

--- Comment #9 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-11-15 11:46:26 EST --- ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 Apr 11 Apr

3:16 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:18 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

--- Comment #10 from Michal Ambroz rebus@seznam.cz 2011-04-11 11:18:07 EDT --- Hello Mamoru, I am sorry - I forgot abuot the package. I will incorporate your suggestions.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:42 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

--- Comment #11 from Michal Ambroz rebus@seznam.cz 2011-04-11 19:42:25 EDT --- Updated package:

SPEC: http://rebus.fedorapeople.org/SPECS/rubygem-robots.spec SRPM: http://rebus.fedorapeople.org/SRPMS/rubygem-robots-0.10.0-3.fc14.src.rpm

- added suggested patch - split doc package - enabled %check

Best regards Michal Ambroz

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:42 p.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- Version|13 |rawhide

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Apr 17 Apr

2:13 a.m.

New subject: [Bug 632912] Review Request: rubygem-robots - Simple robots.txt parser

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=632912

Michal Ambroz rebus@seznam.cz changed:

--- Comment #12 from Michal Ambroz rebus@seznam.cz 2012-04-16 22:13:08 EDT --- Resigning in getting the anemone/robots to Fedora.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4552

Age (days ago)

5136

Last active (days ago)

package-review@lists.fedoraproject.org

23 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla