https://bugzilla.redhat.com/show_bug.cgi?id=1085975
Bug ID: 1085975 Summary: Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: paul@city-fan.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Cpanel-JSON-XS/branches/f... SRPM URL: http://www.city-fan.org/~paul/extras/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS...
Description: This module converts Perl data structures to JSON and vice versa. Its primary goal is to be correct and its secondary goal is to be fast. To reach the latter goal it was written in C.
Fedora Account System Username: pghmcfc
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ddick@cpan.org Assignee|nobody@fedoraproject.org |ddick@cpan.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #1 from David Dick ddick@cpan.org --- FIX:
BR perl(Carp) # line 134 of XS.pm BR perl(Hash::Util) # line 13 of t/12_blessed.t
Req perl(Carp) # line 134 of XS.pm Req perl(Data::Dump) # line 212 of bin/cpanel_json_xs Req perl(YAML) # line 180 of bin/cpanel_json_xs Req perl(Compress::LZF) # line 179 of bin/cpanel_json_xs Req perl(Convert::Bencode) # line 178 of bin/cpanel_json_xs
Given that 1) i'm trying to package Compress::LZF at https://bugzilla.redhat.com/show_bug.cgi?id=1074129 2) i'm stalled b/c of missing files in liblzf at https://bugzilla.redhat.com/show_bug.cgi?id=1075911 3) Compress::LZF is an optional argument in a "test" command line client that will handle itself correctly if the "lzf" option is removed i don't mind if you resubmit with a patch to just remove the lzf option. Example patch attached. Or block on #1074129 and wait with me :)
TODO:
Maybe remove ", also for 5.6.2" from the summary? perl 5.6.2 was a while ago.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #2 from David Dick ddick@cpan.org --- Created attachment 884806 --> https://bugzilla.redhat.com/attachment.cgi?id=884806&action=edit Proposed removal of lzf compression option from command line
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #3 from Paul Howarth paul@city-fan.org --- All issues addressed in -2:
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Cpanel-JSON-XS/branches/f... SRPM URL: http://www.city-fan.org/~paul/extras/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS...
When you eventually get Compress::LZF approved, do you plan to do EL-6/7 branches? If not, I would like to take them.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #4 from David Dick ddick@cpan.org --- My plan is to do EL6 and EL7.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #5 from David Dick ddick@cpan.org --- I've checked the git logs for liblzf and Steve Traylen (owner of liblzf) has only added lzfP.h to the package. Therefore, i have to strip out all the _best functionality of Compress::LZF as noted in that bug. I'm doing that at the moment and hope to have the Compress::LZF ready for re-submission soon.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
David Dick ddick@cpan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from David Dick ddick@cpan.org --- At any rate, package APPROVED. I'll let you know when Compress::LZF is ready.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from Paul Howarth paul@city-fan.org --- New Package SCM Request ======================= Package Name: perl-Cpanel-JSON-XS Short Description: JSON::XS for Cpanel, fast and correct serializing Owners: pghmcfc Branches: f19 f20 el6 epel7 InitialCC: perl-sig
Thanks for the review David,
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Cpanel-JSON-XS-2.3404-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.el6
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Cpanel-JSON-XS-2.3404-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Cpanel-JSON-XS-2.3404-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Cpanel-JSON-XS-2.3404-2.fc20 has been pushed to the Fedora 20 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-Cpanel-JSON-XS-2.3404-2.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Cpanel-JSON-XS-2.3404-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Fixed In Version| |perl-Cpanel-JSON-XS-2.3404- | |2.fc21 Resolution|--- |NEXTRELEASE Last Closed| |2014-04-26 16:53:41
https://bugzilla.redhat.com/show_bug.cgi?id=1085975
Emmanuel Seyman emmanuel@seyman.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |emmanuel@seyman.fr
--- Comment #15 from Emmanuel Seyman emmanuel@seyman.fr --- *** Bug 1526170 has been marked as a duplicate of this bug. ***
package-review@lists.fedoraproject.org