[Bug 1366028] New: Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

Bug ID: 1366028
           Summary: Review Request: python-flask-migrate - SQLAlchemy
                    database migrations for Flask applications using
                    Alembic
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://ralph.fedorapeople.org//python-flask-migrate.spec
SRPM URL:
http://ralph.fedorapeople.org//python-flask-migrate-2.0.0-1.fc24.src.rpm

Description:
SQLAlchemy database migrations for Flask applications using Alembic.

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
rpmlint says:
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/env.py
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/script.py.mako
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask/env.py
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/README
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask/script.py.mako
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask/README
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask/README
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/script.py.mako
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/README
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/env.py
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask/script.py.mako
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask/env.py

→ please chmod

python-flask-migrate.src:89: W: macro-in-comment %check
python-flask-migrate.src:90: W: macro-in-comment %{__python2}
python-flask-migrate.src:92: W: macro-in-comment %{__python3}
python-flask-migrate.src:93: W: macro-in-comment %endif

%sum macro is not needed, just use Summary: normally the first time, and then
Summary: %{summary} in the subsequent ones.

You don't need to remove .egg-info, this guideline has been rescinded.

%description could be extended a bit.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ latest version
+ modern python template is used
+ %python_provide is used
+ build/requires/BR look OK
+ no scriptlets necessary
+ fedora-review is happy
+ rpmlint output above, please fix the issues

Package is APPROVED.

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

--- Comment #2 from Ralph Bean  ---
Will do, thanks Zbigniew!

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-flask-migrate

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

--- Comment #4 from Fedora Update System  ---
python-flask-migrate-2.0.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a598bc5db

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

--- Comment #5 from Fedora Update System  ---
python-flask-migrate-2.0.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c16f5b731

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #6 from Fedora Update System  ---
python-flask-migrate-2.0.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c16f5b731

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

--- Comment #7 from Fedora Update System  ---
python-flask-migrate-2.0.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a598bc5db

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

--- Comment #8 from Fedora Update System  ---
python-flask-migrate-2.0.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2016-08-29 11:37:23

[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366028

--- Comment #9 from Fedora Update System  ---
python-flask-migrate-2.0.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.