[Bug 1625201] New: Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

Bug ID: 1625201
           Summary: Review Request: sgmanager - OpenStack Security Groups
                    Management Tool
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/sgmanager.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/sgmanager-2.0.0~git+116.a...
Description:
OpenStack Security Groups Management Tool.
Fedora Account System Username: ignatenkobrain

[Bug 1625201] Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 1625201] Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

--- Comment #2 from Neal Gompa  ---
A couple of issues:
> Version:        2.0.0~git+%{revnum}.%{shortcommit}

This versioning scheme is not permitted currently. Please change to the current
scheme or package a current release.
> BuildRequires:  /usr/bin/flit

I'd prefer if it was "%{_bindir}/flit" instead.

[Bug 1625201] Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

--- Comment #3 from Neal Gompa  ---
> %{?python_enable_dependency_generator}

Please move this to the top of the spec to avoid any potential weirdness.

[Bug 1625201] Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

--- Comment #4 from Igor Gnatenko  ---
New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/sgmanager.spec
New SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/sgmanager-2.0.0-0+2018090...

[Bug 1625201] Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #5 from Neal Gompa  ---
Review notes:

- Package is named appropriately
- Package builds and installs
- Follows Fedora packaging guidelines
- Follows Python packaging guidelines
- Licensing is correct, license file is installed correctly

PACKAGE APPROVED.

[Bug 1625201] Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/sgmanager

[Bug 1625201] Review Request: sgmanager - OpenStack Security Groups Management Tool

https://bugzilla.redhat.com/show_bug.cgi?id=1625201

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2018-09-07 06:14:37