[Bug 266261] New: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=266261

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap
                    font
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts.spec
SRPM URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts-1.1-1.fc8.src.rpm
Description:
This package provides 12x12 Japanese bitmap font for JIS X 0208.
JIS X 0208 is a character set that contains Kanji characters mostly
often used.

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-08-30 01:52 EST -------
This package is split up from fonts-japanese.

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |253149
              nThis|                            |

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-09-06 09:08 EST -------
http://fedoraproject.org/wiki/Packaging/Conflicts - Usage of conflicts need to
be approved, I asked on fedora packaging list about this:
https://www.redhat.com/archives/fedora-packaging/2007-September/msg00010.htm...

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

------- Additional Comments From [e-mail]  2007-09-06 18:04 EST -------
- Conflicts should be ok. (see the previously mentioned thread)

- Building with mock gives an error:
+ install -m 0644 -p 'fonts/*.pcf.gz'
/var/tmp/knm_new-fonts-1.1-1.fc7-root-mockbuild/usr/share/fonts/knm_new-fonts/
install: cannot stat `fonts/*.pcf.gz': No such file or directory

this
install -m 0644 -p fonts/*.pcf.gz $RPM_BUILD_ROOT%{fontdir}/
should be changed to
install -m 0644 -p *.pcf.gz $RPM_BUILD_ROOT%{fontdir}/

- this should be removed because it is not used:
%define buildsubdir     %{name}-%{version}

- in %prep
instead of
%{__mkdir_p} $RPM_BUILD_DIR/%{name}-%{version}
cd $RPM_BUILD_DIR/%{name}-%{version}
tar xfz %{SOURCE0}
this should be used:
%setup -q -n fonts

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

------- Additional Comments From [e-mail]  2007-09-07 02:39 EST -------
(In reply to comment #3)
> Building with mock gives an error:
> install -m 0644 -p 'fonts/*.pcf.gz'
>
> /var/tmp/knm_new-fonts-1.1-1.fc7-root-mockbuild/usr/share/fonts/knm_new-fonts/
> install: cannot stat `fonts/*.pcf.gz': No such file or directory

Doh. my bad. however:
> in %prep
>
> instead of
> %{__mkdir_p} $RPM_BUILD_DIR/%{name}-%{version}
> cd $RPM_BUILD_DIR/%{name}-%{version}
> tar xfz %{SOURCE0}
> this should be used:
> %setup -q -n fonts

I'm worrying about following that since "fonts" is too generic and it might
affects to others perhaps.

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

------- Additional Comments From [e-mail]  2007-09-07 02:49 EST -------
Ok, updated. hopefully it should works enough.

Spec URL: http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts.spec
SRPM URL:
http://tagoh.fedorapeople.org/knm_new-fonts/knm_new-fonts-1.1-2.fc8.src.rpm

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-09-24 03:09 EST -------
? - fonts-japanese spec file contains fonts.cache-1 and encodings.dir.
    Are these ghost files no longer needed?

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

------- Additional Comments From [e-mail]  2007-09-24 03:54 EST -------
Yes for this package at least, because those ghost are still required for
fonts-japanese to ensure removing all the files and the directories cleanly when
the package is removed so that it was generated outside the package. and this
package uses the different install dir and no longer created.

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

------- Additional Comments From [e-mail]  2007-09-24 04:06 EST -------
No, it isn't needed anymore, I meant.

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-09-24 04:22 EST -------
Then okay for this package.

-----------------------------------------------------
  This package (knm_new-fonts) is APPROVED by me
-----------------------------------------------------

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

------- Additional Comments From [e-mail]  2007-09-24 04:45 EST -------
Thanks for quick review.

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-09-25 05:31 EST -------
New Package CVS Request
=======================
Package Name: knm_new-fonts
Short Description: 12x12 JIS X 0208 Bitmap font
Owners: tagoh
Branches: devel
InitialCC: 
Cvsextras Commits: yes

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-09-25 14:17 EST -------
cvs done.

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 266261] Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knm_new-fonts - 12x12 JIS X 0208 Bitmap font

https://bugzilla.redhat.com/show_bug.cgi?id=266261

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide