https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Bug ID: 2358960 Summary: Review Request: rust-postmark - Rust client Product: Fedora Version: rawhide URL: https://crates.io/crates/postmark Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: fedora@lecris.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark-0.10.2-1...
Description: Postmark rust client.
Fedora Account System Username: lecris
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2357955
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2357955 [Bug 2357955] atuin-18.5.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8888321 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2358962
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2358962 [Bug 2358962] Review Request: rust-httptest - HTTP testing facilities including a mock server
https://bugzilla.redhat.com/show_bug.cgi?id=2358960 Bug 2358960 depends on bug 2358962, which changed state.
Bug 2358962 Summary: Review Request: rust-httptest - HTTP testing facilities including a mock server https://bugzilla.redhat.com/show_bug.cgi?id=2358962
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Looks like the heuristics for generating package Summary failed here, can you fix it?
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #3 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark-0.10.2-1...
Update the package summary and description
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED Summary|Review Request: |Review Request: |rust-postmark - Rust client |rust-postmark - Postmark | |rust client Flags| |fedora-review?
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks - looks like the package is MIT / Apache-2.0 dual licensed, but only contains the Apache-2.0 license text?
The README is also not helpful:
postmark is distributed under the terms of both the MIT license and the Apache License (Version 2.0).
This is confusing - is it *both* or *alternatively*? Those are two different things (i.e AND or OR).
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #5 from Cristian Le fedora@lecris.me --- Thanks, I've raised the issue with upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #6 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark-0.11.3-1...
Update to postmark 0.11. They fixed the license there :)
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=132173419
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8986526 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- Looks good to me, with one exception:
You generated the spec with all features enabled, this might not do what you want: There are two reqwest backends, and they should be mutually exclusive (native-tls and rustls-tls) - I'm not sure how it doesn't give you a compile error when both are enabled.
It's hard to tell for me without the rust2rpm.toml file *why* you enabled all features - if it's for running / compiling tests, please just enable the features that are necessary. But enabling *both* reqwest-native-tls *and* reqwest-rustls-tls seems to be a mistake.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #9 from Cristian Le fedora@lecris.me --- Spec URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-postmark/rust-postmark-0.11.3-1...
Removed the feature-all. It seems there is no reference of these features in the code, other than reqwest which I've enabled in order to get it to compile. Probably the error would be ocurring on the consumer side
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=132732012
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2089843 --> https://bugzilla.redhat.com/attachment.cgi?id=2089843&action=edit The .spec file difference from Copr build 8986526 to 9040407
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9040407 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #12 from Fabio Valentini decathorpe@gmail.com --- Thanks, looks good to me now!
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #13 from Cristian Le fedora@lecris.me --- Thank you for the review, Fabio
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #14 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-postmark
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c788c2483d (rust-postmark-0.11.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c788c2483d
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c788c2483d (rust-postmark-0.11.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-c788c2483d
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-ceac2606f6 (rust-postmark-0.11.3-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ceac2606f6
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-2f8b77ecfd (rust-postmark-0.11.3-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-2f8b77ecfd
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2025-05-22 20:04:53
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-2f8b77ecfd (rust-postmark-0.11.3-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-ceac2606f6 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ceac2606f6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ceac2606f6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c788c2483d has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c788c2483d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c788c2483d
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-c788c2483d (rust-postmark-0.11.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2358960
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-ceac2606f6 (rust-postmark-0.11.3-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com