Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources. Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nikolay@vladimiroff.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://ns.bgtld.net/build/libntlm.spec SRPM URL: http://ns.bgtld.net/build/libntlm-0.3.13-1.fc7.src.rpm Description: A library for authenticating with Microsoft NTLM challenge-response, derived from Samba sources.
Note: This package is needed for building libgsasl with NTLM support.
I need a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@free.fr
------- Additional Comments From pertusus@free.fr 2007-06-20 18:13 EST ------- The %doc files that are in main package are not needed in -devel.
It would be better to keep timestamps for noarch files to have the same timestamps for all arches in multilib. The noarch file is %{_includedir}/ntlm.h and is generated from configure so maybe you could do something along touch -r NEWS $RPM_BUILD_ROOT%{_includedir}/ntlm.h
The Requires: pkgconfig should be for devel only.
There should also be a BuildRequires: pkgconfig
I think the Summary should have NTLM instead of 'Microsoft WinNT domain' since it is better known.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
------- Additional Comments From nikolay@vladimiroff.com 2007-06-20 18:37 EST ------- * Thu Jun 21 2007 Nikolay Vladimirov nikolay@vladimiroff.com - 0.3.13-2 - fixed summary - fixed requires and buildrequires for pkgconfig - fixed the timestamp of ntlm.h
Spec URL: http://ns.bgtld.net/build/libntlm.spec SRPM URL: http://ns.bgtld.net/build/libntlm-0.3.13-2.fc7.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |pertusus@free.fr
------- Additional Comments From pertusus@free.fr 2007-06-21 03:21 EST ------- Everything is almost fine
* rpmlint is almost silent W: libntlm mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) You can fix it if you like. * free software with license included * follow naming and packaging guidelines * sane provides: Provides: libntlm.so.0 * match upstream 14e8aa077e032ae353b885a6d82ee668 libntlm-0.3.13.tar.gz * %files section right * development symlink and headers in -devel * no static lib
It would be nice to have a description of the API, but there is none upstream, so...
There is one real issue (apart from the tab in the spec file), the source file timestamp isn't kept: $ ls -l libntlm-0.3.13.tar.gz ../SOURCES/libntlm-0.3.13.tar.gz -rw-rw-r-- 1 dumas dumas 419505 mar 27 18:40 libntlm-0.3.13.tar.gz -rw-rw-r-- 1 dumas dumas 419505 jun 20 22:04 ../SOURCES/libntlm-0.3.13.tar.gz
So, please when you import the package use a source file with the right timestamp. This can be achieved with wget -N or spectool -g.
It is APPROVED, and I'll sponsor you when gsasl and msmtp are also approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
------- Additional Comments From nikolay@vladimiroff.com 2007-06-21 03:57 EST ------- Great!
* Thu Jun 21 2007 Nikolay Vladimirov nikolay@vladimiroff.com - 0.3.13-3 - minor mixed-use-of-spaces-and-tabs fix
Spec URL: http://ns.bgtld.net/build/libntlm.spec SRPM URL: http://ns.bgtld.net/build/libntlm-0.3.13-3.fc7.src.rpm
Also used source file with correct timestamp .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
nikolay@vladimiroff.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From nikolay@vladimiroff.com 2007-06-23 07:09 EST ------- New Package CVS Request ======================= Package Name: libntlm Short Description: NTLM authentication library Owners: nikolay@vladimiroff.com Branches: FC-6 F-7 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-06-25 14:47 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
nikolay@vladimiroff.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
------- Additional Comments From updates@fedoraproject.org 2007-07-02 12:12 EST ------- libntlm-0.3.13-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libntlm - library that implement NTLM authentication derived from Samba sources.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245080
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |0.3.13-3.fc7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=245080
Nikolay Vladimirov nikolay@vladimiroff.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #8 from Nikolay Vladimirov nikolay@vladimiroff.com 2009-01-19 06:05:58 EDT --- Package Change Request ====================== Package Name: libntlm New Branches: EL-5 Owners: turki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=245080
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-01-19 18:23:42 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=245080
Nikolay Vladimirov nikolay@vladimiroff.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #10 from Nikolay Vladimirov nikolay@vladimiroff.com 2011-07-11 14:22:28 EDT --- Package Change Request ====================== Package Name: libntlm New Branches: EL-4 Owners: turki
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=245080
--- Comment #11 from Jon Ciesla limb@jcomserv.net 2011-07-11 14:31:03 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org