[Bug 1082328] New: Review Request: nodejs-websocket-driver - WebSocket protocol handler with pluggable I/O for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Bug ID: 1082328 Summary: Review Request: nodejs-websocket-driver - WebSocket protocol handler with pluggable I/O for Node.js Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jamielinux@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://jamielinux.fedorapeople.org/gruntjs/nodejs-websocket-driver.spec SRPM URL: http://jamielinux.fedorapeople.org/gruntjs/SRPMS/nodejs-websocket-driver-0.3... Fedora Account System Username: jamielinux
Description: WebSocket protocol handler with pluggable I/O for Node.js.
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1082329
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1082329 [Bug 1082329] Review Request: nodejs-faye-websocket - A standards-compliant WebSocket server and client for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@compton.nu Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
--- Comment #1 from Tom Hughes tom@compton.nu --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues ======
[!]: %check is present and all tests pass.
Although it is present the tests are not included in the archive so I haven't been able to run them.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-websocket-driver-0.3.2-1.fc21.noarch.rpm nodejs-websocket-driver-0.3.2-1.fc21.src.rpm nodejs-websocket-driver.noarch: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged nodejs-websocket-driver.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-websocket-driver.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged nodejs-websocket-driver.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-websocket-driver.noarch: W: only-non-binary-in-usr-lib nodejs-websocket-driver.src: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged nodejs-websocket-driver.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-websocket-driver.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged nodejs-websocket-driver.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 9 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-websocket-driver nodejs-websocket-driver.noarch: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged nodejs-websocket-driver.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-websocket-driver.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged nodejs-websocket-driver.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-websocket-driver.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 5 warnings. # echo 'rpmlint-done:'
Requires -------- nodejs-websocket-driver (rpmlib, GLIBC filtered): nodejs(engine)
Provides -------- nodejs-websocket-driver: nodejs-websocket-driver npm(websocket-driver)
Source checksums ---------------- http://registry.npmjs.org/websocket-driver/-/websocket-driver-0.3.2.tgz : CHECKSUM(SHA256) this package : f9429849c6a2f8cb73e64b55fc6dfdde325acfc779ff15e4b5ad9d8ceec3c597 CHECKSUM(SHA256) upstream package : f9429849c6a2f8cb73e64b55fc6dfdde325acfc779ff15e4b5ad9d8ceec3c597
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1082328 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
--- Comment #2 from Jamie Nguyen jamielinux@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/gruntjs/nodejs-websocket-driver.spec SRPM URL: http://jamielinux.fedorapeople.org/gruntjs/SRPMS/nodejs-websocket-driver-0.3...
* Sun Mar 30 2014 Jamie Nguyen jamielinux@fedoraproject.org - 0.3.2-2 - include test files as separate source
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Tom Hughes tom@compton.nu --- Looks good, and tests pass. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Jamie Nguyen jamielinux@fedoraproject.org --- New Package SCM Request ======================= Package Name: nodejs-websocket-driver Short Description: WebSocket protocol handler with pluggable I/O for Node.js Owners: jamielinux patches Branches: f19 f20 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1082328
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2014-04-01 02:38:00
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla