[Bug 1922774] New: Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail

https://bugzilla.redhat.com/show_bug.cgi?id=1922774

Bug ID: 1922774
           Summary: Review Request: perl-Test-DiagINC - List modules and
                    versions loaded if tests fail
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC...
Description:
Assuming you shipped your module to CPAN with working tests, test failures
from CPAN Testers might be due to platform issues, Perl version issues or
problems with dependencies. This module helps you diagnose deep dependency
problems by showing you exactly what modules and versions were loaded
during a test run.

Fedora Account System Username: eseyman
Rpmlint Output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.

[Bug 1922774] Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail

https://bugzilla.redhat.com/show_bug.cgi?id=1922774

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1922738

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1922738
[Bug 1922738] perl-CSS-Minifier-XS-0.12 is available

[Bug 1922774] Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail

https://bugzilla.redhat.com/show_bug.cgi?id=1922774

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

[Bug 1922774] Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail

https://bugzilla.redhat.com/show_bug.cgi?id=1922774

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add 'coreutils', it is needed for macro %{_fixperms}

$ rpm -qp --requires perl-Test-DiagINC-0.008-1.fc34.noarch.rpm | sort | uniq -c
| grep -v rpmlib
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(:VERSION) >= 5.6.0
Binary requires 
FIX: Please add following run-requires, they are not found by generators:
     - perl(B)
     - perl(Cwd)
     - perl(File::Spec)
     - perl(strict)
     - perl(warnings)

$ rpm -qp --provides perl-Test-DiagINC-0.008-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Test::DiagINC) = 0.008
      1 perl-Test-DiagINC = 0.008-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-Test-DiagINC*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items.

Resolution:
Approved

[Bug 1922774] Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail

https://bugzilla.redhat.com/show_bug.cgi?id=1922774

--- Comment #2 from Emmanuel Seyman  ---

Thank you for the review, Jikta.

I've taken into account your feedback and updated the package:
Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Test-DiagINC/perl-Test-DiagINC...

I've also requested the repository:
https://pagure.io/releng/fedora-scm-requests/issue/31990

[Bug 1922774] Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail

https://bugzilla.redhat.com/show_bug.cgi?id=1922774

--- Comment #3 from Mohan Boddu  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Test-DiagINC

[Bug 1922774] Review Request: perl-Test-DiagINC - List modules and versions loaded if tests fail

https://bugzilla.redhat.com/show_bug.cgi?id=1922774

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |perl-Test-DiagINC-0.008-2.f
                   |                            |c34
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-02-08 08:25:39

--- Comment #4 from Emmanuel Seyman  ---
Built and submitted to rawhide.