[Bug 1288541] New: Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator - package-review

List overview All Threads
Download

newer

[Bug 1288541] New: Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

older

[Bug 1262965] New: Review Request:...

[Bug 1292121] New: Review Request:...

Red Hat Bugzilla

4 Dec 2015 4 Dec '15

8:28 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

Bug ID: 1288541 Summary: Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll-0.36-1... Description: This is the engine used by tidyall - read that first to get an overview.

You can call this API from your own program instead of executing tidyall.

Fedora Account System Username: jplesnik@redhat.com

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

4 Dec 4 Dec

8:29 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

Jitka Plesnikova jplesnik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1287121, 1287775, 1288065

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1287121 [Bug 1287121] Review Request: perl-Mason-Tidy - Tidy HTML::Mason/Mason components https://bugzilla.redhat.com/show_bug.cgi?id=1287775 [Bug 1287775] Review Request: perl-SVN-Look - Caching wrapper around the svnlook command https://bugzilla.redhat.com/show_bug.cgi?id=1288065 [Bug 1288065] Review Request: perl-Pod-Tidy - Reformatting Pod Processor

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Dec 7 Dec

2:27 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541 Bug 1288541 depends on bug 1287775, which changed state.

Bug 1287775 Summary: Review Request: perl-SVN-Look - Caching wrapper around the svnlook command https://bugzilla.redhat.com/show_bug.cgi?id=1287775

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Dec 8 Dec

10:09 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

Petr Šabata psabata@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9 Dec 9 Dec

7:32 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541 Bug 1288541 depends on bug 1288065, which changed state.

Bug 1288065 Summary: Review Request: perl-Pod-Tidy - Reformatting Pod Processor https://bugzilla.redhat.com/show_bug.cgi?id=1288065

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11 Dec 11 Dec

5:22 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541 Bug 1288541 depends on bug 1287121, which changed state.

Bug 1287121 Summary: Review Request: perl-Mason-Tidy - Tidy HTML::Mason/Mason components https://bugzilla.redhat.com/show_bug.cgi?id=1287121

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Dec 15 Dec

2:51 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

Jitka Plesnikova jplesnik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1285423

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1285423 [Bug 1285423] perl-JavaScript-Beautifier-0.20 is available

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Dec 16 Dec

9:09 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

--- Comment #1 from Petr Šabata psabata@redhat.com --- Well, this one is big and the code fairly unreadable. Apologies for the delay.

Anyhow, the provided separate SPEC file is for version 0.37 while the provided SRPM is for 0.36. The differences in upstream code are minimal; I'll be reviewing 0.36 here. Please, don't update the links.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:09 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

--- Comment #2 from Petr Šabata psabata@redhat.com --- * You list the Test::Class::Most build time dependency twice.

* Some of the listed build time dependencies aren't actually necessary, namely: - autodie - IPC::System::Simple - List::Compare - Log::Any - Test::Builder

* One build time dependency missing: lib

* The package description is fairly poorly written and doesn't say much.

* The summary implies this package is just the engine, even though it also installs the utility it refers to. You could keep that and split the utility into a subpackage, if you think it makes sense. Or change the summary. Your call.

* Many of the plugins require external utilities you neither require nor recommend/suggest. The package won't work as advertised without them. See the Code::TidyAll::Plugin namespace.

* Possibly similar situation with the VCSs -- will this work without git or subversion? Maybe -- I don't know how these hooks are meant to be used.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

22 Dec 22 Dec

6:35 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com --- Files are updated

Spec URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Code-TidyAll/perl-Code-TidyAll-0.37-1...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:26 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

--- Comment #4 from Petr Šabata psabata@redhat.com --- * You still list Test::Class::Most twice.

* The `lib' dependency is still missing.

* I guess the summary and description are a little better now. Alright...

* Trailing whitespace on line 53.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:39 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- Updated files are on the same links.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:41 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

Petr Šabata psabata@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #6 from Petr Šabata psabata@redhat.com --- Okay, I'm going to approve this.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:48 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

--- Comment #7 from Patrick Uiterwijk puiterwijk@redhat.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Code-TidyAll

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Jan 4 Jan

5:22 a.m.

New subject: [Bug 1288541] Review Request: perl-Code-TidyAll - Engine for tidyall, your all-in-one code tidier and validator

https://bugzilla.redhat.com/show_bug.cgi?id=1288541

Jitka Plesnikova jplesnik@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3487

Age (days ago)

3518

Last active (days ago)

package-review@lists.fedoraproject.org

14 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla