[Bug 615669] New: Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Summary: Review Request: perl-Crypt-Cracklib - perl module to
                    interact with libcrack
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://red-dragon.com/perl-Crypt-Cracklib.spec
SRPM URL: http://red-dragon.com/perl-Crypt-Cracklib-1.4-1.fc13.src.rpm
Description: This is a perl module to interact with system libcrack

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #1 from Carl Thompson  2010-07-17 16:57:27 EDT ---
This is my first package and requesting sponsor per
http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Guidelines

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

manuel wolfshant  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #2 from Carl Thompson  2010-07-17 17:40:41 EDT ---
Updated Spec after run of rpmlint to fix warnings.  New spec is uploaded to url
listed.

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #3 from Carl Thompson  2010-07-17 19:34:17 EDT ---
Updated spec so that spec and package pass rpmlint with no warnings or errors.

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #4 from Carl Thompson  2010-07-17 20:41:12 EDT ---
Submitted both patches in package upstream to author:
https://rt.cpan.org/Public/Bug/Display.html?id=59488
https://rt.cpan.org/Public/Bug/Display.html?id=59489

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #5 from Carl Thompson  2010-07-20 22:01:51 EDT ---
Updated to Crypt-Cracklib 1.5
Spec URL: http://red-dragon.com/perl-Crypt-Cracklib.spec
SRPM URL: http://red-dragon.com/perl-Crypt-Cracklib-1.5.1.fc13.src.rpm

Both upstream patches were applied by author is reason for 1.5 release

passed rpmlint no errors

koji builds on F13 and rawhide passed

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #6 from Carl Thompson  2010-07-21 14:41:22 EDT ---
reviewed https://bugzilla.redhat.com/show_bug.cgi?id=615577

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #7 from Carl Thompson  2010-07-22 18:42:15 EDT ---
Another package I've submitted is
https://bugzilla.redhat.com/show_bug.cgi?id=617400

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #8 from Kevin Fenzi  2010-07-24 15:37:25 EDT ---
I'll go ahead and review this and your other submission and look at sponsoring
you. ;)

Look for a full review in a while here...

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #9 from Kevin Fenzi  2010-07-24 16:02:11 EDT ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPL+ or artistic)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
e5fe8cd8894b2d66767e48f51779d778  Crypt-Cracklib-1.5.tar.gz
e5fe8cd8894b2d66767e48f51779d778  Crypt-Cracklib-1.5.tar.gz.orig

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
See below - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
See below - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
See below - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
OK - No rpmlint output. 
See below - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues:

1. You are disabling the internal dependency generator here, but not doing any
manual dependency generation. Why? I see no problems removing that line here.

2. The: 
if [ ! "$RPM_BUILD_ROOT" = "/" ]
then

in install and clean sections should be removed. There are no longer required 
or wanted. ;)

3. There seems to be a test suite here. Perhaps run it in %check?
See https://fedoraproject.org/wiki/Packaging/Perl#Testing_and_Test_Suites

4. You should include Changes and README as %doc files. Also, you may want 
to ask upstream to include a copy of the license.

5. You need to own the %{perl_archlib}/Crypt/ directory here. 
Either change %{perl_archlib}/Crypt/Cracklib.pm to just %{perl_archlib}/Crypt/
or add a %dir%{perl_archlib}/Crypt to files. Likewise for the auto/Crypt dir.

6. rpmlint says:

3 packages and 0 specfiles checked; 0 errors, 0 warnings.

7. Did you take an existing spec to create this one? If so, please do leave the 
old spec changelog entries to credit the orig author(s).

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #10 from Carl Thompson  2010-07-26 17:01:46 EDT ---
New spec and build tested on koji dist-f13 and dist-rawhide

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #11 from Kevin Fenzi  2010-07-27 23:37:53 EDT ---
Please do add a changelog entry and bump Release while making changes for the
review. 
This prevents confusion between submitter and reviewer as to what they are
looking at. ;)

Can you add pointers to the current spec/src.rpm?

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #12 from Carl Thompson  2010-07-28 00:15:04 EDT ---
SPEC: http://red-dragon.com/perl-Crypt-Cracklib.spec
SRPM: http://red-dragon.com/perl-Crypt-Cracklib-1.5-2.fc13.src.rpm

1) re enabled the internal dependancy generator

2) removed the $RPM_BUILD_ROOT test from install and clean

3) added %check section with make test

4) included the Changes and README as %doc files

5) Many perl packages sit in Crypt so can't properly own to this package

6) rpmlint says
[redragon@gkar SPECS]$ rpmlint perl-Crypt-Cracklib.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[redragon@gkar x86_64]$ rpmlint perl-Crypt-Cracklib-1.5-2.fc13.x86_64.rpm 
perl-Crypt-Cracklib.x86_64: W: private-shared-object-provides
/usr/lib64/perl5/auto/Crypt/Cracklib/Cracklib.so Cracklib.so()(64bit)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

7) this is a new spec just for this package

koji build on rawhide passed no failures
koji build on f13 passed no failures

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #13 from Kevin Fenzi  2010-07-28 00:50:38 EDT ---
1, 2, 3, all look good.

on 4:

You can replace:

%doc %{_defaultdocdir}/perl-Crypt-Cracklib-%{version}/Changes
%doc %{_defaultdocdir}/perl-Crypt-Cracklib-%{version}/README

with just:

%doc Changes README

5. I think this falls under:

https://fedoraproject.org/wiki/Packaging/Guidelines#Multiple_packages_own_fi....

I see currently all of the following own this dir:

perl-Crypt-OpenSSL-PKCS10-0:0.06-15.fc14.x86_64
perl-Crypt-OpenSSL-Random-0:0.04-12.fc14.x86_64
perl-Crypt-DES-0:2.05-11.fc14.x86_64
perl-Crypt-OpenSSL-X509-0:0.7-7.fc14.x86_64
perl-Crypt-Eksblowfish-0:0.008-2.fc14.x86_64
perl-Crypt-Twofish-0:2.14-2.fc14.x86_64
perl-Crypt-OpenSSL-RSA-0:0.25-12.fc14.x86_64
perl-Crypt-SSLeay-0:0.57-17.fc14.x86_64
perl-Crypt-OpenSSL-AES-0:0.02-11.fc14.x86_64
perl-Crypt-Rijndael-0:1.09-2.fc14.x86_64
perl-Crypt-Blowfish-0:2.10-10.fc14.x86_64
crypto-utils-0:2.4.1-27.x86_64
perl-Crypt-OpenSSL-Bignum-0:0.04-10.fc14.x86_64
perl-Crypt-OpenSSL-DSA-0:0.13-16.fc14.x86_64
perl-Crypt-SMIME-0:0.09-4.fc14.x86_64

6 and 7: ok.

I see you have a

Epoch: 1

here. Why?

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #14 from Carl Thompson  2010-07-28 01:09:30 EDT ---
SPEC: http://red-dragon.com/perl-Crypt-Cracklib.spec
SRPM: http://red-dragon.com/perl-Crypt-Cracklib-1.5-3.fc13.src.rpm

4) updated %doc in files section

5) added the Crypt directory (amazingly this corrected the .so error)

Epoch was removed, no idea why I plugged that one in.

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #15 from Kevin Fenzi  2010-07-28 13:12:44 EDT ---
4. Looks good. 
5. Looks good.

I don't see any further blockers here, so this package is APPROVED.

Let me know your fedora account system login and I will sponsor you.

Please feel free to ping me on irc, email or this bug and I will be happy to
help answer any questions you have.

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #16 from Carl Thompson  2010-07-28 15:25:04 EDT ---
New Package CVS Request
=======================
Package Name: perl-Crypt-Cracklib
Short Description: perl module to interact with libcrack
Owners: redragon
Branches: F-13
InitialCC: redragon

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Carl Thompson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Carl Thompson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #17 from Kevin Fenzi  2010-07-30 16:29:32 EDT ---
GIT done (by process-cvs-requests.py).

With f14 branch added.

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #18 from Fedora Update System  2010-07-30 20:59:28 EDT ---
perl-Crypt-Cracklib-1.5-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc13

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #19 from Fedora Update System  2010-07-30 20:59:33 EDT ---
perl-Crypt-Cracklib-1.5-3.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc14

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #20 from Fedora Update System  2010-08-01 15:22:52 EDT ---
perl-Crypt-Cracklib-1.5-3.fc14 has been pushed to the Fedora 14 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Crypt-Cracklib'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc14

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #21 from Fedora Update System  2010-08-02 21:00:25 EDT ---
perl-Crypt-Cracklib-1.5-3.fc13 has been pushed to the Fedora 13 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Crypt-Cracklib'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.5-3.fc13

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #22 from Fedora Update System  2010-08-13 17:12:57 EDT ---
perl-Crypt-Cracklib-1.5-3.fc13 has been pushed to the Fedora 13 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |perl-Crypt-Cracklib-1.5-3.f
                   |                            |c13
         Resolution|                            |ERRATA

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #23 from Fedora Update System  2010-08-18 21:08:44 EDT ---
perl-Crypt-Cracklib-1.5-3.fc14 has been pushed to the Fedora 14 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|perl-Crypt-Cracklib-1.5-3.f |perl-Crypt-Cracklib-1.5-3.f
                   |c13                         |c14

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #24 from Carl Thompson  2011-02-06 21:17:52 EST ---
Package Change Request
======================
Package Name: perl-Crypt-Cracklib
New Branches: EPEL5 EPEL6
Owners: redragon
InitialCC: redragon

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Carl Thompson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #25 from Kevin Fenzi  2011-02-06 21:39:02 EST ---
Git done (by process-git-requests).

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #26 from Fedora Update System  2011-02-06 23:17:59 EST ---
perl-Crypt-Cracklib-1.7-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.7-1.fc13

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=615669

--- Comment #27 from Fedora Update System  2011-02-06 23:20:45 EST ---
perl-Crypt-Cracklib-1.7-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Crypt-Cracklib-1.7-1.fc14