[Bug 2373128] New: Review Request kmscon / libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Bug ID: 2373128
           Summary: Review Request kmscon / libtsm
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

I would like to unretire kmscon and libtsm

https://src.fedoraproject.org/rpms/kmscon
https://src.fedoraproject.org/rpms/libtsm

I currently maintain them on my copr:
https://copr.fedorainfracloud.org/coprs/jfalempe/kmscon/

kmscon spec:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
kmscon srpm:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

libtsm spec:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
libtsm srpm
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

description kmscon:
Kmscon is a simple terminal emulator based on linux kernel mode setting (KMS).
It is an attempt to replace the in-kernel VT implementation with a userspace
console. See kmscon(1) man-page for usage information.

description libtsm:
TSM is a state machine for DEC VT100-VT520 compatible terminal emulators. It
tries to support all common standards while keeping compatibility to existing
emulators like xterm, gnome-terminal, konsole, ...

I've also fixed upstream the main bugs that prevented kmscon to run on Fedora:
https://github.com/Aetf/kmscon/pull/92
https://github.com/Aetf/kmscon/pull/96
https://github.com/Aetf/kmscon/pull/109

Reproducible: Always

[Bug 2373128] Review Request kmscon / libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 2373128] Review Request kmscon / libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #2 from Neal Gompa  ---
This needs to be broken up into two reviews: one for kmscon and one for libtsm.

Please split this accordingly by following the template[1] and feel free to
assign me to both of them.

[1]:
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&format=fedora-r...

[Bug 2373128] Review Request kmscon / libtsm

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

I would like to unretire kmscon

Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

Description:
Kmscon is a simple terminal emulator based on linux kernel mode setting (KMS).
It is an attempt to replace the in-kernel VT implementation with a userspace
console. See kmscon(1) man-page for usage information.

Fedora Account System Username: jfalempe

https://src.fedoraproject.org/rpms/kmscon

Reproducible: Always

[Bug 2373128] Review Request kmscon

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request kmscon /     |Review Request kmscon
                   |libtsm                      |

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request kmscon       |Review Request: kmscon -
                   |                            |Userspace terminal emulator

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #3 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

[fedora-review-service-build]

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated

--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

Description: Kmscon is a simple terminal emulator based on linux kernel mode
setting (KMS). It is an attempt to replace the in-kernel VT implementation with
a userspace console. See kmscon(1) man-page for usage information.

Fedora Account System Username: jfalempe

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |Unretirement

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #4 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #5 from Neal Gompa  ---
Created attachment 2096392
  --> https://bugzilla.redhat.com/attachment.cgi?id=2096392&action=edit
changelog entries from suse spec

It looks like kmscon's spec is derived from the openSUSE one...

See:
https://build.opensuse.org/projects/X11:terminals/packages/kmscon/files/kmsc...

You should probably integrate the changelog entries accordingly too...

I've attached properly formatted changelog entries.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #6 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
[fedora-review-service-build]

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #7 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

I've applied the same changes as the libtsm comment:
https://bugzilla.redhat.com/show_bug.cgi?id=2373136#c14

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #8 from Neal Gompa  ---
Spec review notes:
> # O/P added for 13.1
> Obsoletes:      %{name}-service < %{version}-%{release}
> Provides:       %{name}-service = %{version}-%{release}

This should be dropped as it's not relevant to us.
> pushd selinux
> make install DESTDIR=%{buildroot}
> popd

This can be replaced with "%make_install -C selinux"

As for the changelog, it needs to have all of its entries sorted in reverse
chronological order.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #9 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

Thanks, I've sorted the changelog, and done the other comments.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/Aetf/kms
                   |                            |con/

--- Comment #10 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9379752
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #11 from Jocelyn Falempe  ---
[fedora-review-service-build]

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #12 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9388479
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #13 from Jocelyn Falempe  ---
[fedora-review-service-build]

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #14 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9389221
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/kmscon
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...
- Systemd service file(s) in kmscon
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #15 from Neal Gompa  ---
> %{_unitdir}/*.service

This should be expanded out, since we need scriptlets here too.
> %{_unitdir}/kmscon.service
> %{_unitdir}/kmsconvt@.service

And scriptlets mentioned in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scrip...
need to be in the spec.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #16 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

I've added proper systemd scriptlets, I choose only to reload the service, as
restarting the service will break if you're upgrading kmscon from a kmscon
console.
I also removed the selinux custom rules, because kmscon is now enabled in the
global selinux policies:
https://github.com/fedora-selinux/selinux-policy/pull/2813

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #17 from Fedora Review Service  ---
Created attachment 2103350
  --> https://bugzilla.redhat.com/attachment.cgi?id=2103350&action=edit
The .spec file difference from Copr build 9389221 to 9404928

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #18 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9404928
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/kmscon
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Jocelyn Falempe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #19 from Jocelyn Falempe  ---
Gentle ping @[e-mail], can you review the latest version?

Thanks,

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #20 from Neal Gompa  ---
> %build
> # Work around https://github.com/Aetf/kmscon/issues/63
> export CFLAGS="%{optflags} $(pkg-config xkbcommon --cflags) $(pkg-config libtsm --cflags) -Wno-error"
> %meson -Dtests=false

These should be in %conf, unless this package is intended to available in EPEL
< 10.

See this as an example:
https://src.fedoraproject.org/rpms/waynergy/blob/rawhide/f/waynergy.spec

Also, why are tests disabled? Is it not possible to run them in %check?

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #21 from Jocelyn Falempe  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jfalempe/kmscon/fedora-ra...

Thanks for the review:

I have removed the CLFAGS work around, as it seems it is not needed anymore.
I have moved the the %meson in the %conf section
and I have added check-devel as BuildRequires, and added:
%check
%meson_test

The kmscon unit test are very minimal (only the "shl" part has some tests), so
that's probably why it wasn't enabled.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #22 from Fedora Review Service  ---
Created attachment 2105492
  --> https://bugzilla.redhat.com/attachment.cgi?id=2105492&action=edit
The .spec file difference from Copr build 9404928 to 9512416

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #23 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9512416
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/kmscon
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #24 from Neal Gompa  ---
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correct and license data is installed
* No serious issues from rpmlint

PACKAGE APPROVED.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #25 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at https://src.fedoraproject.org/rpms/kmscon

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #26 from Fedora Update System  ---
FEDORA-2025-3600b1d633 (kmscon-9.1.0-1.fc43) has been submitted as an update to
Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3600b1d633

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #27 from Fedora Update System  ---
FEDORA-2025-3600b1d633 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2025-3600b1d633 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-3600b1d633

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |MODIFIED

--- Comment #28 from Fedora Update System  ---
FEDORA-2025-b152f08abf (kmscon-9.1.0-1.fc42) has been submitted as an update to
Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b152f08abf

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #29 from Fedora Update System  ---
FEDORA-2025-b152f08abf has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2025-b152f08abf *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2025-b152f08abf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|ON_QA                       |CLOSED
        Last Closed|                            |2025-10-23 01:03:21

--- Comment #30 from Fedora Update System  ---
FEDORA-2025-b152f08abf (kmscon-9.1.0-1.fc42) has been pushed to the Fedora 42
stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2373128] Review Request: kmscon - Userspace terminal emulator

https://bugzilla.redhat.com/show_bug.cgi?id=2373128

--- Comment #31 from Fedora Update System  ---
FEDORA-2025-3600b1d633 (kmscon-9.1.0-1.fc43) has been pushed to the Fedora 43
stable repository.
If problem still persists, please make note of it in this bug report.