https://bugzilla.redhat.com/show_bug.cgi?id=1376660
Bug ID: 1376660 Summary: Review Request: golang-github-franela-goblin - Minimal and Beautiful Go testing framework Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mrunge@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
SSpec URL: https://mrunge.fedorapeople.org/reviews/golang-github-franela-goblin/golang-...
SRPM URL: https://mrunge.fedorapeople.org/reviews/golang-github-franela-goblin/golang-...
Description: Minimal and Beautiful Go testing framework
Fedora Account System Username: mrunge
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15653988
$ rpmlint golang-github-franela-goblin-0-0.1.gitefa9910.fc24.src.rpm golang-github-franela-goblin-devel-0-0.1.gitefa9910.fc24.noarch.rpm golang-github-franela-goblin-unit-test-devel-0-0.1.gitefa9910.fc24.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1376660
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1376659
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1376659 [Bug 1376659] Review Request: golang-github-franela-goreq - Minimal and simple request library for Go language
https://bugzilla.redhat.com/show_bug.cgi?id=1376660
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |athoscribeiro@gmail.com Assignee|nobody@fedoraproject.org |athoscribeiro@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1376660
--- Comment #1 from Athos Ribeiro athoscribeiro@gmail.com --- Hello,
I am taking this one.
- Is there any reason for not running the test suite?
- Upstream does have a version 0.0.1 (see [1]). So maybe you want to package a post release(?)
- If you are packaging a snapshot, - check the new guidelines for the Release: tag. The date the snapshot was taken must be present (this should be updated in gofed). See [2] and [3] for reference.
- The conditionals on lines 52 and 68 could be removed, since they are not used at all.
[1] https://github.com/franela/goblin/tree/0.0.1 [2] https://fedoraproject.org/wiki/Packaging:Versioning [3] https://fedoraproject.org/wiki/Package_Versioning_Examples
package-review@lists.fedoraproject.org