[Bug 498186] New: Review Request: perl-JavaScript-Beautifier - beautifier for javascript

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-JavaScript-Beautifier - beautifier for javascript

https://bugzilla.redhat.com/show_bug.cgi?id=498186

Summary: Review Request: perl-JavaScript-Beautifier -
                    beautifier for javascript
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL:
http://mmaslano.fedorapeople.org/review/perl-JavaScript-Beautifier.spec
SRPM URL:
http://mmaslano.fedorapeople.org/review/perl-JavaScript-Beautifier-0.04-1.fc...
Description: This module is mostly a Perl-rewrite of
http://github.com/einars/js-
beautify/tree/master/beautify.js

http://koji.fedoraproject.org/koji/taskinfo?taskID=1328326

[Bug 498186] Review Request: perl-JavaScript-Beautifier - beautifier for javascript

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=498186

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग)   2009-04-30 00:20:36 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1329653
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
327dfecd8ad2d5cb69cbf5bd14774c31  JavaScript-Beautifier-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
 Files=3, Tests=64,  0 wallclock secs ( 0.06 usr  0.02 sys +  0.24 cusr  0.03
csys =  0.35 CPU)
+ Package perl-JavaScript-Beautifier-0.04-1.fc12.noarch =>
  Provides: perl(JavaScript::Beautifier) = 0.04
  Requires: perl(base) perl(strict) perl(vars) perl(warnings)

APPROVED.

[Bug 498186] Review Request: perl-JavaScript-Beautifier - beautifier for javascript

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=498186

Marcela Maslanova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Marcela Maslanova   2009-04-30 01:52:26 EDT ---
New Package CVS Request
=======================
Package Name: perl-JavaScript-Beautifier
Short Description: beautifier for javascript
Owners: mmaslano
Branches: F-11
InitialCC: perl-sig

[Bug 498186] Review Request: perl-JavaScript-Beautifier - beautifier for javascript

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=498186

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #3 from Dennis Gilmore   2009-05-01 16:59:34 EDT ---
CVS Done

[Bug 498186] Review Request: perl-JavaScript-Beautifier - beautifier for javascript

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=498186

Marcela Maslanova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CURRENTRELEASE