[Bug 249929] New: Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

Summary: Review Request: dynagen - Dynamips Hypervisor Client
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://dev.nigelj.com/SRPMS/dynagen.spec
SRPM URL: http://dev.nigelj.com/SRPMS/dynagen-0.9.3-1.fc8.src.rpm
Description:
Dynagen is a text-based front end for Dynamips, that uses the Hypervisor 
mode for communication with Dynamips.

Dynagen can simplify building and working with virtual networks.

rpmlint etc clean

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |246150

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

------- Additional Comments From [e-mail]  2007-07-31 03:05 EST -------
Hi

This is my first review so I will do my best but I might need help :-)

At a first look:
 you should use install rather than cp to install the files
 you can change %{_mandir}/man1/dynagen.1.gz by %{name}.1.gz
 I am surprise by your %{_bindir}/* in the %files section

I will have a further look later on.

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

------- Additional Comments From [e-mail]  2007-07-31 04:49 EST -------
(In reply to comment #1)
> Hi
> This is my first review so I will do my best but I might need help :-)
> At a first look:
>  you should use install rather than cp to install the files

As there is no make, it doesn't _really_ matter, and there isn't really any 
advantages either way that I'm aware of (although I'll most likely change it 
later on).
> you can change %{_mandir}/man1/dynagen.1.gz by %{name}.1.gz

I won't do this, as it breaks the logical layout of the files section, (i.e. by 
removing all the context), plus it's not consistent with other packages 
(nothing personal, just a style thing).
> I am surprise by your %{_bindir}/* in the %files section

As there isn't a make install (where by the contents of bindir may change 
without warning), and instead I'm explicatly copying the two executable 
scripts, it's not too much of an issue in comparison to other packages, I will 
look at changing if there is anything major wrong.
> I will have a further look later on.

Please look at bug 246150 (dynamips which dynagen depends on) before reviewing 
this package.

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

------- Additional Comments From [e-mail]  2007-07-31 16:40 EST -------
First complains here :

$ rpmlint ../RPMS/noarch/dynagen-0.9.3-1.fc6.noarch.rpm 
E: dynagen non-executable-script /usr/lib/python2.4/site-packages/console.py 0644
W: dynagen spurious-executable-perm
/usr/share/doc/dynagen-0.9.3/sample_labs/all_config_options.txt
W: dynagen wrong-file-end-of-line-encoding /usr/share/doc/dynagen-0.9.3/README.txt
E: dynagen non-executable-script
/usr/lib/python2.4/site-packages/dynamips_lib.py 0644
E: dynagen wrong-script-end-of-line-encoding
/usr/lib/python2.4/site-packages/dynamips_lib.py
W: dynagen hidden-file-or-dir /usr/share/doc/dynagen-0.9.3/sample_labs/.DS_Store
E: dynagen script-without-shebang /usr/bin/configspec
W: dynagen wrong-file-end-of-line-encoding /usr/share/doc/dynagen-0.9.3/COPYING
W: dynagen wrong-file-end-of-line-encoding
/usr/share/doc/dynagen-0.9.3/docs/tutorial.htm

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249929

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]          |[e-mail]
               Flag|fedora-review?              |

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/show_bug.cgi?id=249929

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |CANTFIX

------- Additional Comments From [e-mail]  2008-06-03 02:37 EST -------
About time I closed this, doesn't meet entry requirements - closing.

[Bug 249929] Review Request: dynagen - Dynamips Hypervisor Client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dynagen - Dynamips Hypervisor Client

https://bugzilla.redhat.com/show_bug.cgi?id=249929

Bug 249929 depends on bug 246150, which changed state.

Bug 246150 Summary: Package Review: dynamips - Powerful Cisco IOS Emulator/Hypervisor
https://bugzilla.redhat.com/show_bug.cgi?id=246150

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CANTFIX