[Bug 1358956] New: Review Request: sstp-client - Secure Socket Tunneling Protocol(SSTP) Client
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
Bug ID: 1358956 Summary: Review Request: sstp-client - Secure Socket Tunneling Protocol(SSTP) Client Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mszpak@wp.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://timeoff.wsisiz.edu.pl/rpms/sstp-client/sstp-client.spec<spec info here> SRPM URL: http://timeoff.wsisiz.edu.pl/rpms/sstp-client/sstp-client-1.0.10-5.fc24.src.... Description: Secure Socket Tunneling Protocol(SSTP) Client Fedora Account System Username: szpak
This package has been orphaned and I want to bring it to live as it is required by my other package NetworkManager-sstp - bug 1229903.
I'm already a maintainer of a few Fedora packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #1 from Marcin Zajaczkowski mszpak@wp.pl --- I applied a workaround for the issue with Rpath, but there are still some fedora-review/rpmlint issues:
Rpmlint ------- Checking: sstp-client-1.0.10-5.fc24.x86_64.rpm sstp-client-devel-1.0.10-5.fc24.x86_64.rpm sstp-client-debuginfo-1.0.10-5.fc24.x86_64.rpm sstp-client-1.0.10-5.fc24.src.rpm sstp-client.x86_64: W: spelling-error %description -l en_US pptp -> PT sstp-client.x86_64: W: spelling-error %description -l en_US pon -> pin, pom, on sstp-client.x86_64: W: spelling-error %description -l en_US poff -> off, toff, poof sstp-client.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/sstpc sstp-client.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/sstpc sstp-client.x86_64: W: dangerous-command-in-%postun rm sstp-client-devel.x86_64: W: only-non-binary-in-usr-lib sstp-client.src: W: spelling-error %description -l en_US pptp -> PT sstp-client.src: W: spelling-error %description -l en_US pon -> pin, pom, on sstp-client.src: W: spelling-error %description -l en_US poff -> off, toff, poof 4 packages and 0 specfiles checked; 2 errors, 8 warnings.
E: missing-call-to-setgroups-before-setuid /usr/sbin/sstpc
It should be easy to fix, but I haven't been programming in C for years and I reported it upstream: https://sourceforge.net/p/sstp-client/discussion/1499217/thread/d1508589/
sstp-client.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/sstpc
It's strange as there is a chdir() call: https://sourceforge.net/p/sstp-client/code/200/tree/trunk/src/sstp-util.c#l3...
W: only-non-binary-in-usr-lib
There is just a symlink to .so file from the main package
W: dangerous-command-in-%postun rm
It seems to be required for clean up after %pre operations - maybe it can be simplified somehow?
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #2 from Marcin Zajaczkowski mszpak@wp.pl --- Hmm, strange thing:
Source checksums ---------------- http://downloads.sourceforge.net/project/sstp-client/sstp-client/1.0.10/sstp... : CHECKSUM(SHA256) this package : 5f9084d8544c42c806724a4e70d039d8cb7b0ea06be8ea9cc5120684d4e0d424 CHECKSUM(SHA256) upstream package : 0fa26e565c169723e288b52de47a0cb6d838450b26d404726330adde3147eb4a diff -r also reports differences
I will investigate it tomorrow.
In the meantime, feel free to make a general review of the other parts :).
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #3 from Marcin Zajaczkowski mszpak@wp.pl --- I don't why mock build returns that checksum error. The package downloaded with wget from mentioned URL has the same checksum as the tarball in the official Fedora RPM. Maybe it's only an issue on my machine...
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |lkundrak@v3.sk Flags| |fedora-review+
--- Comment #4 from Lubomir Rintel lkundrak@v3.sk --- The package indeed looks correct to me. It was in Fedora for some time and only removed recently, already meets our quality standard.
For me the pristine tarball is indeed 5f290355187e5ce0423fb7e388e65b9d; not sure what went wrong there. But it corresponds to what's in SVN as well.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- sstp-client-1.0.10-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e73d66fc7
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- sstp-client-1.0.10-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-59303cb075
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- sstp-client-1.0.10-5.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e73d66fc7
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- sstp-client-1.0.10-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-59303cb075
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- sstp-client-1.0.10-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- sstp-client-1.0.10-5.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1358956
Marcin Zajaczkowski mszpak@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-09-01 15:08:00
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla