[Bug 1888971] New: Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

Bug ID: 1888971
           Summary: Review Request: golang-github-cli-shurcool-graphql -
                    GraphQL client implementation
           Product: Fedora
           Version: 33
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-3...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-3...

Description: GraphQL client implementation

Fedora Account System Username: jdoss

[Bug 1888971] Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

Joe Doss  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1888972

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1888972
[Bug 1888972] Review Request: golang-github-shurcool-githubv4 - A client
library for accessing GitHub GraphQL API v4

[Bug 1888971] Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

Olivier Lemasle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

[Bug 1888971] Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

--- Comment #1 from Olivier Lemasle  ---
What are your plans regarding this package? Retiring it when/if
https://github.com/shurcooL/graphql/pull/57 is merged?

[Bug 1888971] Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

--- Comment #2 from Joe Doss  ---
I am going to retire it and build a the package for
https://github.com/shurcooL/graphql and switch to that one.

[Bug 1888971] Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

Olivier Lemasle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Olivier Lemasle  ---
Please note that Fedora package for the upstream github.com/shurcooL/graphql
already exists:
https://src.fedoraproject.org/rpms/golang-github-shurcool-graphql
So you will not have to build it.

However, I am not totally comfortable with packaging a fork just for one patch;
I feel it should be fixed in github-cli instead...

But it seems to conform to Fedora packaging guidelines, so it's +1:

- MIT license ok
- Spec + changelog format ok
- Naming guidelines + packaging guidelines ok
- Builds in mock ok
- Documentation ok

Rpmlint
-------
Checking:
golang-github-cli-shurcool-graphql-devel-0-0.1.20201001git0f7232a.fc34.noarch.rpm

golang-github-cli-shurcool-graphql-0-0.1.20201001git0f7232a.fc34.src.rpm
golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath
golang-github-cli-shurcool-graphql.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
golang-github-cli-shurcool-graphql-devel.noarch: W: invalid-url URL:
https://github.com/cli/shurcooL-graphql <urlopen error [Errno -3] Temporary
failure in name resolution>
golang-github-cli-shurcool-graphql-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/cli/shurcooL-graphql/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[Bug 1888971] Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-cli-shurcool-graphql

[Bug 1888971] Review Request: golang-github-cli-shurcool-graphql - GraphQL client implementation

https://bugzilla.redhat.com/show_bug.cgi?id=1888971

Joe Doss  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2020-11-06 14:24:40