[Bug 1489160] New: Review Request: f27-backgrounds - Fedora 27 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Bug ID: 1489160 Summary: Review Request: f27-backgrounds - Fedora 27 default desktop background Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: luya@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://luya.fedorapeople.org/packages/SPECS/f27-backgrounds.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/f27-backgrounds-27.0.0-1.fc26.s... Description: This package contains desktop backgrounds for the Fedora 27 default theme. Pulls in themes for GNOME, KDE, Mate, Cinnamon and Xfce desktops. Fedora Account System Username:luya
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Fedora Blocker Bugs Application blockerbugs@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |luya@fedoraproject.org Blocks| |1396703 | |(BetaFreezeException,F27Bet | |aFreezeException)
--- Comment #1 from Fedora Blocker Bugs Application blockerbugs@fedoraproject.org --- Proposed as a Freeze Exception for 27-beta by Fedora user luya using the blocker tracking app because:
Design team recently sent the wallpaper for beta. The package is ready for review and tested on https://koji.fedoraproject.org/koji/taskinfo?taskID=21693254
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1396703 [Bug 1396703] Fedora 27 Beta freeze exception bug tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1489164
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1489164 [Bug 1489164] Fedora 27 Beta backgrounds must be different from Fedora 26
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |awilliam@redhat.com Blocks|1396703 | |(BetaFreezeException,F27Bet | |aFreezeException) |
--- Comment #2 from Adam Williamson awilliam@redhat.com --- I'd rather have a tracker bug that depends on this as the blocker, because just adding the new package is not *all* that needs to happen. https://bugzilla.redhat.com/show_bug.cgi?id=1489164 . Also, this is a blocker, not an FE, because currently F27 images use the F26 backgrounds, and this breaks the release criteria.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1396703 [Bug 1396703] Fedora 27 Beta freeze exception bug tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
--- Comment #3 from Luya Tshimbalanga luya@fedoraproject.org --- Thanks for the correction.
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Robert-André Mauchin (afk until Mon 11) zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #4 from Robert-André Mauchin (afk until Mon 11) zebob.m@gmail.com --- First, thank you to all members of the design team for their great work.
Regarding this package:
- The Source0 is returning 404: https://releases.pagure.org/design/f27-backgrounds-27.0.0.tar.xz doesn't seem to exist.
- Similarly, the URL: returns an empty wiki page https://fedoraproject.org/wiki/F27_Artwork
- There's a mix of spaces and tabs in the SPEC, please choose one only and stick with it. (I prefer spaces).
- In the source archive, there are a lot of backup files included:
$find f27-backgrounds -iname "*~" f27-backgrounds/default/f26.xml~ f27-backgrounds/default/mate-backgrounds-f27.xml~ f27-backgrounds/default/mate-backgrounds-f27-animated.xml~ f27-backgrounds/default/f27.xml~ f27-backgrounds/default/f26-animated.xml~ f27-backgrounds/default/f27-animated-new.xml~ f27-backgrounds/default/f27-animated.xml~ f27-backgrounds/default/Makefile~ f27-backgrounds/default/f27-metadata.desktop.desktop~ f27-backgrounds/default/gnome-backgrounds-f27-animated.xml~ f27-backgrounds/default/gnome-backgrounds-f27.xml~
I think these file are generated as backup by Gedit, I don't think they should be included in the final archive.
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
--- Comment #5 from Luya Tshimbalanga luya@fedoraproject.org --- Here is the updated spec and srpm files - Corrected Source0 - Wiki page now exists - Tab only used - Removal of "*~" files in sources
Resulted rpmlint: rpmlint rpmbuild/SRPMS/f27-backgrounds-27.0.0-2.fc26.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=21729091
Spec URL: https://luya.fedorapeople.org/packages/SPECS/f27-backgrounds.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/f27-backgrounds-27.0.0-2.fc26.s...
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Robert-André Mauchin (afk until Mon 11) zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #6 from Robert-André Mauchin (afk until Mon 11) zebob.m@gmail.com --- The requires should be in the form:
Requires: %{name}-base%{_isa} = %{version}-%{release}
You forgot the %{_isa} part.
I accept the 📦 but please fix this before import.
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com
--- Comment #7 from Neal Gompa ngompa13@gmail.com ---
You forgot the %{_isa} part.
No %{_isa} is required for noarch packages. In fact, it should *not* be there.
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
--- Comment #8 from Luya Tshimbalanga luya@fedoraproject.org --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
--- Comment #9 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/f27-backgrounds. You may commit to the branch "f27" in about 10 minutes.
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- f27-backgrounds-27.0.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fee0766883
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- desktop-backgrounds-27.0.0-1.fc27 f27-backgrounds-27.0.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fee0766883
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- desktop-backgrounds-27.0.0-1.fc27, f27-backgrounds-27.0.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fee0766883
https://bugzilla.redhat.com/show_bug.cgi?id=1489160
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-09-16 21:29:34
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- desktop-backgrounds-27.0.0-1.fc27, f27-backgrounds-27.0.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com