[Bug 466879] New: Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

https://bugzilla.redhat.com/show_bug.cgi?id=466879

Summary: Package Review: perl-Crypt-GeneratePassword - Generate
                    secure random pronounceable passwords
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
            Blocks: 452450
   Estimated Hours: 0.0
    Classification: Fedora

Spec:
http://miroslav.suchy.cz/fedora/perl-Crypt-GeneratePassword/perl-Crypt-Gener...
SRPM:
http://miroslav.suchy.cz/fedora/perl-Crypt-GeneratePassword/perl-Crypt-Gener...
Description:
Crypt::GeneratePassword generates random passwords that are (more or less)
pronounceable. Unlike Crypt::RandPasswd, it doesn't use the FIPS-181 NIST
standard, which is proven to be insecure. It does use a similar interface,
so it should be a drop-in replacement in most cases.

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=879667

$ rpmlint perl-Crypt-GeneratePassword-0.03-3.fc10.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint perl-Crypt-GeneratePassword-0.03-3.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

Miroslav Suchy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

Miroslav Suchy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Jason Tibbitts   2008-10-17 16:29:18 EDT ---
Not much to say here, really.  I guess I could point out that most people tend
to prefer calling iconv over patching to fix utf8 issues, but that's up to you.

* source files match upstream:
   4274d1aedcdd6e5ad54f417390dae75bc9231726c7431ab1aee40a507b3748c3  
   Crypt-GeneratePassword-0.03.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Crypt::GeneratePassword) = 0.03
   perl-Crypt-GeneratePassword = 0.03-3.fc10
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(Exporter)
   perl(strict)
   perl(vars)

* %check is present and the one test passes.  It's about the minimal useful
test 
   suite you can get for a Perl module, but it's there.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

Miroslav Suchy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Miroslav Suchy   2008-10-21 08:21:59 EDT ---
New Package CVS Request
=======================
Package Name: perl-Crypt-GeneratePassword
Short Description: Generate secure random pronounceable passwords
Owners: msuchy
Branches: devel F-9 F-10 EL-4 EL-5 
InitialCC:
Cvsextras Commits: yes

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

--- Comment #3 from Huzaifa S. Sidhpurwala   2008-10-22 06:34:42 EDT ---
cvs done

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

Huzaifa S. Sidhpurwala  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

--- Comment #4 from Jason Tibbitts   2008-12-02 18:25:14 EDT ---
Any reason this ticket is still open?

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

--- Comment #5 from Miroslav Suchy   2008-12-03 06:33:41 EDT ---
Hmm, there is one problem.
We both missed that is package is already included:
https://bugzilla.redhat.com/show_bug.cgi?id=452458
But it now bring the situation that I'm owner of F-10, F-9, EL-4 and  EL-5
branch. And nigelj is owner of devel and F-8. 
https://admin.fedoraproject.org/pkgdb/packages/name/perl-Crypt-GeneratePassw...

[Bug 466879] Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=466879

Miroslav Suchy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |DUPLICATE

--- Comment #6 from Miroslav Suchy   2008-12-03 07:18:57 EDT ---

*** This bug has been marked as a duplicate of 452458 ***