[Bug 204561] New: Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

Summary: Review Request: python-pyspf - Sender Policy Framework
                    library for Python.
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf.spec
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf-1.7-1.noarch.rpm
Description: A Python library for doing SPF (Sender Policy Framework) lookups.  This depends on python-pydns (just submitted).

This is my second package, I need a sponsor.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
  BugsThisDependsOn|                            |204560

------- Additional Comments From [e-mail]  2006-08-29 21:48 EST -------
(Adding bug dependency for the python-pydns review request.)

On a brief looking-over, your Source0 should be a full URL to the source tarball
(or if that does not make, a brief explanation as to why it is not a full URL as
a comment).

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-08-29 22:52 EST -------
I'd be happy to take a look at this. 
In addition to the item from comment #1, the SRPM URL is pointing to the noarch 
package, not the src.rpm. Update those and I can do a formal review.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

------- Additional Comments From [e-mail]  2006-08-30 06:19 EST -------
I've updated the URL, and have pushed new versions up.

Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf.spec
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf-1.7-2.src.rpm

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

------- Additional Comments From [e-mail]  2006-08-30 22:49 EST -------
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
OK - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
eabc78b67018efdfea68ae9b9d545e80  pyspf-1.7.tar.gz
eabc78b67018efdfea68ae9b9d545e80  pyspf-1.7.tar.gz.1
OK - Package compiles and builds on at least one arch.
See below - BuildRequires correct
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.
SHOULD Items:
See below - Should include License or ask upstream to include it.
OK - Should build in mock.

Issues:

1. There seems to be some confusion on the license on this package...
You have 'Python License' in the spec, but the package lists
'Python Software Foundation License' in several places. Most confusingly,
the spfquery.py file says it's released under the GPL:

PKG-INFO:License: Python Software Foundation License
PKG-INFO:Classifier: License :: OSI Approved :: Python Software Foundation 
License
README:License: Python Software Foundation License
setup.py:      license='Python Software Foundation License',
setup.py:       'License :: OSI Approved :: Python Software Foundation License',
spfquery.py:# This code is under the GNU General Public License.  See COPYING 
for details.

2. rpmlint has some output:

W: python-pyspf summary-ended-with-dot Python module and programs for SPF 
(Sender Policy Framework).

suggest: remove the . at the end of summary.

W: python-pyspf incoherent-version-in-changelog 1.7-1 1.7-2.fc6

suggest: add changelog for -2 release.

W: python-pyspf invalid-license Python License

suggestion: see issue 1.

E: python-pyspf non-executable-script /usr/lib/python2.4/site-packages/spf.py 
0644

spf.py has a #! for python, so it should either be 755 or (more likely) have
the top line simply removed so it can be used as a python module instead of a 
script.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

------- Additional Comments From [e-mail]  2006-08-31 02:04 EST -------
Thanks for the review, Kevin.  I've got a corrected version at:

Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf.spec
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf-1.7-3.src.rpm

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

------- Additional Comments From [e-mail]  2006-08-31 17:33 EST -------
This version has a changelog for the -2 release as well.

Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf.spec
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf-1.7-4.src.rpm

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

------- Additional Comments From [e-mail]  2006-08-31 18:01 EST -------
According to an e-mail from the author, the license for spfquery will be changed
to the Python license:

From: "Stuart D. Gathman" 
Date: Thu, 31 Aug 2006 11:05:12 -0400 (EDT)
To: Sean Reifschneider

On Wed, 30 Aug 2006, Sean Reifschneider wrote:
> In pyspf 1.7, spfquery.py says it's GPLed, but the PKG-INFO file says it's
> under the Python Software Foundation License.

Spfquery is by me.  It was originally for pymilter - which is GPL
due to the original author.  I will change it to Python license.
I would like to change pymilter as well, with the original authors
permission.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

------- Additional Comments From [e-mail]  2006-08-31 21:40 EST -------
ok. 
Almost everything is fixed up, but I am still getting the rpmlint: 
E: python-pyspf non-executable-script /usr/lib/python2.4/site-packages/spf.py 
0644

I don't think the construct you are using is working right. 
How about something like:

sed -i -e 's|^#!/usr/bin/env python$||' %{python_sitelib}/spf.py

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

------- Additional Comments From [e-mail]  2006-08-31 22:09 EST -------
That does it, thanks Kevin.

Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf.spec
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/python-pyspf-1.7-5.src.rpm

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-08-31 22:22 EST -------
Excellent. That looks good to go... this package is APPROVED.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-09-01 15:09 EST -------
The package was imported and built.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

Bug 204561 depends on bug 204560, which changed state.

Bug 204560 Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-06-11 19:14 EST -------
Package Change Request
======================
Package Name: python-pyspf
New Branches: EL-5

Want to get it into EPEL as well.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-06-11 19:36 EST -------
branch done.

[Bug 204561] Review Request: python-pyspf - Sender Policy Framework library for Python.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-pyspf - Sender Policy Framework library for Python.

https://bugzilla.redhat.com/show_bug.cgi?id=204561

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide