[Bug 253692] New: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253692

Summary: Review Request: compiz-fusion - Collection of Compiz
                    Fusion plugins for Compiz
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://tgmweb.at/gadllah/compiz-fusion.spec
SRPM URL: http://tgmweb.at/gadllah/compiz-fusion-0.5.2-1.fc7.src.rpm
Description:
The Compiz Fusion Project brings 3D desktop visual effects that improve
usability of the X Window System and provide increased productivity
though plugins and themes contributed by the community giving a
rich desktop experience

NOTE:
This package is rawhide only.

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |253693
              nThis|                            |

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253692

------- Additional Comments From [e-mail]  2007-08-22 05:29 EST -------
fixed a gconf bug, new urls:
http://tgmweb.at/gadllah/compiz-fusion.spec
http://tgmweb.at/gadllah/compiz-fusion-0.5.2-2.fc7.src.rpm

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253692

------- Additional Comments From [e-mail]  2007-08-24 03:54 EST -------
New fixed package:
http://tgmweb.at/gadllah/compiz-fusion.spec
http://tgmweb.at/gadllah/compiz-fusion-0.5.2-3.fc7.src.rpm

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253692

------- Additional Comments From [e-mail]  2007-08-24 05:16 EST -------
Some small fixes:
http://tgmweb.at/gadllah/compiz-fusion.spec
http://tgmweb.at/gadllah/compiz-fusion-0.5.2-4.fc7.src.rpm

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

------- Additional Comments From [e-mail]  2007-09-05 10:37 EST -------
Only tried to rebuild on dist-f8 and it seems okay.
http://koji.fedoraproject.org/koji/taskinfo?taskID=148783

However, as I am now reviewing some other packages, currently
I have no time to review this package. I hope someone will review this.

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

------- Additional Comments From [e-mail]  2007-09-14 16:33 EST -------
The package looks fine, except the %post, %pre, and %preun scriptlets.

1) Do you really intend on doing --makefile-install-rule in all three places? 
Probably not.
2) You should avoid difficult-to-maintain long lists of plugins that are
redundant in the three scriptlets.  You could do something like the compiz
package with:

%define         core_plugins    blur clone cube dbus decoration fade ini inotify
minimize move

for f in %{core_plugins}; do
  echo %{_libdir}/compiz/lib$f.so
  echo %{_datadir}/compiz/$f.xml
done >> core-files.txt

Then use a loop within the scriptlets to install or uninstall the schemas.
export GCONF_CONFIG_SOURCE=`/usr/bin/gconftool-2 --get-default-source`
for f in %{core_plugins} %{gnome_plugins} core; do
  gconftool-2 --makefile-install-rule
%{_sysconfdir}/gconf/schemas/compiz-$f.schemas >& /dev/null || :
done

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

------- Additional Comments From [e-mail]  2007-09-15 04:03 EST -------
Fixed in:
http://tgmweb.at/gadllah/compiz-fusion.spec
http://tgmweb.at/gadllah/compiz-fusion-0.5.2-5.fc7.src.rpm

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-09-17 17:15 EST -------
Approved.

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-09-18 12:00 EST -------
New Package CVS Request
=======================
Package Name: compiz-fusion
Short Description: Collection of Compiz Fusion plugins for Compiz
Owners: drago01, krh
Branches: devel
InitialCC: 
Cvsextras Commits: no

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

https://bugzilla.redhat.com/show_bug.cgi?id=253692

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=253692

leigh scott  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #9 from leigh scott  2011-04-01 11:46:37 EDT ---
Hi Adel,

Is it ok for me to request a epel6 branch?

https://bugzilla.redhat.com/show_bug.cgi?id=677365

Thanks

Leigh

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=253692

--- Comment #10 from Adel Gadllah  2011-04-01 12:17:17 EDT ---
(In reply to comment #9)
> Hi Adel,
>
> Is it ok for me to request a epel6 branch?
>
> https://bugzilla.redhat.com/show_bug.cgi?id=677365

Sure.

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=253692

--- Comment #11 from leigh scott  2011-04-01 13:20:48 EDT ---
(In reply to comment #10)
> (In reply to comment #9)
> > Hi Adel,
> >
> > Is it ok for me to request a epel6 branch?
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=677365
>
> Sure.

Thank you

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=253692

leigh scott  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #12 from leigh scott  2011-04-01 13:21:27 EDT ---
Package Change Request
======================
Package Name: compiz-fusion
New Branches: el6
Owners: leigh123linux

[Bug 253692] Review Request: compiz-fusion - Collection of Compiz Fusion plugins for Compiz

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=253692

--- Comment #13 from Jason Tibbitts  2011-04-03 23:51:23 EDT ---
Git done (by process-git-requests).