[Bug 200374] New: Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

Summary: Review Request: qstat - Real-time Game Server Status for
                    Quake servers
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/qstat.spec
SRPM URL: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/qstat-2.10-2.src.rpm
Description:
QStat is a command-line program that gathers real-time statistics
from Internet game servers. Most supported games are of the first
person shooter variety (Quake, Half-Life, etc)

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-27 17:08 EST -------
A few small points before I get to a full review:

You don't need the check for "/" when you clean the buildroot in %install and
%clean.  A simple rm -rf will suffice:
rm -rf %{buildroot}

The -n %{name}-%{version} is unnecessary.  %setup already uses this as a default.

The %attr statements for qstat.cfg and the qstat binary are also not necessary
as these permissions/ownership are already used.

qstat can be used for more than just quake servers, so remove 'quake' from the
summary line.  You could replace it with 'FPS game' instead.

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

------- Additional Comments From [e-mail]  2006-07-28 09:14 EST -------
Updated package here:
ftp://andriy.asplinux.com.ua/pub/people/andy/extras/qstat-2.10-3.src.rpm

* Fri Jul 28 2006 Andy Shevchenko  2.10-3
- drop check for "/" in install and clean sections
- drop -n for setup macro
- do not use attr macro in files section
- qstat can be used not only for Quake, so change Summary

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

------- Additional Comments From [e-mail]  2006-07-29 15:47 EST -------
GOOD
====
* rpmlint output clean
* Package and spec file name named appropriately
* Artistic license ok, license file included
* File matches upstream:
  ac3ce3dbed5248bd5738a4968460880e  qstat-2.10.tar.gz
* Spec file legible and in Am. English
* Builds and packages in mock on FC4, FC5, and FC5, both i386 and x86_64
* Package provides list is sane
* No BR: necessary
* No locales
* No shared libs
* Not relocatable
* Does not create any directories that it should own
* No duplicate %files
* File permissions ok
* build root cleaned in %install and %clean as necessary
* Contains code, not content
* No need for -doc or -devel subpackages
* No .la files created
* Not a gui app; no .desktop file needed

MUSTFIX
=======
* %doc contains some unnecessary files that should be removed:
  COMPILE.txt
  Makefile*
  template/Makefile*

NOTES
=====
* There are a number of compiler warnings about pointer signedness that appear
harmless.  If you feel inclined, you could report these upstream.
qstat.c:2912: warning: pointer targets in passing argument 6 of 'recvfrom'
differ in signedness

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

------- Additional Comments From [e-mail]  2006-07-31 04:22 EST -------
Updated package here:
ftp://andriy.asplinux.com.ua/pub/people/andy/extras/qstat-2.10-4.src.rpm

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-31 12:37 EST -------
All MUSTFIX items fixed.

APPROVED

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-08-01 10:49 EST -------
Injected into CVS.

Thanks for review.

[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers

https://bugzilla.redhat.com/show_bug.cgi?id=200374

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide