https://bugzilla.redhat.com/show_bug.cgi?id=2103400
Bug ID: 2103400 Summary: Review Request: magicmirror - Modular smart mirror platform Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/magicmirror/magicmirror.spec SRPM URL: https://dcavalca.fedorapeople.org/review/magicmirror/magicmirror-2.20.0-1.fc...
Description: MagicMirror² is an open source modular smart mirror platform. With a growing list of installable modules, the MagicMirror² allows you to convert your hallway or bathroom mirror into your personal assistant.
This package contains the server version of MagicMirror², which is meant to be accessed via a browser.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
--- Comment #1 from Davide Cavalca dcavalca@fb.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=88997683
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Blocks| |2103401, 2103402, 2103403
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2103401 [Bug 2103401] Review Request: magicmirror-module-airnow - MagicMirror² module to show air quality based on the US AirNow API https://bugzilla.redhat.com/show_bug.cgi?id=2103402 [Bug 2103402] Review Request: magicmirror-module-singlestock - MagicMirror² module that displays the stock price of a single company https://bugzilla.redhat.com/show_bug.cgi?id=2103403 [Bug 2103403] Review Request: magicmirror-module-onthisday - Display historical events on your MagicMirror
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
--- Comment #2 from Davide Cavalca dcavalca@fb.com --- The nm tarballs for this were generated with nodejs-packaging-bundler with these two PRs applied: https://src.fedoraproject.org/rpms/nodejs-packaging/pull-request/9 and https://src.fedoraproject.org/rpms/nodejs-packaging/pull-request/10.
MagicMirror also includes an Electron wrapper (meant to be used as a fullscreen app on kiosk-like devices). This isn't packaged for the time being as we don't currently have Electron in Fedora; the corresponding tests are also skipped.
I've included some convenience macros to make it easier to package MagicMirror modules, and there are three modules using them for review as well. Feedback welcome, as it's my first time writing packaging macros for public use.
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |michel@michel-slm.name Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |michel@michel-slm.name
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Taking this review
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- There's a lot of rpmlint warnings and errors, can they be addressed?
- scripts should be 755 - non-scripts with 755 should be 644 - hidden files or dir... unfortunately some of them are actually needed like .bin
Let me filter out issues in the bundled node modules and see if there are others that need fixing
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
--- Comment #5 from Michel Alexandre Salim michel@michel-slm.name --- magicmirror.noarch: W: only-non-binary-in-usr-lib magicmirror.spec: W: invalid-url Source2: MagicMirror-2.20.0-nm-dev.tgz magicmirror.spec: W: invalid-url Source1: MagicMirror-2.20.0-nm-prod.tgz magicmirror.noarch: W: hidden-file-or-dir /usr/lib/node_modules/magicmirror/node_modules/.bin magicmirror.noarch: W: hidden-file-or-dir /usr/lib/node_modules/magicmirror/vendor/node_modules/.bin 2 packages and 0 specfiles checked; 29 errors, 670 warnings, 29 badness; has taken 2.6 s
Remaining issues look fine
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #6 from Michel Alexandre Salim michel@michel-slm.name --- Mostly LGTM, APPROVED. Consider moving the macros to magicmirror-rpm-macros and make it require rpm
Issues: Rpmlint ------- Checking: magicmirror-2.20.0-1.fc39.noarch.rpm magicmirror-2.20.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp23poqw10')] checks: 31, packages: 2
magicmirror.noarch: E: zero-length /usr/lib/node_modules/magicmirror/node_modules_prod/mime/.npmignore magicmirror.noarch: E: zero-length /usr/lib/node_modules/magicmirror/node_modules_prod/node-fetch/node_modules/tr46/lib/.gitkeep magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/@types/component-emitter/package.json magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/@types/cookie/package.json magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/@types/cors/package.json magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/@types/node/package.json magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/esrecurse/package.json magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/es5/uri.all.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/es5/uri.all.min.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/index.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/regexps-iri.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/regexps-uri.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/schemes/http.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/schemes/https.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/schemes/mailto.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/schemes/urn-uuid.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/schemes/urn.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/schemes/ws.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/schemes/wss.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/uri.js.map magicmirror.noarch: E: script-without-shebang /usr/lib/node_modules/magicmirror/node_modules_prod/uri-js/dist/esnext/util.js.map
======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 266 files have unknown license. Detailed output of licensecheck in
/home/michel/src/fedora/reviews/davide/2103400-magicmirror/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/rpm/macros.d, /usr/lib/rpm => actually owned by rpm, please list that as a dependency or put that file in magicmirror-devel which depends on rpm [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [!]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in magicmirror [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/magicmirror
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8f87c7f2d9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8f87c7f2d9
https://bugzilla.redhat.com/show_bug.cgi?id=2103400
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-02-12 23:48:12
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8f87c7f2d9 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com