[Bug 1607675] New: Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675

            Bug ID: 1607675
           Summary: Review Request: castget - A command-line podcast
                    downloader
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: esm(a)logic.net
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~logic/castget/castget.spec
SRPM URL: https://fedorapeople.org/~logic/castget/castget-1.2.4-1.fc29.src.rpm
Description: castget is a simple, command-line based RSS enclosure downloader.
It is primarily intended for automatic, unattended downloading of podcasts.
Fedora Account System Username: logic

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=28552046

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675

Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebob.m(a)gmail.com
           Assignee|nobody(a)fedoraproject.org    |zebob.m(a)gmail.com
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; ---
Package approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)",
"Unknown or
     generated". 24 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/castget/review-
     castget/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in castget-
     debuginfo , castget-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: castget-1.2.4-1.fc29.x86_64.rpm
          castget-debuginfo-1.2.4-1.fc29.x86_64.rpm
          castget-debugsource-1.2.4-1.fc29.x86_64.rpm
          castget-1.2.4-1.fc29.src.rpm
castget.x86_64: W: spelling-error Summary(en_US) downloader -> downloaded, down
loader, down-loader
castget.x86_64: W: spelling-error %description -l en_US downloader ->
downloaded, down loader, down-loader
castget.x86_64: W: spelling-error %description -l en_US podcasts -> podcast,
pod casts, pod-casts
castget.src: W: spelling-error Summary(en_US) downloader -> downloaded, down
loader, down-loader
castget.src: W: spelling-error %description -l en_US downloader -> downloaded,
down loader, down-loader
castget.src: W: spelling-error %description -l en_US podcasts -> podcast, pod
casts, pod-casts
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675



--- Comment #2 from Gwyn Ciesla <limburgher(a)gmail.com&gt; ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/castget

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675



--- Comment #3 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
castget-1.2.4-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-aeb0388a07

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA



--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
castget-1.2.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-9fb80f382e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675



--- Comment #4 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
castget-1.2.4-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-9fb80f382e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675



--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
castget-1.2.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-9fb80f382e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675



--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
castget-1.2.4-1.fc28 has been pushed to the Fedora 28 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-aeb0388a07

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2018-08-03 16:46:18



--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
castget-1.2.4-1.fc28 has been pushed to the Fedora 28 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1607675] Review Request: castget - A command-line podcast downloader

https://bugzilla.redhat.com/show_bug.cgi?id=1607675



--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
castget-1.2.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component