https://bugzilla.redhat.com/show_bug.cgi?id=1708875
Bug ID: 1708875 Summary: Review Request: python-tmuxp - Tmux session manager Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: i.gnatenko.brain@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-tmuxp.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-tmuxp-1.5.1-1.fc31... Description: Tmux session manager. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
--- Comment #3 from Igor Gnatenko i.gnatenko.brain@gmail.com --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-tmuxp.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-tmuxp-1.5.1-1.fc31...
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- This package doesn't follow the Fedora Python packaging guidelines at all, since it doesn't produce a python3-tmuxp subpackage where the stuff actually lives. Please fix that.
Also, please add a comment about why you're removing the upper constraint on the click dependency.
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
--- Comment #5 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-tmuxp
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- Review notes:
[x] Follows Fedora Packaging Guidelines [x] Follows packaging guidelines for Python [x] Package builds and installs correctly [x] Package follows naming guidelines
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-kaptan-0.5.12-1.fc30 python-libtmux-0.8.1-1.fc30 python-tmuxp-1.5.1-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-72cc996e43
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-kaptan-0.5.12-1.fc30, python-libtmux-0.8.1-1.fc30, python-tmuxp-1.5.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-72cc996e43
https://bugzilla.redhat.com/show_bug.cgi?id=1708875
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-06-09 00:28:26
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-kaptan-0.5.12-1.fc30, python-libtmux-0.8.1-1.fc30, python-tmuxp-1.5.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org