[Bug 192603] New: Review Request: openalpp - Object Oriented version of OpenAL

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192603

Summary: Review Request: openalpp - Object Oriented version of
                    OpenAL
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://tkmame.retrogames.com/fedora-extras/openalpp.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/openalpp-20060405-2.src.rpm

Description:
Written in C++, makes OpenAL so much more accessible. Compare openalpp to a
scenegraph for OpenGL.

[Bug 192603] Review Request: openalpp - Object Oriented version of OpenAL

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openalpp - Object Oriented version of OpenAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192603

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]

------- Additional Comments From [e-mail]  2006-05-29 02:01 EST -------
Claiming this one before Mike (wart) does it, so that I actually get a chance to
give some reviews back for all the reviews you have been doing for me :)

Dunno when I have the time todo the actual review though, might take a couple of
days (but no longer).

[Bug 192603] Review Request: openalpp - Object Oriented version of OpenAL

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openalpp - Object Oriented version of OpenAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192603

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-05-29 04:55 EST -------
MUST:
=====
* rpmlint output is: 
 W: openalpp-devel no-documentation
 No problem here.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (LGPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* ldconfig properly called for shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* proper -devel package needed
* .la files not packaged
* no gui -> no .desktop file required

MUST fix:
=========
* Group: for the base package is wrong it should be:
 "System Environment/Libraries"

Should fix:
===========
* Why patch 3330 ???

[Bug 192603] Review Request: openalpp - Object Oriented version of OpenAL

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openalpp - Object Oriented version of OpenAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192603

------- Additional Comments From [e-mail]  2006-05-30 15:48 EST -------
Spec URL: http://tkmame.retrogames.com/fedora-extras/openalpp.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/openalpp-20060405-3.src.rpm

%changelog
* Tue May 30 2006 Christopher Stone  20060405-3
- Fix Group
- Fix patch number

The debian guys added that patch to the spec file, I'm not sure why they chose
3330, I've changed it back to just patch0.  Group has also been fixed.  Thanks
for the review!

I'm not sure if you noticed, but I did approve the xgalaga package a week ago.

[Bug 192603] Review Request: openalpp - Object Oriented version of OpenAL

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openalpp - Object Oriented version of OpenAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192603

------- Additional Comments From [e-mail]  2006-05-31 03:08 EST -------
All problems fixed -> approved!
> I'm not sure if you noticed, but I did approve the xgalaga package a week ago.

No I didn't notice, this must have fallen through the cracks, thanks for the
headsup.

[Bug 192603] Review Request: openalpp - Object Oriented version of OpenAL

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openalpp - Object Oriented version of OpenAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192603

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

[Bug 192603] Review Request: openalpp - Object Oriented version of OpenAL

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openalpp - Object Oriented version of OpenAL

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192603

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE