Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: fped - A footprint editor used by openmoko developers
https://bugzilla.redhat.com/show_bug.cgi?id=526303
Summary: Review Request: fped - A footprint editor used by openmoko developers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: chitlesh@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://chitlesh.fedorapeople.org/RPMS/fped.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/fped-0-1.r5664.fc11.src.rpm Description:
fped is an editor that allows the interactive creation of footprints of electronic components. Footprint definitions are stored in a text format that resembles a programming language.
The language is constrained such that anything that can be expressed in the textual definition also has a straightforward equivalent operation that can be performed through the GUI.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #1 from Chitlesh GOORAH chitlesh@gmail.com 2009-09-29 14:07:19 EDT ---
This package supports openmoko hardware development and helps those developers get a one click platform for their hardware design. Coupled with Fedora's kicad and this package, the openmoko developers can now work with
svn co https://svn.openmoko.org/trunk/gta02-core/ cd gta02-core/ make update make sch
instead of this time consuming process http://svn.openmoko.org/trunk/gta02-core/docs/GETTING-STARTED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #2 from Chitlesh GOORAH chitlesh@gmail.com 2009-09-29 14:09:59 EDT --- scratch build : https://koji.fedoraproject.org/scratch/chitlesh/task_1717189/
Simple Test : fped /usr/share/doc/fped-0/footprints/fbga.fpd
Documentation firefox /usr/share/doc/fped-0/gui.html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com 2009-09-30 04:45:30 EDT --- I'll review it shortly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2009-09-30 08:09:04 EDT --- Few notes:
* Since it is a svn snapshot, please add "0." to Relese. E.g.
Release: 0.1.r5664%{?dist}
* Please, provide exact instructions on how to build Source0. E.g. something like this:
# svn export -r 5664 http://svn.openmoko.org/trunk/eda/fped fped-0 # tar cjf fped-0.tar.bz fped-0 Source0: %{name}-%{version}.tar.bz2
Other things looks sane.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #5 from Chitlesh GOORAH chitlesh@gmail.com 2009-09-30 08:24:16 EDT --- Updated Spec URL: http://chitlesh.fedorapeople.org/RPMS/fped.spec SRPM URL: http://chitlesh.fedorapeople.org/RPMS/fped-0-0.1.r5664.fc11.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Peter Lemenkov lemenkov@gmail.com 2009-09-30 08:46:49 EDT --- Oh, another small note - since you're now using %{name}-${version}.tar.bz2 as the Source0, you don't need to add "-n %{name}" to "%setup -q". Please, remove it.
Assuming, that you'll do it, here is my
REVIEW:
+ rpmlint is silent. + The package is named according to the Package Naming Guidelines . + The spec file name matches the base package %{name}, in the format %{name}.spec . + The package meets the Packaging Guidelines . + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source, as provided in the spec URL.
[petro@Sulaco BUILD]$ diff -ru fped fped-0/ [petro@Sulaco BUILD]$
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. + The package does NOT bundle copies of system libraries. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. | Everything, the package includes as %doc, does not affect the runtime of the application. + The package does not own files or directories already owned by other packages. + All filenames in the packages are valid UTF-8.
APPROVED
(assuming, that you'll fix the %build section).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
Chitlesh GOORAH chitlesh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Chitlesh GOORAH chitlesh@gmail.com 2009-09-30 09:00:46 EDT --- Thanks Peter.
New Package CVS Request ======================= Package Name: fped Short Description: A footprint editor used by openmoko developers Owners: chitlesh Branches: F-10 F-11 F-12 EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2009-09-30 19:46:18 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-10-01 01:36:27 EDT --- fped-0-0.1.r5664.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/fped-0-0.1.r5664.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-10-01 01:36:32 EDT --- fped-0-0.1.r5664.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/fped-0-0.1.r5664.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-10-03 14:58:48 EDT --- fped-0-0.1.r5664.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |0-0.1.r5664.fc10 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-10-03 15:00:10 EDT --- fped-0-0.1.r5664.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526303
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0-0.1.r5664.fc10 |0-0.1.r5664.fc11
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla