[Bug 1288651] New: Review Request: OpenIGTLink

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Bug ID: 1288651
           Summary: Review Request: OpenIGTLink
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
SRPM URL:

Description:

The OpenIGTLink Library is a reference implementation of OpenIGTLink protocol.
It is required to build 3D-Slicer that I'm going to package.

OpenIGTLink is a network communication protocol specifically designed and
developed for research on image-guided and computer-assisted interventions. It
provides a standardized mechanism for communications among computers and
devices in operating rooms (OR) for a wide variety of image-guided therapy
(IGT) applications. Examples of such applications include:

- Stereotactic surgical guidance using optical position sensor and medical
image visualization software
- Intraoperative image guidance using real-time MRI and medical image
visualization software
- Robot-assisted interventions using robotic devices and surgical planning
software

OpenIGTLink is a set of messaging formats and rules (protocol) used for data
exchange on a local area network (LAN).

[Bug 1288651] Review Request: OpenIGTLink

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

--- Comment #1 from Dmitry Mikhirev  ---
I'm sorry, forgot to paste URLs:

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/OpenIGTLink....
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1288651] Review Request: OpenIGTLink

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1276941 (fedora-neuro)
              Alias|                            |OpenIGTLink

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug

[Bug 1288651] Review Request: OpenIGTLink - OpenIGTLink network communication protocol implementation

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Review Request: OpenIGTLink |Review Request: OpenIGTLink
                   |                            |- OpenIGTLink network
                   |                            |communication protocol
                   |                            |implementation

[Bug 1288651] Review Request: OpenIGTLink - OpenIGTLink network communication protocol implementation

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1288651] Review Request: OpenIGTLink - OpenIGTLink network communication protocol implementation

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
The name should be lowercase
[https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming],
it's hard to remember (or type) or those mixed-case letters.

You could use a single doc directory:
%global _docdir_fmt %{name}

Don't repeat the package name in summary. It's also better to drop the article,
listings look better without.

I don't see any issues otherwise.

[Bug 1288651] Review Request: OpenIGTLink - OpenIGTLink network communication protocol implementation

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

--- Comment #3 from Dmitry Mikhirev  ---
> The name should be lowercase

I hate mixed-case letters too, but the upstream always refers to this library
as OpenIGTLink, like in ORBit example on the wiki page. The github repository
(and source tarball archived from there) is also named in mixed-case.
> Don't repeat the package name in summary.

It is not a package name, it's a protocol name. Shouldn't the package summary
for protocol implementation include the protocol name? Really, I don't know
what to write there if not this...

[Bug 1288651] Review Request: OpenIGTLink - OpenIGTLink network communication protocol implementation

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Dmitry Mikhirev from comment #3)
> > The name should be lowercase
>
> I hate mixed-case letters too, but the upstream always refers to this
> library as OpenIGTLink, like in ORBit example on the wiki page. The github
> repository (and source tarball archived from there) is also named in
> mixed-case.

That's fine. You should use capitalized name in the description and other docs.
Just the package name should be lowercase.
> > Don't repeat the package name in summary.
>
> It is not a package name, it's a protocol name. Shouldn't the package
> summary for protocol implementation include the protocol name? Really, I
> don't know what to write there if not this...

OK, if the package name will be lowercase, it might make more sense to repeat
the protocol name. Maybe Summary: implementation of the OpenIGTLink network
protocol ?

[Bug 1288651] Review Request: OpenIGTLink - OpenIGTLink network communication protocol implementation

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

--- Comment #5 from Dmitry Mikhirev  ---
Thank you! I fixed evrything as you adviced.

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/openigtlink....
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...

[Bug 1288651] Review Request: openigtlink - Implementation of the OpenIGTLink network communication protocol

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
            Summary|Review Request: OpenIGTLink |Review Request: openigtlink
                   |- OpenIGTLink network       |- Implementation of the
                   |communication protocol      |OpenIGTLink network
                   |implementation              |communication protocol
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
+ license is acceptable (BSD)
+ license file is present, %license is used
+ name is correct
+ scriptlets are OK
+ builds and installs fine
+ provides and requires look fine
+ recent version (git)
+ %check is present

Package is APPROVED.

[Bug 1288651] Review Request: openigtlink - Implementation of the OpenIGTLink network communication protocol

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/openigtlink

[Bug 1288651] Review Request: openigtlink - Implementation of the OpenIGTLink network communication protocol

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288651

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2016-02-02 16:10:57