[Bug 2330715] New: Review Request: rust-assert2 - ssert!(...) and check!(...) macros inspired by Catch2, now with diffs!
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
Bug ID: 2330715 Summary: Review Request: rust-assert2 - ssert!(...) and check!(...) macros inspired by Catch2, now with diffs! Product: Fedora Version: 41 OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: solomoncyj@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-ra...
https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-ra...
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2330713
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2330713 [Bug 2330713] Review Request: serial2 - Cross platform serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/as | |sert2
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8347442 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2330716
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2330716 [Bug 2330716] Review Request: rust-assert2-macros - Procedural macros for assert2
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2359651
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2359651 [Bug 2359651] Review Request: rust-textdistance - Lots of algorithms to compare how similar two sequences are
https://bugzilla.redhat.com/show_bug.cgi?id=2330715 Bug 2330715 depends on bug 2330716, which changed state.
Bug 2330716 Summary: Review Request: rust-assert2-macros - Procedural macros for assert2 https://bugzilla.redhat.com/show_bug.cgi?id=2330716
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(solomoncyj@gmail. | |com) CC| |code@musicinmybrain.net
--- Comment #2 from Ben Beasley code@musicinmybrain.net --- The COPR build has been garbage-collected, and the spec and SRPM links now give 404 errors, so this is not reviewable.
If you are still working on this, could you please provide updated links?
You might consider using something like https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org to avoid the problem of COPR builds disappearing before you find a reviewer.
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rust-assert2 - ssert!(...) |rust-assert2 - |and check!(...) macros |assert!(...) and |inspired by Catch2, now |check!(...) macros inspired |with diffs! |by Catch2, now with diffs!
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rust-assert2 - |rust-assert2 - |assert!(...) and |Assert!(...) and |check!(...) macros inspired |check!(...) macros inspired |by Catch2, now with diffs! |by Catch2, now with diffs!
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(solomoncyj@gmail. | |com) |
--- Comment #3 from solomoncyj@gmail.com --- https://solomoncyj.fedorapeople.org/reviews/rust-assert2/rust-assert2-0.3.16...
https://solomoncyj.fedorapeople.org/reviews/rust-assert2/rust-assert2.spec
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |code@musicinmybrain.net Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Ben Beasley code@musicinmybrain.net --- No issues found; the package is APPROVED.
----
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
----
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
The spec file is exactly as generated by rust2rpm, greatly simplifying the review.
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/assert2-0.3.16/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files
This is not a serious problem and is due to reasonable design decisions in rust2rpm.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License". 20 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2330715-rust-assert2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- assert2-devel , rust-assert2+default-devel [x]: Package functions as described.
(tests pass)
[x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures.
https://koji.fedoraproject.org/koji/taskinfo?taskID=138132398
[x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: rust-assert2-devel-0.3.16-1.fc44.noarch.rpm rust-assert2+default-devel-0.3.16-1.fc44.noarch.rpm rust-assert2-0.3.16-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0btod1ev')] checks: 32, packages: 3
3 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
2 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.0 s
Source checksums ---------------- https://crates.io/api/v1/crates/assert2/0.3.16/download#/assert2-0.3.16.crat... : CHECKSUM(SHA256) this package : 0d6c710e60d14b07d8f42d0e702b16120865eea39edb751e75cd6bf401d18f14 CHECKSUM(SHA256) upstream package : 0d6c710e60d14b07d8f42d0e702b16120865eea39edb751e75cd6bf401d18f14
Requires -------- rust-assert2-devel (rpmlib, GLIBC filtered): (crate(diff/default) >= 0.1.13 with crate(diff/default) < 0.2.0~) (crate(yansi/default) >= 1.0.1 with crate(yansi/default) < 2.0.0~) cargo crate(assert2-macros/default) rust
rust-assert2+default-devel (rpmlib, GLIBC filtered): cargo crate(assert2)
Provides -------- rust-assert2-devel: crate(assert2) rust-assert2-devel
rust-assert2+default-devel: crate(assert2/default) rust-assert2+default-devel
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2330715 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Python, PHP, Ocaml, fonts, C/C++, Java, R, SugarActivity, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2330715
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-assert2
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com