https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Bug ID: 1285051 Summary: Review Request: nodejs-cjson - Commented JavaScript Object Notation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-cjson/nodejs-cjson.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-cjson/nodejs-cjson-0.3.2-1.... Description: Commented JavaScript Object Notation Fedora Account System Username: jsmith
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Zuzana Svetlikova zsvetlik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1285057
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1285057 [Bug 1285057] Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
--- Comment #1 from Jared Smith jsmith.fedora@gmail.com --- Updated package:
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-cjson/nodejs-cjson.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-cjson/nodejs-cjson-0.3.2-2....
https://bugzilla.redhat.com/show_bug.cgi?id=1285051 Bug 1285051 depends on bug 1285057, which changed state.
Bug 1285057 Summary: Review Request: nodejs-json-parse-helpfulerror - A drop-in replacement for JSON.parse that uses `jju` to give helpful errors https://bugzilla.redhat.com/show_bug.cgi?id=1285057
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |piotr1212@gmail.com Assignee|nobody@fedoraproject.org |piotr1212@gmail.com Flags| |fedora-review+
--- Comment #2 from Piotr Popieluch piotr1212@gmail.com --- Approved
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/1285051-nodejs-cjson/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-cjson-0.3.2-2.fc24.noarch.rpm nodejs-cjson-0.3.2-2.fc24.src.rpm nodejs-cjson.noarch: W: spelling-error %description -l en_US json -> son, j son nodejs-cjson.noarch: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure nodejs-cjson.noarch: W: only-non-binary-in-usr-lib nodejs-cjson.noarch: W: dangling-symlink /usr/lib/node_modules/cjson/node_modules/json-parse-helpfulerror /usr/lib/node_modules/json-parse-helpfulerror nodejs-cjson.src: W: spelling-error %description -l en_US json -> son, j son nodejs-cjson.src: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure 2 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-cjson.noarch: W: spelling-error %description -l en_US json -> son, j son nodejs-cjson.noarch: W: spelling-error %description -l en_US configs -> con figs, con-figs, configure nodejs-cjson.noarch: W: only-non-binary-in-usr-lib nodejs-cjson.noarch: W: dangling-symlink /usr/lib/node_modules/cjson/node_modules/json-parse-helpfulerror /usr/lib/node_modules/json-parse-helpfulerror 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Requires -------- nodejs-cjson (rpmlib, GLIBC filtered): nodejs(engine) npm(json-parse-helpfulerror)
Provides -------- nodejs-cjson: nodejs-cjson npm(cjson)
Source checksums ---------------- https://registry.npmjs.org/cjson/-/cjson-0.3.2.tgz : CHECKSUM(SHA256) this package : 51aed28947049a916b29ffa1f15bfec35f6b357ce0c0b606ebbc92ac83fd939d CHECKSUM(SHA256) upstream package : 51aed28947049a916b29ffa1f15bfec35f6b357ce0c0b606ebbc92ac83fd939d https://raw.githubusercontent.com/kof/node-cjson/master/LICENSE : CHECKSUM(SHA256) this package : 270dcb9f4bfb7c239711fe86f31892e8bd696f5904d9ce0b4995015106ea3fcc CHECKSUM(SHA256) upstream package : 270dcb9f4bfb7c239711fe86f31892e8bd696f5904d9ce0b4995015106ea3fcc
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -x CheckOwnDirs -b 1285051 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1296302
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1296302 [Bug 1296302] Review Request: nodejs-jison - A parser generator with Bison's API
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-cjson
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #4 from Piotr Popieluch piotr1212@gmail.com --- built in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NOTABUG Last Closed| |2016-02-27 17:28:05
https://bugzilla.redhat.com/show_bug.cgi?id=1285051
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTABUG |RAWHIDE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla