Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: lxde-icon-theme - Default icon theme for LXDE
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Summary: Review Request: lxde-icon-theme - Default icon theme for LXDE Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cwickert@fedoraproject.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://cwickert.fedorapeople.org/review/lxde-icon-theme.spec SRPM URL: http://cwickert.fedorapeople.org/review/lxde-icon-theme-0.4.2-2.fc12.src.rpm Description: nuoveXT2 is a very complete set of icons for several operating systems. It is also the default icon-theme of LXDE, the Lightweight X11 Desktop Environment.
Note: This is a split off from lxde-common to avoid unnecessary updates of data that doesn't change.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
--- Comment #1 from Christoph Wickert cwickert@fedoraproject.org 2009-09-05 17:25:31 EDT --- Sorry, wrong file. The correct srpm is http://cwickert.fedorapeople.org/review/lxde-icon-theme-0.4.2-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Dominic Hopf dmaphy@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dmaphy@fedoraproject.org AssignedTo|nobody@fedoraproject.org |dmaphy@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Dominic Hopf dmaphy@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
--- Comment #2 from Dominic Hopf dmaphy@fedoraproject.org 2009-09-05 18:41:49 EDT --- $ rpmlint lxde-icon-theme.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint lxde-icon-theme-0.4.2-2.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint lxde-icon-theme-0.4.2-2.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUSTs -----
OK: packaged is named according to the package naming guidelines OK: specfile name matches %{name}.spec OK: package seems to meet packaging guidelines OK: license in specfile matches actual license and meets licensing guidelines OK: license file is included in %doc OK: specfile is written in AE OK: specfile is legible OK: sourcefile in the package is the same as provided in the mentioned source, md5sum fits OK: package compiles successfully N/A: all build dependencies are listed in BuildRequires there aren't any BuildRequires N/A: package handles locales properly there are no locales installed with this package N/A: call ldconfig in %post and %postun there is no binary installed with this package OK: package is not designed to be relocatable OK: package owns directorys it creates OK: does not list a file more than once in the %files listing OK: %files section includes %defattr and permissions are set properly OK: %clean section is there and contains rm -rf $RPM_BUILD_ROOT OK: macros are consistently used N/A: package contains code package contains *.png files, but this is ok since this is an icon theme N/A: subpackage for large documentation files there are no large documentation files N/A: program runs properly without files listed in %doc there is no program which could be run N/A: header files are in a -devel package there are no header files N/A: static libraries are in a -static package there are no static libs N/A: require pkgconfig if package contains a pkgconfig(.pc) there is no pkgconfig file N/A: put .so-files into -devel package if there are library files with suffix there is no library with suffix, in fact there isn't any library N/A: devel package includes fully versioned dependency for the base package there is no devel package N/A: any libtool archives are removed there are no libtool archives N/A: contains desktop file if it is a GUI application this package actually provides GUI.. OK: package does not own any files or directories owned by other packages OK: buildroot is removed at beginning of %install N/A: filenames are encoded in UTF-8 not necessary since there are no non-ASCII filenames
SHOULD ------ N/A: non-English translations for description and summary a localization is not neccessary for this package OK: package builds in mock N/A: package builds into binary rpms for all supported architectures this is a noarch package N/A: program runs there is no program which could be run N/A: subpackages contain fully versioned dependency for the base package there are no subpackages N/A: pkgconfig file is placed in a devel package there is no pkgconfig file N/A: require package providing a file instead of the file itself no files outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin are required
The package seems to be okay. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Dominic Hopf dmaphy@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Christoph Wickert cwickert@fedoraproject.org 2009-09-05 20:46:52 EDT --- New Package CVS Request ======================= Package Name: lxde-icon-theme Short Description: Default icon theme for LXDE Owners: cwickert Branches: F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2009-09-06 18:05:56 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2009-09-07 08:14:06 EDT --- lxde-icon-theme-0.4.2-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/lxde-icon-theme-0.4.2-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-09-07 08:15:00 EDT --- lxde-icon-theme-0.4.2-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/lxde-icon-theme-0.4.2-2.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-09-08 21:48:52 EDT --- lxde-icon-theme-0.4.2-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lxde-icon-theme'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9389
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-09-08 21:49:57 EDT --- lxde-icon-theme-0.4.2-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update lxde-icon-theme'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9396
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-10-06 06:00:52 EDT --- lxde-icon-theme-0.4.2-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.4.2-2.fc11 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-10-06 06:09:41 EDT --- lxde-icon-theme-0.4.2-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=521431
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.4.2-2.fc11 |0.4.2-2.fc10
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla