Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Hash-Util-FieldHash-Compat - Use Hash::Util::FieldHash or ties, depending on availability
https://bugzilla.redhat.com/show_bug.cgi?id=485206
Summary: Review Request: perl-Hash-Util-FieldHash-Compat - Use Hash::Util::FieldHash or ties, depending on availability Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: allisson@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://allisson.fedorapeople.org/packages/perl-Hash-Util-FieldHash-Compat/pe...
SRPM URL: http://allisson.fedorapeople.org/packages/perl-Hash-Util-FieldHash-Compat/pe...
Description: Under older perls this module provides a drop in compatible api to Hash::Util::FieldHash using perltie. When Hash::Util::FieldHash is available it will use that instead.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485206
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485206
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-02-12 08:05:46 EDT --- Review: + package builds in mock (rawhide i386). koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1121479 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7f5c4a37f1e3d9eb9530597fca299825 Hash-Util-FieldHash-Compat-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is NOT present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=1, Tests=27, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.03 cusr 0.00 csys = 0.04 CPU) + Package perl-Hash-Util-FieldHash-Compat-0.03-1.fc11 -> Provides: perl(Hash::Util::FieldHash::Compat) perl(Hash::Util::FieldHash::Compat::Destroyer) perl(Hash::Util::FieldHash::Compat::Tie::FieldHash) perl(Hash::Util::FieldHash::Compat::Tie::IdHash) Requires: perl(Scalar::Util) perl(Tie::Hash) perl(Tie::RefHash::Weak) perl(constant) perl(strict) perl(vars) perl(warnings)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485206
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Allisson Azevedo allisson@gmail.com 2009-02-12 08:09:29 EDT --- New Package CVS Request ======================= Package Name: perl-Hash-Util-FieldHash-Compat Short Description: Use Hash::Util::FieldHash or ties, depending on availability Owners: allisson Branches: F-9 F-10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485206
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-02-13 01:49:52 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485206
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org