Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: hugo@devin.com.br QAContact: fedora-package-review@redhat.com
Spec URL: http://www.devin.com.br/eitch/rpm/fedora/metamonitor.spec SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/metamonitor-0.4.5-1.src.rpm Description:
metamonitor is a simple program written for KDE, which watches the syslog's or metalog's log file and pops up the window whenever the new message comes. You can specify the file to watch and a regular expression for parsing the log line, so you can watch other than log files too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
------- Additional Comments From panemade@gmail.com 2006-06-01 05:54 EST ------- Not a Review but some hints to improve Packaging 1) Got error when ran rpmlint on SRPM E: metamonitor description-line-too-long can specify the file to watch and a regular expression for parsing the log line, Wrap the %description at 80 columns 2) A lot of compilation warnings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
------- Additional Comments From hugo@devin.com.br 2006-06-08 20:24 EST ------- Thanks for your comment.
Updated package:
Spec URL: http://www.devin.com.br/eitch/rpm/fedora/metamonitor.spec SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/metamonitor-0.4.5-2.src.rpm
Changes:
- Fixed description field size - Applied patch (0) to modify a symlink to be relative
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
------- Additional Comments From michael@knox.net.nz 2006-07-21 05:16 EST ------- Hey.. I will review this submission...
----------------------------------------
Review for release 2:
* RPM name is OK * Source metamonitor-0.4.5.tar.bz2 is the same as upstream * Builds fine in mock * File list looks OK
Needs work: * rpmlint: need to fix rpmlint warnings
Minor: * Duplicate BuildRequires: arts-devel (by kdelibs-devel), qt-devel (by kdelibs-devel)
Notes: rpmlint of metamonitor: W: metamonitor dangling-relative-symlink /usr/share/doc/HTML/en/metamonitor/common ../../en/common
Package looks good, fixup the above and I will give it the green light.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
michael@knox.net.nz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |michael@knox.net.nz OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
------- Additional Comments From hugo@devin.com.br 2006-07-21 15:37 EST ------- Hi Michael,
Searching about the dangling link says that it could (and should) be ignored, it's not a problem, even if rpmlint warns against it. Many KDE apps have this warning with symlinks on their help files, including the base ones.
But I removed the BR as suggested. Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
michael@knox.net.nz changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From michael@knox.net.nz 2006-07-22 15:47 EST ------- OK, none of those are blockers, so cosider this APPROVED.
Please remember to close this review once the package has been imported into CVS and built.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192578
hugo@devin.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From hugo@devin.com.br 2006-07-22 17:23 EST ------- Imported and built! Closing. Thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: metamonitor - A Simple program that watches log files and popup its changes
https://bugzilla.redhat.com/show_bug.cgi?id=192578
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org