[Bug 2268405] New: Review Request: python3-badfish - Badfish is a vendor-agnostic, redfish-based API tool used to consolidate management of IPMI and out-of-band interfaces for common server hardware vendors.
https://bugzilla.redhat.com/show_bug.cgi?id=2268405
Bug ID: 2268405 Summary: Review Request: python3-badfish - Badfish is a vendor-agnostic, redfish-based API tool used to consolidate management of IPMI and out-of-band interfaces for common server hardware vendors. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: grafuls@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/quadsdev/python3-badfish/... SRPM URL: https://download.copr.fedorainfracloud.org/results/quadsdev/python3-badfish/... Description: Badfish is a vendor-agnostic, redfish-based API tool used to consolidate management of IPMI and out-of-band interfaces for common server hardware vendors. Fedora Account System Username: quadsdev
https://bugzilla.redhat.com/show_bug.cgi?id=2268405
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org CC| |benson_muite@emailplus.org Status|NEW |ASSIGNED Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2268405
--- Comment #1 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPLv3'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3", "*No copyright* GNU General Public License, Version 3", "MIT License". 61 files have unknown license. Detailed output of licensecheck in /home/fedora/2268405-python3-badfish/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.12/site-packages, /usr/lib/python3.12 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 37631 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [ ]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/redhat- performance/badfish/archive/v1.0.2/python3-badfish-1.0.2.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-badfish-1.0.2-git.20231102_101116.fc41.noarch.rpm python3-badfish-1.0.2-git.20231102_101116.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp88uxiazn')] checks: 32, packages: 2
python3-badfish.noarch: E: summary-too-long Badfish is a Redfish-based API tool for managing bare-metal systems via the Redfish API python3-badfish.src: E: summary-too-long Badfish is a Redfish-based API tool for managing bare-metal systems via the Redfish API python3-badfish.noarch: E: spelling-error ('redfish', '%description -l en_US redfish -> reddish, red fish, red-fish') python3-badfish.src: E: spelling-error ('redfish', '%description -l en_US redfish -> reddish, red fish, red-fish') python3-badfish.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/badfish/main.py 644 /usr/bin/env python3 python3-badfish.noarch: W: no-manual-page-for-binary badfish 2 packages and 0 specfiles checked; 5 errors, 1 warnings, 10 filtered, 5 badness; has taken 0.3 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python3-badfish.noarch: E: summary-too-long Badfish is a Redfish-based API tool for managing bare-metal systems via the Redfish API python3-badfish.noarch: E: spelling-error ('redfish', '%description -l en_US redfish -> reddish, red fish, red-fish') python3-badfish.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/badfish/main.py 644 /usr/bin/env python3 python3-badfish.noarch: W: no-manual-page-for-binary badfish 1 packages and 0 specfiles checked; 3 errors, 1 warnings, 6 filtered, 3 badness; has taken 0.1 s
Requires -------- python3-badfish (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.12dist(aiohttp) python3.12dist(pyyaml) python3.12dist(setuptools)
Provides -------- python3-badfish: python-badfish python3-badfish python3.12-badfish python3.12dist(badfish) python3dist(badfish)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2268405 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic, Python Disabled plugins: SugarActivity, Haskell, PHP, R, fonts, C/C++, Java, Ocaml, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) The name seems to be used for another package in pypi: https://pypi.org/project/badfish/ perhaps use a different package name, eg. quads-badfish and also put the package on pypi to prevent name collisions. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_pypi_pari... b) Could the new Python packaging guidelines be used: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ c) Can any of the tests be run? If not, can the package be imported? See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests d) Please use SPDX license identifier either GPL-3.0-only or GPL-3.0-or-later e) Build log has the following: /usr/lib/python3.12/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated. !!
******************************************************************************** Please avoid running ``setup.py`` directly. Instead, use pypa/build, pypa/installer or other standards-based tools. Follow the current Python packaging guidelines when building Python RPM packages. See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html and https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ for details.
******************************************************************************** !!
https://bugzilla.redhat.com/show_bug.cgi?id=2268405
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Happy to continue the review.
Product: Fedora Version: rawhide Component: Package Review
Benson Muite benson_muite@emailplus.org has canceled Package Review package-review@lists.fedoraproject.org's request for Benson Muite benson_muite@emailplus.org's needinfo: Bug 2268405: Review Request: python3-badfish - Badfish is a vendor-agnostic, redfish-based API tool used to consolidate management of IPMI and out-of-band interfaces for common server hardware vendors. https://bugzilla.redhat.com/show_bug.cgi?id=2268405
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Happy to continue the review.
https://bugzilla.redhat.com/show_bug.cgi?id=2268405
Gonza grafuls@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org)
--- Comment #4 from Gonza grafuls@redhat.com --- Thank you for looking into this. I believe the 3 standing issues have now been resolved. Can we please have it rechecked? Regards
https://bugzilla.redhat.com/show_bug.cgi?id=2268405
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |
--- Comment #5 from Benson Muite benson_muite@emailplus.org --- spec: https://download.copr.fedorainfracloud.org/results/quadsdev/python3-badfish/... srpm: https://download.copr.fedorainfracloud.org/results/quadsdev/python3-badfish/...
There is still a name conflict on PyPI: https://pypi.org/project/badfish/ Raised issue upstream: https://github.com/redhat-performance/badfish/issues/437
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com