5:01 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Bug ID: 2254930
Summary: Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: linux(a)cmadams.net
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
SRPM URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
Description:
This class provides an interface to interact with a web server that
provides services via the WebSocket protocol in an AnyEvent context.
It uses Protocol::WebSocket rather than reinventing the wheel. You
could use AnyEvent and Protocol::WebSocket directly if you wanted
finer grain control, but if that is not necessary then this class may
save you some time.
Fedora Account System Username: cmadams
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
5:01 p.m.
New subject: [Bug 2254930] Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Chris Adams <linux(a)cmadams.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On| |2254926
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Chris Adams <linux(a)cmadams.net> ---
Note: depends on perl-AnyEvent-Connector (review BZ 2254926)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2254926
[Bug 2254926] Review Request: perl-AnyEvent-Connector - Tcp_connect with
transparent proxy handling
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:33 p.m.
New subject: [Bug 2254930] Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
--- Comment #2 from Chris Adams <linux(a)cmadams.net> ---
Bumped release for spec file cleanups:
Spec URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
SRPM URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
9:26 p.m.
New subject: [Bug 2254930] Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
--- Comment #3 from Chris Adams <linux(a)cmadams.net> ---
Bumped release for additional spec file cleanups:
Spec URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
SRPM URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
2 p.m.
New subject: [Bug 2254930] Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
--- Comment #4 from Chris Adams <linux(a)cmadams.net> ---
Bumped release for additional spec file cleanups:
Spec URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
SRPM URL:
https://cmadams.fedorapeople.org/perl-AnyEvent-WebSocket-Client/perl-AnyE...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
9:54 p.m.
New subject: [Bug 2254930] Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Chris Adams <linux(a)cmadams.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2254934
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2254934
[Bug 2254934] Review Request: perl-WWW-Mechanize-Chrome - Automate the Chrome
browser
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
3:27 a.m.
New subject: [Bug 2254930] Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |ppisar(a)redhat.com
CC| |ppisar(a)redhat.com
Status|NEW |ASSIGNED
Flags| |fedora-review?
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
4:10 a.m.
New subject: [Bug 2254930] Review Request: perl-AnyEvent-WebSocket-Client -
WebSocket client for AnyEvent
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 addresses are Ok.
Source0 archive (SHA512
4d41dd6350342c12cef9dd60ccd7faf9b008e6722057d2f21d816e9c9c989c470866a98fe9b86765deee4e432b788cd13904db6df67993aa7129894a833ee08a)
is original. Ok.
Summary verified from lib/AnyEvent/WebSocket/Client.pm. Ok.
Description verified from lib/AnyEvent/WebSocket/Client.pm. Ok.
License verified from LICENSE, README, dist.ini,
lib/AnyEvent/WebSocket/Client.pm, lib/AnyEvent/WebSocket/Connection.pm,
lib/AnyEvent/WebSocket/Message.pm. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Build-require 'perl(PerlX::Maybe::XS)'. Since you recommend it, it is a
good idea to use it when running tests which exhibit PerlX::Maybe. Otherwise,
you would test code a different code path than is recommended to the users.
TODO: Rewrite 'BuildRequires: perl(Crypt::Random::Source) >= 0.08' as
'BuildConflicts: perl(Crypt::Random::Source) < 0.08'. A purpose of the
dependency is to avoid warnings with too old Crypt::Random::Source
(dist.ini:84).
TODO: Consider packaging ./example as a documentation.
All tests pass. Ok.
$ rpmlint perl-AnyEvent-WebSocket-Client.spec
../SRPMS/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.src.rpm
../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm
======================================== rpmlint session starts
=======================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0
badness; has taken 0.3 s ==
rpmlint is OK.
$ rpm -q -lv -p
../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm
drwxr-xr-x 2 root root 0 Mar 8 01:00
/usr/share/doc/perl-AnyEvent-WebSocket-Client
-rw-r--r-- 1 root root 9266 May 4 2023
/usr/share/doc/perl-AnyEvent-WebSocket-Client/Changes
-rw-r--r-- 1 root root 7390 May 4 2023
/usr/share/doc/perl-AnyEvent-WebSocket-Client/README
drwxr-xr-x 2 root root 0 Mar 8 01:00
/usr/share/licenses/perl-AnyEvent-WebSocket-Client
-rw-r--r-- 1 root root 18359 May 4 2023
/usr/share/licenses/perl-AnyEvent-WebSocket-Client/LICENSE
-rw-r--r-- 1 root root 3896 Mar 8 01:00
/usr/share/man/man3/AnyEvent::WebSocket::Client.3pm.gz
-rw-r--r-- 1 root root 3200 Mar 8 01:00
/usr/share/man/man3/AnyEvent::WebSocket::Connection.3pm.gz
-rw-r--r-- 1 root root 1801 Mar 8 01:00
/usr/share/man/man3/AnyEvent::WebSocket::Message.3pm.gz
drwxr-xr-x 2 root root 0 Mar 8 01:00
/usr/share/perl5/vendor_perl/AnyEvent/WebSocket
-rw-r--r-- 1 root root 12505 May 4 2023
/usr/share/perl5/vendor_perl/AnyEvent/WebSocket/Client.pm
-rw-r--r-- 1 root root 13799 May 4 2023
/usr/share/perl5/vendor_perl/AnyEvent/WebSocket/Connection.pm
-rw-r--r-- 1 root root 2606 May 4 2023
/usr/share/perl5/vendor_perl/AnyEvent/WebSocket/Message.pm
/usr/share/perl5/vendor_perl/AnyEvent is provided by required
perl-AnyEvent-Connector.
File layout and permissions are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm | sort -f
| uniq -c
1 perl(AE)
1 perl(AnyEvent)
1 perl(AnyEvent::Connector)
1 perl(AnyEvent::Handle)
1 perl(AnyEvent::Socket)
1 perl(AnyEvent::WebSocket::Connection)
1 perl(AnyEvent::WebSocket::Message)
1 perl(Carp)
1 perl(Encode)
1 perl(Moo)
1 perl(PerlX::Maybe)
1 perl(Protocol::WebSocket::Frame)
1 perl(Protocol::WebSocket::Handshake::Client)
1 perl(Protocol::WebSocket::Request)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(URI)
1 perl(warnings)
1 perl-libs
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --recommends -p
../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm | sort -f
| uniq -c
1 perl(PerlX::Maybe::XS)
Binary recommends are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm | sort -f
| uniq -c
1 perl(AnyEvent::WebSocket::Client) = 0.55
1 perl(AnyEvent::WebSocket::Connection) = 0.55
1 perl(AnyEvent::WebSocket::Message) = 0.55
1 perl-AnyEvent-WebSocket-Client = 0.55-4.fc41
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-AnyEvent-WebSocket-Client-0.55-4.fc41.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds on Fedora 41
(https://koji.fedoraproject.org/koji/taskinfo?taskID=117740822). Ok.
The package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO items before building this package.
Resolution: This package is APPROVED.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2254930
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
4
days inactive
155
days old
package-review@lists.fedoraproject.org
7 comments
1 participants
participants (1)
-
bugzilla＠redhat.com