https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Bug ID: 2259222 Summary: Review Request: rust-cached_proc_macro_types Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: dmellado@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dmellado.fedorapeople.org/rust-cached_proc_macro_types.spec SRPM URL: https://dmellado.fedorapeople.org/rust-cached_proc_macro_types-0.1.0-1.fc39.... Description: Generic cache implementations and simplified function memoization. Fedora Account System Username: dmellado
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://crates.io/crates/ca | |ched_proc_macro_types
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6922103 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #2 from Fabio Valentini decathorpe@gmail.com ---
# FIXME: no license files detected
This needs to be addressed in some way.
It looks like the upstream repository actually contains license files, but they are not linked into this subdirectory, so "cargo publish" will not include them. Both the Apache-2.0 and MIT licenses require that redistributed sources contain a copy of the actual license text, so this is a hard requirement for us.
Please report this to the upstream project and ask them to include license texts in all published crates.
Here's an example of a similar report that I filed a while ago: https://github.com/Devolutions/picky-rs/issues/230
It is usually fixed easily by adding symbolic links: https://github.com/djc/askama/pull/947
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
--- Comment #3 from Daniel Mellado dmellado@redhat.com --- Proposed PR to upstream project: https://github.com/jaemk/cached/pull/178
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Daniel Mellado dmellado@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://dmellado.fedorapeople.org/rust-cached_proc_macro_types.spec https://dmellado.fedorapeople.org/rust-cached_proc_macro_types-0.1.1-1.fc39.... Description: Generic cache implementations and simplified function memoization. Fedora Account System Username: dmellado
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Daniel Mellado dmellado@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://dmellado.fedorapeople.org/rust-cached_proc_macro_types.spec SRPM URL:https://dmellado.fedorapeople.org/rust-cached_proc_macro_types-0.1.1-1.fc39.... Description: Generic cache implementations and simplified function memoization. Fedora Account System Username: dmellado
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
--- Comment #4 from Daniel Mellado dmellado@redhat.com --- Merged and fixed with the new release, I've updated the spec and SRPM, will post another comment just in case the buildsystem doesn't fetch it, thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
--- Comment #5 from Daniel Mellado dmellado@redhat.com --- Spec URL: https://dmellado.fedorapeople.org/rust-cached_proc_macro_types.spec SRPM URL: https://dmellado.fedorapeople.org/rust-cached_proc_macro_types-0.1.1-1.fc39.... Description: Generic cache implementations and simplified function memoization. Fedora Account System Username: dmellado
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2010163 --> https://bugzilla.redhat.com/attachment.cgi?id=2010163&action=edit The .spec file difference from Copr build 6922103 to 6946444
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6946444 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Daniel Mellado dmellado@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rust-cached_proc_macro_type |rust-cached_proc_macro_type |s |s - Generic cache | |implementations and | |simplified function | |memoization
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- Looks good to me now. Thank you!
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cached_proc_macro_types
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7f6149a3be has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f6149a3be
https://bugzilla.redhat.com/show_bug.cgi?id=2259222
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-01-30 09:55:15
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7f6149a3be has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com