Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Bug ID: 907513 Summary: Review Request: clearlooks-phenix-theme - Clearlooks-Phenix gtk theme Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: rmarko@redhat.com
Spec URL: http://rmarko.fedorapeople.org/packages/clearlooks-phenix-theme.spec SRPM URL: http://rmarko.fedorapeople.org/packages/clearlooks-phenix-theme-3.0.14-1.fc1... Description: Clearlooks-Phenix is a GTK+ 3 port of Clearlooks, the default theme for GNOME 2.
Fedora Account System Username: rmarko
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@v3.sk Assignee|nobody@fedoraproject.org |lkundrak@v3.sk
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #1 from Lubomir Rintel lkundrak@v3.sk --- * Package name correct * Soruce tarball creation properly commented on * License correct and allowed in fedora * Spec file clean and legible * Builds fine in mock
1.) Newer version (3.0.15) is available
2.) Description is not accurate
You speak of gtk3 theme, but ship theme for metacity and gtk2. Are those needed at all?
3.) Requires/provides might need tweaking: see below
Would you mind splitting the themes into subpackages as is done for other theme packages (e.g. zukini), so that you'll have:
clearlooks-phenix-gtk2-theme clearlooks-phenix-gtk3-theme clearlooks-phenix-xfwm4-theme clearlooks-phenix-metacity-theme clearlooks-phenix-openbox-theme clearlooks-phenix-common
You'll be able to fix up the dependency chain then (e.g. not requiring clearlooks gtk2 engine when user only needs gtk3).
Also, you'd be able to add missing Requires (of metacity or gtk+ itself) while not being afraid of dragging in unnecessary packages.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Richard Marko rmarko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rmarko@redhat.com
--- Comment #2 from Richard Marko rmarko@redhat.com --- Done.
Spec URL: http://rmarko.fedorapeople.org/packages/clearlooks-phenix.spec SRPM URL: http://rmarko.fedorapeople.org/packages/clearlooks-phenix-3.0.15-1.fc18.src....
♥
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #3 from Lubomir Rintel lkundrak@v3.sk --- Seems sane now, may God shower you with grace and blessings!
=== clearlooks-phenix-common-3.0.15-1.fc18.noarch === Requires: Provides: clearlooks-phenix-common = 3.0.15-1.fc18
=== clearlooks-phenix-gtk2-theme-3.0.15-1.fc18.noarch === Requires: clearlooks-phenix-common = 3.0.15-1.fc18 gtk2-engines Provides: clearlooks-phenix-gtk2-theme = 3.0.15-1.fc18
=== clearlooks-phenix-gtk3-theme-3.0.15-1.fc18.noarch === Requires: clearlooks-phenix-common = 3.0.15-1.fc18 gtk3 Provides: clearlooks-phenix-gtk3-theme = 3.0.15-1.fc18
=== clearlooks-phenix-metacity-theme-3.0.15-1.fc18.noarch === Requires: clearlooks-phenix-common = 3.0.15-1.fc18 metacity Provides: clearlooks-phenix-metacity-theme = 3.0.15-1.fc18
=== clearlooks-phenix-openbox-theme-3.0.15-1.fc18.noarch === Requires: clearlooks-phenix-common = 3.0.15-1.fc18 openbox Provides: clearlooks-phenix-openbox-theme = 3.0.15-1.fc18
=== clearlooks-phenix-xfwm4-theme-3.0.15-1.fc18.noarch === Requires: clearlooks-phenix-common = 3.0.15-1.fc18 xfwm4 Provides: clearlooks-phenix-xfwm4-theme = 3.0.15-1.fc18
APPROVED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Richard Marko rmarko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Richard Marko rmarko@redhat.com --- New Package SCM Request ======================= Package Name: clearlooks-phenix-theme Short Description: Clearlooks-Phenix is a GTK+ 3 port of Clearlooks, the default theme for GNOME 2. Owners: rmarko Branches: f17 f18 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Richard Marko rmarko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
--- Comment #6 from Richard Marko rmarko@redhat.com --- I'm sorry but the Package name in comment #4 was wrong. It should be
Package Name: clearlooks-phenix
as it was renamed during the review.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Provide a request with the correct name, and then follow the package EOL procedure for the package with the incorrect name.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Richard Marko rmarko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Richard Marko rmarko@redhat.com --- New Package SCM Request ======================= Package Name: clearlooks-phenix Short Description: Clearlooks-Phenix is a GTK+ 3 port of Clearlooks, the default theme for GNOME 2. Owners: rmarko Branches: f17 f18 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- clearlooks-phenix-3.0.15-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/clearlooks-phenix-3.0.15-1.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- clearlooks-phenix-3.0.15-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/clearlooks-phenix-3.0.15-1.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- clearlooks-phenix-3.0.15-1.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-04-03 00:26:52
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- clearlooks-phenix-3.0.15-1.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=907513
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- clearlooks-phenix-3.0.15-1.fc17 has been pushed to the Fedora 17 stable repository.
package-review@lists.fedoraproject.org