[Bug 469471] New: Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: skinlf - Java look and feel for swing

https://bugzilla.redhat.com/show_bug.cgi?id=469471

           Summary: Review Request: skinlf - Java look and feel for swing
           Product: Fedora
           Version: 9
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: mycae(a)yahoo.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Package SkinLF, 6.7

Files:
Spec URL: http://dhd.selfip.com/427e/skinlf.spec
SRPM URL: http://dhd.selfip.com/427e/skinlf-6.7-1.fc9.src.rpm  

Description:
 Skin Look And Feel is able to read GTK (The Gimp ToolKit) and KDE (The K
Desktop Environment) Skins to enhance your application GUI controls such as
Buttons, Checks, Radios, Scrollbars, Progress Bar, Lists, Tables, Internal
Frames, Colors, Background Textures, Regular Windows. This allows for the
skinning of java applications to enhance their look and feel.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


D Haley <mycae(a)yahoo.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |464781
         Depends on|                            |461407




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Bug 469471 depends on bug 461407, which changed state.

Bug 461407 Summary: Review Request: laf-plugin - Generic plugin framework for Java
look-and-feels
https://bugzilla.redhat.com/show_bug.cgi?id=461407

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
         Resolution|WONTFIX                     |



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #1 from D Haley <mycae(a)yahoo.com&gt;  2008-11-16 07:21:10 EDT ---
Files:
Spec URL: http://dhd.selfip.com/427e/skinlf-2.spec
SRPM URL: http://dhd.selfip.com/427e/skinlf-6.7-2.fc9.src.rpm  

- Fix version numbering
- Fix top level dir when building jar

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Chitlesh GOORAH <cgoorah(a)yahoo.com.au&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgoorah(a)yahoo.com.au




--- Comment #2 from Chitlesh GOORAH <cgoorah(a)yahoo.com.au&gt;  2008-11-23 08:00:09 EDT
---
#001: remove the copyright paragraph, else I won't review this package

#002: avoid renaming spec files : %{name}-X.spec. Always keep the spec filenme
as %{name}.spec. I have seen you did the same for all your packages.

#003: rpmlint issues
chitlesh(~)[0]$rpmlint
/home/chitlesh/rpmbuild/RPMS/i386/skinlf-6.7-2.fc9.i386.rpm
skinlf.i386: W: no-documentation
skinlf.i386: E: description-line-too-long Today many applications must be
skinnable: your CD player, your emailnotifier, even your operating system! Now
with Skin Look And Feel, your Java application is skinnable! Skin Look And Feel
is able to read GTK (The Gimp ToolKit) and KDE (The K Desktop Environment)
Skins to enhance your application GUI controls such as Buttons, Checks, Radios,
Scrollbars, Progress Bar, Lists, Tables, Internal Frames, Colors, Background
Textures, Regular Windows.
skinlf.i386: W: non-standard-group skinlf
skinlf.i386: W: invalid-license Apache
skinlf.i386: E: no-binary

Break the description paragraph into seperate lines.

004: Build errors, possible missing BuildRequires:
     [javac]                       ^                                            
    [javac]
/home/chitlesh/rpmbuild/BUILD/skinlf-6.7/build/src/com/l2fprod/tools/msstyles/MsStylesToSkinLF.java:78:
warning: com.sun.org.apache.xpath.internal.XPathAPI is Sun proprietary API and
may be removed in a future release                                              
    [javac]       (Element)XPathAPI.                                            
    [javac]                ^

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #3 from D Haley <mycae(a)yahoo.com&gt;  2008-11-23 09:47:22 EDT ---
Spec URL:
SRPM URL:

>  #001: remove the copyright paragraph, else I won't review this
> package 
Done.

> #002: avoid renaming spec files : %{name}-X.spec. Always keep the spec
> filenme
> as %{name}.spec. I have seen you did the same for all your packages. 
I'm going to do it again, just to be difficult -- my local copy is always
blahblah.spec, only the bugzilla copies are blahblah-rev.spec. Sorry. How do I
make sure other people on the 'net can see the changes in the spec files after
I have made them? Is there a good way to do this?

> #003: rpmlint issues
> skinlf.i386: W: no-documentation 
Fixed.

> skinlf.i386: E: description-line-too-long 
Fixed.

> skinlf.i386: W: non-standard-group skinlf 
Fixed.

> 004: Build errors, possible missing BuildRequires:
> ...
> warning: com.sun.org.apache.xpath.internal.
> XPathAPI is Sun proprietary API and may be removed in a future release   
Not
technically errors, these warnings arise due to my usage of the sun xpath
api as a substitute for the org.apache.xpath api (patch #3), which was removed
as of sun JRE1.5 [1]. I can look at this again to see if I can make it work
without the patch, but that will have to wait. The package itself will still
work with the sun API, it just means that I may have to revisit and update
later. I'd rather continue with the current sun API if no-one knows how to
solve this properly, and doesn't object to doing so. Just so we can lift the
block on other bugs


> skinlf.i386: W: invalid-license Apache 
Not fixed -- I am unsure
how to proceed here. If you examine the LICENSE file
in the source, it isn't Apache, contrary to what's on their website [2]. Its a
redistributable with attribution licence, which doesn't appear up in the
rpmlint -iv output. Which licence should I select??


Current RPMlint output:
$ rpmlint -i skinlf-6.7-3.fc9.src.rpm 
skinlf.src: W: invalid-license Apache 2.0


Thanks for taking a look at the package!

[1]
http://java.sun.com/j2se/1.5.0/docs/guide/xml/jaxp/JAXP-Compatibility_150...
[2] https://skinlf.dev.java.net/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #4 from D Haley <mycae(a)yahoo.com&gt;  2008-11-23 09:48:55 EDT ---
*sigh* One more time... 

URLS:
Spec: http://www.dhd.selfip.com/427e/skinlf-3.spec
SRPM: http://www.dhd.selfip.com/427e/skinlf-6.7-3.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #5 from D Haley <mycae(a)yahoo.com&gt;  2008-11-23 09:54:08 EDT ---
*sigh* again. There is no www prefix. 

URLS:
Spec: http://dhd.selfip.com/427e/skinlf-3.spec
SRPM: http://dhd.selfip.com/427e/skinlf-6.7-3.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Bug 469471 depends on bug 461407, which changed state.

Bug 461407 Summary: Review Request: laf-plugin - Generic plugin framework for Java
look-and-feels
https://bugzilla.redhat.com/show_bug.cgi?id=461407

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Rudolf Kastl <che666(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |che666(a)gmail.com




--- Comment #6 from Rudolf Kastl <che666(a)gmail.com&gt;  2008-11-23 21:13:58 EDT ---
build seems to error out aswell without laf-plugin installed so shouldnt that
also have a BuildRequires on it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #7 from D Haley <mycae(a)yahoo.com&gt;  2008-11-24 07:13:41 EDT ---
> build seems to error out aswell without laf-plugin installed so
> shouldnt that
> also have a BuildRequires on it? 
Does Requires not imply BuildRequires? I was under the (maybe incorrect)
assumption that buildrequires was just a weaker form of requires (ie Requires,
but only at build time)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #8 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2008-11-24 07:51:01
EDT ---
(In reply to comment #7)
>  >build seems to error out aswell without laf-plugin installed so
> shouldnt that
>  >also have a BuildRequires on it?
>  
>  Does Requires not imply BuildRequires?  
No.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #9 from D Haley <mycae(a)yahoo.com&gt;  2008-11-28 19:09:20 EDT ---
Spec: http://dhd.selfip.com/427e/skinlf-4.spec
SRPM: http://dhd.selfip.com/427e/skinlf-6.7-4.fc9.src.rpm

* Sat Nov 29 2008 <mycae(a!t)yahoo.com> 6.7-4
- Updated BuildRequires to inlcude laf-plugin
- Silence several rpmlint errors
 - ASL 2.0 vs Apache Source Licence 2.0
 - Fix arch
 - Fix EOL on docs.

> build seems to error out aswell without laf-plugin installed so
> shouldnt that
> also have a BuildRequires on it? 
Fixed

rpmlint:

$ rpmlint -iv ../SRPMS/skinlf-6.7-4.fc9.src.rpm 
skinlf.src: I: checking
$ rpmlint -iv ../RPMS/noarch/skinlf-6.7-4.fc9.noarch.rpm 
skinlf.noarch: I: checking
$ rpmlint -iv skinlf.spec 

Known issues :

comment 3
> >skinlf.i386: W: invalid-license Apache
> Not fixed -- I am unsure how to proceed here. If you examine the LICENSE file
> in the source, it isn't Apache, contrary to what's on their website [2]. Its a
> redistributable with attribution licence, which doesn't appear up in the
> rpmlint -iv output. Which licence should I select?? 
-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #10 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2008-12-02
11:53:21 EDT ---
* Licensing
  - I guess src/examples/Clock.java is non-free. So if this file is not
    needed, please remove this file (and also .jar/.dll files) and
    repackage the zip source:
   
https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Pro...

    * Then the license tag must be "ASL 1.1 and ASL 2.0 and zlib".
---------------------------------------------------------------------------
LICENSE:  ASL 1.1
LICENSE_nanoxml: zlib

src/com/l2fprod/gui/plaf/skin/LafPluginSupport.java ASL 2.0
src/com/l2fprod/util/WeakImageIcon.java                 ASL 2.0
src/examples/Clock.java ???
---------------------------------------------------------------------------
    * Also, add "LICENSE_nanoxml" to %doc.

  - If src/examples/Clock.java is needed, I wil ask spot whether the
    license is free or not.

* BuildRequires, Requires
  - For java depedency, please follow:
    https://fedoraproject.org/wiki/Packaging/Java#BuildRequires_and_Requires
    If this package needs Java openjdk, the BuildRequires should have
    "BuildRequires: java-devel >= 1:1.6.0".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|9                           |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #11 from D Haley <mycae(a)yahoo.com&gt;  2008-12-03 08:11:12 EDT ---
SPEC URL: http://dhd.selfip.com/427e/skinlf-5.spec
SRPM URL: http://dhd.selfip.com/427e/skinlf-6.7-5.fc9.srpm

RPMLint on SRPM, SPEC and RPM are empty

> * Also, add "LICENSE_nanoxml" to %doc. 
Done.

>  If src/examples/Clock.java is needed, I will ask spot whether the
>  license is free or not. 
Done. Removed by deletion in %prep -- the examples are only
compressed into the
jar and are not required at compile. 

Q: How do I provide the srpm? With Clock.java or without -- if I make it with,
it still contains it (just not the RPM). If I make it without then it will
require me to recompress the source tarball, making the Source0 line invalid. 

>  (and also any .jar.dll files) 
Not needed/implicit. The output
of find ./ -name  blah, where blah is *.jar,
*so and *dll, is empty. This was the case for the prior revision. The prior
revision included the standard check for java files from the packaging
guidelines to ensure that the package will not build if any file *.jar is
located within the build tree. This check is performed at %prep time.

>  BuildRequires, Requires 
Done. Imported any missing java deps
from previous package "laf-plugin".
Specifically jpackage-utils and updated java lines for req & buildreq.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Sandro Mathys <red(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |red(a)fedoraproject.org




--- Comment #12 from Sandro Mathys <red(a)fedoraproject.org&gt;  2008-12-05 18:17:56 EDT
---
just two things I noticed (I'm about to create a package that will depend on
skinlf):

1) there jar should be named %{name}-%{version}.jar with a symlink %{name}.jar
to it. Right now, only %{name}.jar is installed to the %{_javadir}. ls -al
/usr/share/java will show you, that (most?) packages do it like that.

2) the jar should contain the class files, not the source files ;)

instead of:
pushd .
cd build/src
jar cf %{name}-%{version}.jar .
popd

do:
pushd build/classes
jar cf %{name}-%{version}.jar .
popd

of course, you'll need to change the path in the install cmd after that, too.

I've tested that change and it works fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #13 from D Haley <mycae(a)yahoo.com&gt;  2008-12-05 21:18:35 EDT ---
I'm actually away for the better part of a week, however I have access to my
webserver, but not my build machine (aka my desktop). As such I have uploaded a
modified "tentative" spec file. Be warned that I cannot even test for
approximate correctness.
URL: http://dhd.selfip.com/427e/skinlf-6-tentative.spec


> 1) there jar should be named %{name}-%{version}.jar with a symlink
> %{name}.jar
> to it. Right now, only %{name}.jar is installed to the %{_javadir}. ls -al
> /usr/share/java will show you, that (most?) packages do it like that. 
Changed name & linked. I did look at this and in my java dir, IIRC, it was
split between %{name}-%{version} and %{name} for the primary file.

> 2) the jar should contain the class files, not the source files ;)
Fixed. Well that was stupid. 

I hope this package is almost there. My packages seem to have a nasty tendency
of being a mess at the start -- something I need to attend to in the future.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Sandro Mathys <red(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |472144




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody(a)fedoraproject.org    |mtasaka(a)ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #14 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2008-12-07
10:16:07 EDT ---
Sorry for delay...

Seems good, however as I wrote in my comment 10 (and as you wondered)
since Clock.java must be removed from source zip file, the zip file
must be re-packaged. Please follow:

https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Pro...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #15 from D Haley <mycae(a)yahoo.com&gt;  2008-12-10 04:43:59 EDT ---
SPEC URL: http://dhd.selfip.com/427e/skinlf-6.spec
SRPM URL: http://dhd.selfip.com/427e/skinlf-6.7-6.fc9.src.rpm 

> Seems good, however as I wrote in my comment 10 (and as you wondered)
> since Clock.java must be removed from source zip file, the zip file
> must be re-packaged. 
Done.

rpmlint output is empty for spec, SRPM and RPM. I set the permissions on the
tarball generator to 644, so if you wish to use it, you have to set execute
permissions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #16 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2008-12-11
12:00:13 EDT ---
Seems good, approved.
---------------------------------------------------------
   This package (skinlf) is APPROVED by mtasaka
---------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


D Haley <mycae(a)yahoo.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs+




--- Comment #17 from D Haley <mycae(a)yahoo.com&gt;  2008-12-11 17:02:55 EDT ---
New Package CVS Request
=======================
Package Name: skinlf
Short Description: Java look and feel for swing 
Owners: mycae
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Kevin Fenzi <kevin(a)tummy.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+




--- Comment #18 from Kevin Fenzi <kevin(a)tummy.com&gt;  2008-12-13 23:54:53 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #19 from Fedora Update System <updates(a)fedoraproject.org&gt;  2008-12-14
05:35:29 EDT ---
skinlf-6.7-6.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/skinlf-6.7-6.fc9

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #20 from Fedora Update System <updates(a)fedoraproject.org&gt;  2008-12-14
05:36:13 EDT ---
skinlf-6.7-6.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/skinlf-6.7-6.fc10

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #21 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2008-12-15
09:42:27 EDT ---
Please also rebuild for dist-f11.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #22 from D Haley <mycae(a)yahoo.com&gt;  2008-12-16 06:56:17 EDT ---
Do I need to repeat my CVS req?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #23 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2008-12-16
10:28:36 EDT ---
No. "devel" branch is already created on Fedora CVS and
you can already rebuild this package for dist-f11.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA




--- Comment #24 from Fedora Update System <updates(a)fedoraproject.org&gt;  2008-12-17
19:36:40 EDT ---
skinlf-6.7-6.fc10 has been pushed to the Fedora 10 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update skinlf'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2008-11321

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #25 from Fedora Update System <updates(a)fedoraproject.org&gt;  2008-12-17
19:42:14 EDT ---
skinlf-6.7-6.fc9 has been pushed to the Fedora 9 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update skinlf'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F9/FEDORA-2008-11295

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471


Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #26 from Fedora Update System <updates(a)fedoraproject.org&gt;  2009-01-07
04:06:53 EDT ---
skinlf-6.7-6.fc10 has been pushed to the Fedora 10 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 469471] Review Request: skinlf - Java look and feel for swing

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469471





--- Comment #27 from Fedora Update System <updates(a)fedoraproject.org&gt;  2009-01-07
04:12:01 EDT ---
skinlf-6.7-6.fc9 has been pushed to the Fedora 9 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.